Received-SPF: pass (google.com: domain of linux-kernel+bounces-170023-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 6 May 2024 16:49:40 +0200
From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: syzbot <syzbot+f534bd500d914e34b59e@syzkaller.appspotmail.com>
Cc: andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
	daniel@iogearbox.net, davem@davemloft.net, edumazet@google.com,
	hawk@kernel.org, john.fastabend@gmail.com, kuba@kernel.org,
	linux-kernel@vger.kernel.org, lorenzo@kernel.org,
	netdev@vger.kernel.org, pabeni@redhat.com,
	syzkaller-bugs@googlegroups.com, toke@redhat.com
Subject: Re: [syzbot] [bpf?] [net?] WARNING in __xdp_reg_mem_model
Message-ID: <ZjjuBCk33QtxLrAm@lore-desk>
References: <0000000000004cc3030616474b1e@google.com>
 <000000000000ae301f0617a4a52c@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="vAieqiNxGUQydHCv"
Content-Disposition: inline
In-Reply-To: <000000000000ae301f0617a4a52c@google.com>


--vAieqiNxGUQydHCv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> syzbot has bisected this issue to:
>=20
> commit 2b0cfa6e49566c8fa6759734cf821aa6e8271a9e
> Author: Lorenzo Bianconi <lorenzo@kernel.org>
> Date:   Mon Feb 12 09:50:54 2024 +0000
>=20
>     net: add generic percpu page_pool allocator
>=20
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=3D151860d498=
0000
> start commit:   f99c5f563c17 Merge tag 'nf-24-03-21' of git://git.kernel.=
o..
> git tree:       net
> final oops:     https://syzkaller.appspot.com/x/report.txt?x=3D171860d498=
0000
> console output: https://syzkaller.appspot.com/x/log.txt?x=3D131860d4980000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=3D6fb1be60a193d=
440
> dashboard link: https://syzkaller.appspot.com/bug?extid=3Df534bd500d914e3=
4b59e
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=3D17ac600b180=
000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=3D1144b797180000
>=20
> Reported-by: syzbot+f534bd500d914e34b59e@syzkaller.appspotmail.com
> Fixes: 2b0cfa6e4956 ("net: add generic percpu page_pool allocator")
>=20
> For information about bisection process see: https://goo.gl/tpsmEJ#bisect=
ion
>=20

Looking at the code, the root cause of the issue is the WARN(1) in
__xdp_reg_mem_model routine. __mem_id_init_hash_table() can fail just if rht
allocation fails. Do we really need this WARN(1)? It has been introduced in=
 the
commit below:

commit 8d5d88527587516bd58ff0f3810f07c38e65e2be
Author: Jesper Dangaard Brouer <brouer@redhat.com>
Date:   Tue Apr 17 16:46:12 2018 +0200

    xdp: rhashtable with allocator ID to pointer mapping

Regards,
Lorenzo

--vAieqiNxGUQydHCv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZjjuBAAKCRA6cBh0uS2t
rHE8AP9aiQe9PRxjbu8EA3OAzA4evmD4DeMhokGWsZjanPp69QD/Qr+N4crIXk/4
h4vZ5Fo/cpxn4NjaaMLCYwTl/2NQ5Qw=
=QBb4
-----END PGP SIGNATURE-----

--vAieqiNxGUQydHCv--