Received-SPF: pass (google.com: domain of linux-kernel+bounces-170031-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 6 May 2024 23:58:29 +0900
From: Mark Brown <broonie@kernel.org>
To: Alina Yu <alina_yu@richtek.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	johnny_lai@richtek.com, cy_huang@richtek.com
Subject: Re: [PATCH v2 2/4] regulator: rtq2208: Fix LDO to be compatible with
 both fixed and adjustable vout
Message-ID: <ZjjwFTtiopqsYdeJ@finisterre.sirena.org.uk>
References: <cover.1714467553.git.alina_yu@richtek.com>
 <ffeecd61c194df1f7f049bd50cb2bbbad3cf1025.1714467553.git.alina_yu@richtek.com>
 <ZjGmmYWHu-ZQQdIh@finisterre.sirena.org.uk>
 <20240502073029.GA4055@linuxcarl2.richtek.com>
 <20240502092614.GA31518@linuxcarl2.richtek.com>
 <ZjRAsJHn57pZy5UH@finisterre.sirena.org.uk>
 <20240503073536.GA12846@linuxcarl2.richtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="NWYZTbv7SVE/Vla5"
Content-Disposition: inline
In-Reply-To: <20240503073536.GA12846@linuxcarl2.richtek.com>


--NWYZTbv7SVE/Vla5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 03, 2024 at 03:35:36PM +0800, Alina Yu wrote:
> On Fri, May 03, 2024 at 10:41:04AM +0900, Mark Brown wrote:

> > That's a substantail reconfiguration of the regulator, it would be
> > better to have an explicit property for these non-standard fixed
> > voltages rather than trying to do this using constraints, or at the very
> > least have validation that the values being set are supported by the
> > hardware.  The code should also be very clear about what is going on.

> May I add the 'richtek,use-fix-dvs' property back ?

It sounds like it might be better to add a property specifying the
specific fixed voltage rather than overloading the constraints for this
purpose.

--NWYZTbv7SVE/Vla5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY48BQACgkQJNaLcl1U
h9D0DAf/RuCsPm8RlbY4B3VwnIhIqwY5eVOgY/7xtH1X5VaqtD4f/b+Eho2MduNW
4rlRWmLei3uDTCweT84Eby8IM6Sc6R1iubkuoHWx1PCEI6b6g+t5OItYU6FIQ172
lMP7MkYrXCOlijpc1CkkRwerQt8++nI133+bBO700hS9ZBOzCf9/4homcJ4akgXu
JS3MAWA6R4Tl5JArwHroznZYvFuy4gZv0YkTOzojQGNWsCNbdERIpI2VbqCiT2WZ
flqkFLav/N36bXpSkoR5T2FCa5E7yWrOJzjKA5V09thwOWWAAEHkl3n1cfNmROMI
ZvYxIeEPx7V9SxA6c4ZzR1BLzJq/Ug==
=8mGb
-----END PGP SIGNATURE-----

--NWYZTbv7SVE/Vla5--