Received-SPF: pass (google.com: domain of linux-kernel+bounces-170065-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 7 May 2024 00:15:06 +0900
From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Liao Chang <liaochang1@huawei.com>, catalin.marinas@arm.com,
	will@kernel.org, maz@kernel.org, oliver.upton@linux.dev,
	james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com,
	tglx@linutronix.de, ardb@kernel.org, anshuman.khandual@arm.com,
	miguel.luis@oracle.com, joey.gouly@arm.com, ryan.roberts@arm.com,
	jeremy.linton@arm.com, ericchancf@google.com,
	kristina.martsenko@arm.com, robh@kernel.org,
	scott@os.amperecomputing.com, songshuaishuai@tinylab.org,
	shijie@os.amperecomputing.com, akpm@linux-foundation.org,
	bhe@redhat.com, horms@kernel.org, mhiramat@kernel.org,
	rmk+kernel@armlinux.org.uk, shahuang@redhat.com,
	takakura@valinux.co.jp, dianders@chromium.org, swboyd@chromium.org,
	sumit.garg@linaro.org, frederic@kernel.org, reijiw@google.com,
	akihiko.odaki@daynix.com, ruanjinjie@huawei.com,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	kvmarm@lists.linux.dev
Subject: Re: [PATCH v3 1/8] arm64/sysreg: Add definitions for immediate
 versions of MSR ALLINT
Message-ID: <Zjjz-tzLRC2nH51A@finisterre.sirena.org.uk>
References: <20240415064758.3250209-1-liaochang1@huawei.com>
 <20240415064758.3250209-2-liaochang1@huawei.com>
 <ZjUKMWPknEhLYoK8@FVFF77S0Q05N>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="AJCRMQbglmQeiqgZ"
Content-Disposition: inline
In-Reply-To: <ZjUKMWPknEhLYoK8@FVFF77S0Q05N>


--AJCRMQbglmQeiqgZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 03, 2024 at 05:00:49PM +0100, Mark Rutland wrote:
> On Mon, Apr 15, 2024 at 06:47:51AM +0000, Liao Chang wrote:

> +#define PSTATE_ALLINT                  pstate_field(1, 0)

> +#define set_pstate_allint(x)           asm volatile(SET_PSTATE_ALLINT(x))

Hrm, those helpers are not ideally discoverable, partly due to the
system register description for ALLINT not providing any references to
this being a general scheme (which is fixable there) and partly due to
the use of __emit_inst() with a numeric literal - we should probably add
a comment next to the __emit_inst() saying what instruction we are
emitting.

--AJCRMQbglmQeiqgZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmY48/kACgkQJNaLcl1U
h9DFDgf9Fgw5UkzUrclx6ZUwslgWzoPOBx1IoBt1ouEpv32VHyFUSbHDNh0ajstZ
1tKqFwGNCSdXpfE09if2stHiiPfY8yxj9O2j+dibQVxKtxmS0RuoApWX/TzEv7Wy
1ERNBrIbdi3rDAZBRnLmnFw8pSwlDz+asThIgwBPmyW7HfPVZeuU+l7b/V24aTwg
4YGmRsYUG6f/oTl8DUmQwdAIwLfJrleBpli38lHUWAtnsPtv/d8SoyrG39CqoCIj
Cx9TXVNB9Vfd6H19q8DF9R3kqadtH5tINEcqLzea3Bh+ccikUa6wow0k5wEgRPVc
40WlPAXdINuZ4vKrXG00G8so0yfCSQ==
=4fOc
-----END PGP SIGNATURE-----

--AJCRMQbglmQeiqgZ--