Received-SPF: pass (google.com: domain of linux-kernel+bounces-170068-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 6 May 2024 10:23:04 -0500
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>,
	bhelgaas@google.com, dave.hansen@linux.intel.com, x86@kernel.org,
	linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'
Message-ID: <20240506152304.GA1699729@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZjjsiO33y08dJLPX@gallifrey>

On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> * Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote:
> > On Mon, 6 May 2024, linux@treblig.org wrote:
> > 
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > 
> > > This doesn't look like it was ever used.
> > 
> > Don't start with "This" but spell what you're talking about out so it 
> > can be read and understood without shortlog in Subject (or looking into 
> > the code change).
> 
> I'm of course happy to rework that if it helps you, although
> I thought the subject line was sufficient.

It's a minor point, to be sure.  The way I think about this is "an
essay title is not part of the essay itself," so the essay (commit
log) should make sense all by itself.

Bjorn