Received: by 2002:ab2:7b86:0:b0:1f7:5705:b850 with SMTP id q6csp1471731lqh; Mon, 6 May 2024 08:38:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUCfxvKHUV89dULSTLgS740vQHra0MOfrXhsBWAqBdYB5GhcqoK8XajACfqn7yEp3SbArwPgVORYIiOv/nBTCIaTzKjgnwAZCgU0TWQOQ== X-Google-Smtp-Source: AGHT+IEtOVN3V7b/S42wzb5KbEYMVOHv7XjJ78W0dtL+cTDok/NGBSE9GDaUJFVHJJkjsOzF15+0 X-Received: by 2002:a05:6a21:2787:b0:1af:baf9:fef6 with SMTP id rn7-20020a056a21278700b001afbaf9fef6mr838119pzb.16.1715009915930; Mon, 06 May 2024 08:38:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715009915; cv=pass; d=google.com; s=arc-20160816; b=uKPZFjxywkN5pAZTpWSPOpMpWnQY3muuedb7HKBznwkVAbhhoaQ2UHmJa9FwqgO5Du 13HgZtPb6vSyAN9URsTcSXXN5hqDZriQhZoK4K5YuY5tOQPGzNZr4lH87wMU3QdEpM1W 1ejlewyg31rNzLqwMe8L4K1nvM7Ez1HYx7P9f3jfPUkKnWgoQpyIHHGSUMf+JswnT6hO kOe4RFaNzOSi1dUP+cknkhIL4CzqDA36MYkWk4KM6PMQP1ffRO5E2K+xXBQpGudKq+eD clATgQOUWqaNYT/hWqFpWDzHSHeE6l141Ha5p29RQ3ytjQqTlnhswtlIkNIOce+VVwgM y5XQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=pk9LMXabMzkFbpwcGW9jTFZ/+0SjvpxAqad2E/PjO68=; fh=oywe8fchwUPDMSBCueBpScnVigbjtkdvdsMA/XGjTz0=; b=U6tSO2tuFEkMKSrUT0E2P5gMN+1rybWr8sYD1B/K7rbr8AXoDZxxdFnmpn7zit6KSn nbGGcnlRLGKlY/f9hB1/dj38LPQxwUm8RTjT8LbFBdEBNkjaKGULzEnuohkWoNDL9x2R 9VLnCaoagf9I+7epHGBfhD30vEUf5EHEVk3tK1w4+3GwKHaNRou7WsfiN49rYzQjWPYp FkcHXwJ5Z5DR9PdHRUv1wRzlTQB3hiW0DSjU+oyVhFJ5YhgWQpTjAsyloMnKPPg3V2fH afwt0h6N+VehBnkMtWRurIk5eDLwpPbA0cWlr8efiP+6Zmwk6CtCHxZYAv/UI7XZ3+EL J92Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n7Zj3Awx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170081-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170081-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jw21-20020a056a00929500b006f44eb525c8si6518566pfb.96.2024.05.06.08.38.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 08:38:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170081-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=n7Zj3Awx; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170081-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170081-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B21C52849CD for ; Mon, 6 May 2024 15:38:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 289ED15574F; Mon, 6 May 2024 15:38:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n7Zj3Awx" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A2042F2C; Mon, 6 May 2024 15:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715009898; cv=none; b=SPetaiPK6PwBHoqn8ep47uUW7g/xTkAt6LSvf2jufmzdVPY7mA3TMWd21E9TcD2lIdqOC0W08uspzcwNgT9i1TvRnRqY7irvFX/3D2JUB64D1KxXDBFGMeN72M1BoOSjVXwPcpAzl0BJtPrTQXqQpBPatfPKRfX/RVRGSLVFg+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715009898; c=relaxed/simple; bh=lq8TajzvkOy47+/9bqCVcmF6c929YJyj/nUUZTCovm4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S2VKKWb8a+qjHC+Z3guuGUXesotrBOQaKWrlfEsWTPIyNbBriMp9ywjvpu+oclWQ3TLvxmkHm2eYC14xmmllqVTkBv8JZsZyzbyxWlWEHPo71c1f0WAeCxprBxyNUi2nIJ9wYJbWLmpL5NWolOlC1cq54EePFI6tLywA5Z8X/hA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n7Zj3Awx; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36911C4AF65; Mon, 6 May 2024 15:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715009897; bh=lq8TajzvkOy47+/9bqCVcmF6c929YJyj/nUUZTCovm4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n7Zj3AwxmJwLMch2uiuWHfIw/+RCg28CT2orj1uvNh5BdrjxqjNIzFWH6d8I42SZf 6we56ge5QdhaRdhYlF8jnXomD8zp9h8BdHC2rAo2hrEOx5HpiLUX3vftCzp+Q1iRJ4 01Fd7xzg+0ftVm5WygjFyLdgKUFm6YFX1eSZCRdqcypOCCwMRZDOXER1gUX86ZjO+E DunEI8syC+HcF04aT6GYGUIFG47KS0cAQkqF4nlo7UjglQGAg/rxD/7iwuGbjEG9Gn au+UhFluNtFayIwLkbf1eI+hdwwvmYUWan7HSZzqKGZI+83BU/bkbjgJAIligbdd7K Xe07H9RFYSnrA== Message-ID: <3903300d-9d5b-44b3-95fa-0579e5421071@kernel.org> Date: Mon, 6 May 2024 17:38:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: add I3C config in DTS To: Delphine CC Chiu , patrick@stwcx.xyz, joel@jms.id.au, openbmc@lists.ozlabs.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Jeffery Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20240506113306.1283179-1-Delphine_CC_Chiu@wiwynn.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240506113306.1283179-1-Delphine_CC_Chiu@wiwynn.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 06/05/2024 13:33, Delphine CC Chiu wrote: > Set I3C config in yosemite4 DTS. > > Test plan: > Tested with aspeed I3C patches and I3C hub driver. > > Signed-off-by: Delphine CC Chiu > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 86 +++++++++++++++++++ > 1 file changed, 86 insertions(+) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index 64075cc41d92..6a30c424d745 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > @@ -595,6 +595,92 @@ i2c-mux@72 { > }; > }; > > +&i3c0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i3c1_default>; > + i3c-pp-scl-hi-period-ns = <40>; > + i3c-pp-scl-lo-period-ns = <40>; > + i3c-od-scl-hi-period-ns = <380>; > + i3c-od-scl-lo-period-ns = <620>; > + sda-tx-hold-ns = <10>; > + > + mctp-controller; > + hub@0x70 { That's not a valid unit address. > + reg = <0x70 0x3c0 0x00700000>; > + cp0-ldo-en = "enabled"; > + cp1-ldo-en = "enabled"; > + cp0-ldo-volt = "1.2V"; > + cp1-ldo-volt = "1.2V"; > + tp0145-ldo-en = "enabled"; > + tp2367-ldo-en = "enabled"; > + tp0145-ldo-volt = "1.2V"; > + tp2367-ldo-volt = "1.2V"; > + tp0145-pullup = "2k"; > + tp2367-pullup = "2k"; Where are bindings for all this? Best regards, Krzysztof