Received-SPF: pass (google.com: domain of linux-kernel+bounces-170093-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <45f6991d-1595-4ba1-956b-acfcbbdfe8de@web.de>
Date: Mon, 6 May 2024 17:50:19 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v3 2/2] ax25: Change kfree() in ax25_dev_free() to
 ax25_dev_put()
To: Dan Carpenter <dan.carpenter@linaro.org>,
 Duoming Zhou <duoming@zju.edu.cn>, linux-hams@vger.kernel.org,
 netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 =?UTF-8?Q?J=C3=B6rg_Reuter?= <jreuter@yaina.de>,
 Paolo Abeni <pabeni@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
 Lars Kellogg-Stedman <lars@oddbit.com>, Simon Horman <horms@kernel.org>
References: <cover.1715002910.git.duoming@zju.edu.cn>
 <53925353450dea9a705d67ad225b589e8508042c.1715002910.git.duoming@zju.edu.cn>
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <53925353450dea9a705d67ad225b589e8508042c.1715002910.git.duoming@zju.edu.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:IMt04jr/M9U=;H1eGqO+BBW3jUOXk2stzLFN+eog
 L+RgGRdGcqtQlntEPB9fuk3V1HW0lxR+KgCX1jgBCuOylADU9aOr35dvDYotD16I4BlLIjyqh
 g4fS6fyyN/jNx3fSQxP5cmA5qgrVmuJCSATNmGuSj1478F4DaUJP/GWyxp49isqDym6G8/qK3
 vcqTWngvjCNVfWsodLJ/6GeSKSVu/K1kz4aQodPU1GARlYfm+2WUud1kljw8UQCNlR5lOVU+B
 20yanfXneOFYaOFzuLyA6LtAYkEEThQLKhKbYP367CjgmY9Eo4HWzDXCaosBVHQmZgWENExba
 fz6fXGj2K7h9o1dpFYJPNYL7n+X1cUqyK5q3UBfhXJ95DvAuDRXKo1jubc9uKfCjEzg+QkMMD
 ttC1OUeRsDbRjp7WZjNzALqc/t3J0zLVan8UQmH8AwYF1pt1UssbL1jodbt4eXVDPohJuMRXy
 jJOb2U1Pg0wMeRyC7/ThM3czS/phRAfQmiK5AOWf1WM5AvPRD/dvFiXiH05DO2M588FZYFrn+
 0NOlMfNHilJc9vIpzNsmwUGJ2HIMoAs8RKfrzW/v5OXzuIIqt8HOenhh8M84yvhVl6smk6CqB
 i40J3XF86mqXc3RNuEgi+LN7+aS7lEoSvncWX34djQVC5nC8H5tkbe3ivnXA4jUY08vIFE43y
 YZS4F/rDy6IrCWUnmiUv7raGxyEi79HUAJc/RZJxY1M8qcV0RJvEItbH88MldXwJagDhxMxty
 Ss6bFwACuATiotdZtspMPVuDJXXVJGzpTxzn4GP6xsvvSgbD22rTkUhGa8NDA6OeVYMmZr6zM
 166wUZOK2Gv+8VFC88m3jx7WWwbOcAAr41GtPz28/BKlo=

=E2=80=A6
> Replace it with a ax25_dev_put() call instead.
=E2=80=A6
> ---
> Changes in v3:
>   - Make commit messages more clearer.
=E2=80=A6
> +++ b/net/ax25/ax25_dev.c
> @@ -188,16 +188,13 @@ struct net_device *ax25_fwd_dev(struct net_device =
*dev)
>   */
>  void __exit ax25_dev_free(void)
>  {
=E2=80=A6
> -	ax25_dev =3D ax25_dev_list;
> -	while (ax25_dev !=3D NULL) {
> -		s        =3D ax25_dev;
> -		netdev_put(ax25_dev->dev, &ax25_dev->dev_tracker);
> -		ax25_dev =3D ax25_dev->next;
> -		kfree(s);
> +	list_for_each_entry_safe(s, n, &ax25_dev_list, list) {
> +		netdev_put(s->dev, &s->dev_tracker);
> +		list_del(&s->list);
> +		ax25_dev_put(s);
>  	}
> -	ax25_dev_list =3D NULL;
=E2=80=A6

Can the increased application of the Linux list API be offered as
a separate update step?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do=
cumentation/process/submitting-patches.rst?h=3Dv6.9-rc7#n81

Regards,
Markus