Received-SPF: pass (google.com: domain of linux-kernel+bounces-170124-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <da7a6e8c-fdda-42d3-ad42-c34e585d0ef8@gmail.com>
Date: Mon, 6 May 2024 21:39:43 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 linux-next] usb:typec:mux: remove indentation for
 common path
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: gregkh@linuxfoundation.org, neil.armstrong@linaro.org,
 dmitry.baryshkov@linaro.org, u.kleine-koenig@pengutronix.de,
 christophe.jaillet@wanadoo.fr, linux-usb@vger.kernel.org,
 linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
 javier.carrasco.cruz@gmail.com
References: <20240426164705.2717-1-prosunofficial@gmail.com>
 <Zjib5xNdpeNVfgtV@kuha.fi.intel.com>
Content-Language: en-US
From: R Sundar <prosunofficial@gmail.com>
In-Reply-To: <Zjib5xNdpeNVfgtV@kuha.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Heikki,

On 06/05/24 14:29, Heikki Krogerus wrote:
> Hi Sundar,
> 
> On Fri, Apr 26, 2024 at 10:17:05PM +0530, R Sundar wrote:
>> Nitpick, Mostly common path will not be indented.  so rewritten this
>> function to check device_node pointer is null and removed common path
>> indentation.
>>
>> Signed-off-by: R Sundar <prosunofficial@gmail.com>
> 
> For the record, I'm still uncomfortable with the name - why not just
> spell out your whole name?
> 

I understand your concern.  " R Sundar ",  is my whole name.

>> ---
>>
>> Fixed nitpicks in code according to comments received on other patch as
>> below:
>>
> 
> Sorry for missing this earlier, but it looks like this patch only
> modifies the nb7vpq904m driver, so I think you should specify that
> already in the subject.
> While at it, you could also specify the only function that is being
> modified in the commit message (this is just a suggestion):
> 
>          usb: typec: nb7vpq904m: Remove uneeded indentation
> 
>          In function nb7vpq904m_parse_data_lanes_mapping(), the "if
>          (ep)" condition is basically the entire function. Making the
>          code a bit more readable by inverting the condition so that
>          the function returns immedately if there is no "ep".
> 
> thanks,
> 

Thanks for the suggestion provided,  will modify the commit message and 
send the updated one.


Thanks,
Sundar