Received-SPF: pass (google.com: domain of linux-kernel+bounces-170155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 6 May 2024 09:22:11 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Ira Weiny <ira.weiny@intel.com>, Jonathan Cameron
	<Jonathan.Cameron@huawei.com>
CC: Dave Jiang <dave.jiang@intel.com>, Fan Ni <fan.ni@samsung.com>, "Navneet
 Singh" <navneet.singh@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>,
	<linux-btrfs@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 06/26] cxl/port: Add Dynamic Capacity mode support to
 endpoint decoders
Message-ID: <663903b35b66e_2e2d22945a@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240324-dcd-type2-upstream-v1-0-b7b00d623625@intel.com>
 <20240324-dcd-type2-upstream-v1-6-b7b00d623625@intel.com>
 <20240404093201.00004f33@Huawei.com>
 <661065683552f_e9f9f2946@iweiny-mobl.notmuch>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <661065683552f_e9f9f2946@iweiny-mobl.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vM7arkHwqtqPbIxyVjIbqYo4O022Ux5PCLppDEXIeCzMJnDhthdJgfHVEI2j?=
 =?us-ascii?Q?oBVLNANSwlziOyXZ4Ff7rqoKvq/04TzTSn4nxwPRDVssmPqLxxQveI5iCeDS?=
 =?us-ascii?Q?3+SL6Uy0N3CmABN162hMrJq4nnBzkxX/S8BZq/RnZJr+stwbUGONneMbp9eb?=
 =?us-ascii?Q?otmi3z5om97lQBPREoYiDuw18J/OiBv7s72SHpZS32yeTiRyFYlQd25XRvsk?=
 =?us-ascii?Q?txNTzM9UfiDgFb3VJNRb78X7zfy86HJydJZv5ajCPqFgep+2/rLcikEVOIsj?=
 =?us-ascii?Q?hFXieg5b81khtuTalGRCUVdcmVX8f+Yw3RsalhEEkGNOr1/Eya10wmdbSHh1?=
 =?us-ascii?Q?3hBPL6yUcqP06sGcaOuiH8RYeRuDZcQuDdMmb4tC3F+PuDu4xYyjxdwnyBQ4?=
 =?us-ascii?Q?k/X1G4mhAIzwkEOP3MuGouVhd6hP7ixfdSWSLql04FU74yAL0X3soTorwjN5?=
 =?us-ascii?Q?w6/R7k90UhWoezOIISAGl+gBJCBS1rDWT14vzVmZH7XYPQix+7RyC19qWlNf?=
 =?us-ascii?Q?owtZ0HXhHx5EVqobuRBS/413Sm5I3I3KXTjSFrnVYhMaxjR6Nw/syRCD1pgh?=
 =?us-ascii?Q?qIhzMpBXpBVilZhgMlo+vs5aYJMaYRVaGZ8/mGt5JD7gGDNAkid7vJayrCWZ?=
 =?us-ascii?Q?2lHAnWPsOfljTYxK/ljeUV57apqkSFaS1/3kcoYohWPYOudNr5YRMuPM1hUb?=
 =?us-ascii?Q?fQkyhVpQO7XMTjyY6TT+KX58T5j0wG46hk8C4sDNw9jeBz+sp/IA0diKNyNS?=
 =?us-ascii?Q?it1DbmekPQ9RBZ/q+w7++x38XjqwPtRTFkJS8Lg6erCEhFp6WlUKLxOlJ6yo?=
 =?us-ascii?Q?VJA5NRtV/agDcrbhFl8/lCGkMHz4E9/+RanWXDivPb1kdtWiu19Lj25fLE92?=
 =?us-ascii?Q?CcMojWGXM7WV583OsVQo6ugHsj9CRS4z+/xBQPiaQz34CCgoyd7iiSgUGLub?=
 =?us-ascii?Q?18DgTjK82tw84Bf7uNz8iO7DRjaHFxvs0aTT/PbhU6MoQmkQquqiF3w7V47e?=
 =?us-ascii?Q?Fdjm921rJ1V3Yqe2/DQZ/Vz/vj7dtprAoGP2CXueGrDj4OA5o8aOR4XV3CET?=
 =?us-ascii?Q?fd5H4qAFXYNKJd/5Ani+i3UZYvZs9RKi6S4AEVjDRLh7D8vNYEwh07Dhcu3D?=
 =?us-ascii?Q?ILXUbK2jkhhMdN3eMYAq31ekpVovKr8auMhA78u8cBn8o06103ThenD+Q6TC?=
 =?us-ascii?Q?J4lIrqHtlA1bsY7WZRG1KLaiPeVdJ5eBVThrun+r0oyhcgCtSYIMKg7FQOJe?=
 =?us-ascii?Q?q66yc9h/NdBhUF/47UuU43EkWEe01UhjTChs8lOUM794IRFli73pGgDpNCpH?=
 =?us-ascii?Q?uDmFFo7MPbf0M2w/oKJIzw6LyFHInh2ozplPXaONAs1zJSqM3PCZq+27tzTd?=
 =?us-ascii?Q?K6bCS6ZkL0jKL/VQsvdCqUgTSDHipRVff0FWooAFitNDwg7KVZM1BaHOTdR6?=
 =?us-ascii?Q?eHcCml7fbGcCMkDygT3ZMN0A6rXqTVOzWG2O0DKy957y/1cWDNU8Yc11jZB1?=
 =?us-ascii?Q?7FIfYmiFAgWfEBUbys8Z67Lm+xEXXhwGVtWGaQlovL0ZCQ4vEgflThL0lohj?=
 =?us-ascii?Q?Jjz3+Dot1YFnHFo2OECymi/5fPhz6HCne6fw6POavr6jPjrw7qbzDBd/KW2C?=
 =?us-ascii?Q?1Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8b47720-c842-4f13-3dca-08dc6de8b08f
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 16:22:14.4443
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F8/OaRi9PMbRFxb/r+4hLP1GUl8v/QuynQZKEHE5BF3++g947D1aCr5xb1BI0PhR7zTMXqqqIg68H4fed+H+O31qrxONBCcJPmGDth7zNuk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6324
X-OriginatorOrg: intel.com

Ira Weiny wrote:
[..]
> > > +	case CXL_DECODER_DC0 ... CXL_DECODER_DC7:
> > > +		rc = dc_mode_to_region_index(mode);
> > > +		if (rc < 0)
> > > +			return rc;
> > 
> > Can't fail, so you could not bother checking..  Seems very unlikely
> > that function will gain other error cases in the future.
> 
> Sure, done.

Can dc_mode_to_region_index() be dropped altogether? Is there any
scenario where dc_mode_to_region_index() is really handling an anonymous
@mode argument? I.e. just replace all dc_mode_to_region_index() with
"mode - CXL_DECODER_DC0"?