Received-SPF: pass (google.com: domain of linux-kernel+bounces-170176-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <0e0cf5fc8c78fac42f4c657421d16456a7adca7f.camel@perches.com>
Subject: Re: [PATCH RESEND v6 2/2] scripts: checkpatch: check unused
 parameters for function-like macro
From: Joe Perches <joe@perches.com>
To: Barry Song <21cnbao@gmail.com>
Cc: akpm@linux-foundation.org, apw@canonical.com, broonie@kernel.org, 
 charlemagnelasse@gmail.com, chenhuacai@loongson.cn, chris@zankel.net, 
 corbet@lwn.net, dwaipayanray1@gmail.com, herbert@gondor.apana.org.au, 
 jcmvbkbc@gmail.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org,  linux@roeck-us.net, lukas.bulwahn@gmail.com,
 mac.xxn@outlook.com,  quic_jjohnson@quicinc.com, sfr@canb.auug.org.au,
 v-songbaohua@oppo.com,  workflows@vger.kernel.org
Date: Mon, 06 May 2024 09:11:35 -0700
In-Reply-To: <20240506071657.13434-1-21cnbao@gmail.com>
References: <5e26f82913801050afa4442dfb9a07249895ab98.camel@perches.com>
	 <20240506071657.13434-1-21cnbao@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-05-06 at 19:16 +1200, Barry Song wrote:
> > > From: Xining Xu <mac.xxn@outlook.com>
> > >=20
> > > If function-like macros do not utilize a parameter, it might result i=
n a
> > > build warning.  In our coding style guidelines, we advocate for utili=
zing
> > > static inline functions to replace such macros.  This patch verifies
> > > compliance with the new rule.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > []
> > > @@ -6040,6 +6040,12 @@ sub process {
> > > =A0					CHK("MACRO_ARG_PRECEDENCE",
> > > =A0					    "Macro argument '$arg' may be better as '($arg)' to avoid=
 precedence issues\n" . "$herectx");
> > > =A0				}
> > > +
> > > +# check if this is an unused argument
> > > +				if ($define_stmt !~ /\b$arg\b/) {
> > > +					WARN("MACRO_ARG_UNUSED",
> > > +						"Argument '$arg' is not used in function-like macro\n" . "$her=
ectx");
> >=20
> > trivia:  This should be aligned to the open parenthesis.
> >=20
>=20
> Hi Joe,
> I assume you mean the below?
>=20
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9895d7e38a9f..2b812210b412 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -6044,7 +6044,7 @@ sub process {
> =A0# check if this is an unused argument
> =A0				if ($define_stmt !~ /\b$arg\b/) {
> =A0					WARN("MACRO_ARG_UNUSED",
> -						"Argument '$arg' is not used in function-like macro\n" . "$herectx=
");
> +					     "Argument '$arg' is not used in function-like macro\n" . "$her=
ectx");
> =A0				}
> =A0			}
> > Otherwise:
> > Acked-by: Joe Perches <joe@perches.com>

Yes, but please send a v7 instead of a separate patch
to akpm or perhaps Andrew could combine them or fix it
when applying v6