Received-SPF: pass (google.com: domain of linux-kernel+bounces-170186-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
Message-ID: <trinity-0d9eb74a-bce9-48cb-b119-e75a41404ed5-1715013613002@3c-app-gmx-bap23>
From: Frank Wunderlich <frank-w@public-files.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Frank Wunderlich <linux@fw-web.de>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen
 Boyd <sboyd@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones
 <lee@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Matthias Brugger <matthias.bgg@gmail.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Eric
 Woudstra <ericwouds@gmail.com>, Tianling Shen <cnsztl@immortalwrt.org>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-clk@vger.kernel.org, linux-leds@vger.kernel.org,
 netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-mediatek@lists.infradead.org, Tianling Shen <cnsztl@gmail.com>
Subject: Aw: Re: [RFC v1 5/5] arm64: dts: mediatek: Add mt7986 based
 Bananapi R3 Mini
Content-Type: text/plain; charset=UTF-8
Date: Mon, 6 May 2024 18:40:13 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <174a8bfe-7a9e-4816-9bde-de48f04b07f6@linaro.org>
References: <20240505164549.65644-1-linux@fw-web.de>
 <20240505164549.65644-6-linux@fw-web.de>
 <174a8bfe-7a9e-4816-9bde-de48f04b07f6@linaro.org>
UI-OutboundReport: notjunk:1;M01:P0:NAsoPtlBBgM=;BO2DCb+S9ohdLnwa8Hpcq1GUEPe
 ilz3XZSkDGWrCrCKCACKqkcaiUa3wfr8CjuUbPiYkzg97H6S4+RqA8LaV2FcKRZ3uds0NXycD
 D9EnmfoBshiYg8IK1Q5RFLrBgSIZA6WSsVjxYvJ6VGYgMyL7RRTWG/Ewjbn4PayddcyzPNSWi
 Mp/XSio46j41O9XFKrWnLoRlH2rpubf/IwWyVxktBG6cVo5c2i+Vkfi5ZmoxqF9+ofnUulvps
 bTfOfofFnd5C/BG12if5dmY0t9s2oeXXLrVa+y5Z3p9uI7dlsEiDdQUJ0I8dRjrUDi0VvqnX5
 VNaplCpHWOUSndjDdf/QeGXpy33ZrxpCFttFsoLR82hwhA96N13p3PYm1VX2clM+8tXNVqFE0
 M/+I6QlD2ryJDVK5jJW/0CP7TcaRZoPEeF25ogGpKe2QDBBhAQ5lz3K05MiirheaJ3fHeDMYZ
 7yMvt14o54Ba+QMSyyEhYt+bFEwWcMfGQYBRjpyGMdhJftxyN2wDl5b2saxrRPyG25RGYJFWm
 Ht02j5lFtl1vnaKMw3ZwPhxlctR8D8ozfzOy7+eNlJUGIiwvfH5f71qXh06eFUizFtOH7iupA
 S4wk1ufIzGfDUUeNnwe0Oc88WqigKDg1NWm/qZfQElsHx9DcnpRQ646moiYPapqjEch033K7r
 1Bn6ZkKsiHXPRHA26QIGBBqFUf2YeD/iHIN4lrmoZakXmhLGIFeEi4VSr3EweFY=
Content-Transfer-Encoding: quoted-printable

Hi

Thanks for review


> Gesendet: Montag, 06. Mai 2024 um 10:20 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> An: "Frank Wunderlich" <linux@fw-web.de>, "Rob Herring" <robh@kernel.org=
>, "Krzysztof Kozlowski"
> > +	dcin: regulator-12vd {
>
> Please use name for all fixed regulators which matches current format
> recommendation: 'regulator-[0-9]+v[0-9]+'
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/co=
mmit/?id=3Db6d4b3500d57370f5b3abf0701c9166b384db976
>
> > +		compatible =3D "regulator-fixed";
> > +		regulator-name =3D "12vd";
> > +		regulator-min-microvolt =3D <12000000>;
> > +		regulator-max-microvolt =3D <12000000>;
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +	};
> > +
> > +	fan: pwm-fan {
> > +		compatible =3D "pwm-fan";
> > +		#cooling-cells =3D <2>;
> > +		/* cooling level (0, 1, 2) - pwm inverted */
> > +		cooling-levels =3D <255 96 0>;
> > +		pwms =3D <&pwm 0 10000>;
> > +		status =3D "okay";
>
> Why? Where is it disabled?

you're right, i'll drop it

> > +	};
> > +
> > +	reg_1p8v: regulator-1p8v {
>
> Please use name for all fixed regulators which matches current format
> recommendation: 'regulator-[0-9]+v[0-9]+'
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/co=
mmit/?id=3Db6d4b3500d57370f5b3abf0701c9166b384db976
>
> In other places as well.

ok i change it like this (label doesn't matter, right?):

dcin: regulator-12v {
reg_1p8v: regulator-1v8 {
reg_3p3v: regulator-3v3 {
usb_vbus: regulator-5v {


> Best regards,
> Krzysztof

regards Frank