Received-SPF: pass (google.com: domain of linux-kernel+bounces-170192-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
Message-ID: <trinity-9ceb52ff-9a3b-4fe2-93f8-2e95b8ffb1ee-1715014303393@3c-app-gmx-bap23>
From: Frank Wunderlich <frank-w@public-files.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Frank Wunderlich <linux@fw-web.de>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Michael Turquette <mturquette@baylibre.com>, Stephen
 Boyd <sboyd@kernel.org>, Pavel Machek <pavel@ucw.cz>, Lee Jones
 <lee@kernel.org>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
 <pabeni@redhat.com>, Matthias Brugger <matthias.bgg@gmail.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Eric
 Woudstra <ericwouds@gmail.com>, Tianling Shen <cnsztl@immortalwrt.org>,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-clk@vger.kernel.org, linux-leds@vger.kernel.org,
 netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 linux-mediatek@lists.infradead.org, Frank Wunderlich
 <frank-w@public-files.de>
Subject: Aw: Re: [RFC v1 2/5] dt-bindings: clock: mediatek: add
 address-cells and size-cells to ethsys
Content-Type: text/plain; charset=UTF-8
Date: Mon, 6 May 2024 18:51:43 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <9f8237c4-f603-459a-9d34-9cda556874b8@linaro.org>
References: <20240505164549.65644-1-linux@fw-web.de>
 <20240505164549.65644-3-linux@fw-web.de>
 <9f8237c4-f603-459a-9d34-9cda556874b8@linaro.org>
UI-OutboundReport: notjunk:1;M01:P0:HqZgEzNzP30=;1Z/bVNz2Hg6od3fp1iQE8Dn5VyS
 EMECAIq92weuhOb8c8mleVtH7XDWJU47XhJV7CSFmtutIbyEKDwdL41WD5GYXOOqwUMf2XXAU
 0NOPFdiGzFDxcetA4IyMDIHE9gd/oUT5MflrTXniYf4hqofn1Z1xeV4UhApgq8JWMiy82IVAo
 VcMsngEWSVtjR5FBOm9mqK10zHiV7Z3/gdZBbYijlzN5+/WdYHL1QJYefIbnctzGs/H82hweC
 sSAg+e4G38eCfn5sDMBk48oas9UkM/eoZUpP7+3dhWOdyvvOcZ6KzQ6cuaq1xWUhqzO1svqbQ
 9H0n5FCYY+UEtvAx1dJOHQui14G0w69SG6tyKkuH9RVlEbFMBUXhN9ejUXKMBEwwIzqH9nUv9
 JJON+I5GCmgbsa3KaRcxsjxmdobOhDBoJicv/FrWTBqOFYRgvmnwqh+CLio2Wvd2joe9ZfBlm
 Pm7exN4QymBMZUZRMmUaE5DrF+H702+7i/mhCAlKxh89TbOpvgMhZHmzGk1MxsSxcQnEU19/7
 iohn9RievoaAAR3BsEtdfWPZkKuFDC9yLx7vpNiHFm+ISVfJFrDysgJFKhlN6ddvI5Y7n12d7
 SB6A1MnomcyH1qpn3uYNPaLtnr5z4b0KR4sJFFWF3YTUn1/ig0HmBFr/2jC9Bjcd/ytLJ1G3U
 vMZJGgxPW3Mxk3q/x4a3fSUL22PvZ7DqxSALrDogsl+WOny5eNVViwT0POtGKQ8=
Content-Transfer-Encoding: quoted-printable

> Gesendet: Montag, 06. Mai 2024 um 10:18 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> On 05/05/2024 18:45, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files.de>
> >
> > Add missing properties already used in mt7986a.dtsi.
>
> Missing for what? Or why? Provide context, IOW, explain why they are
> missing.

ethernet-node in mt7986a.dtsi hast reset-cells-property

https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/media=
tek/mt7986a.dtsi#L559

and

address-cells and size-cells are used here:

https://elixir.bootlin.com/linux/v6.9-rc1/source/arch/arm64/boot/dts/media=
tek/mt7986a.dtsi#L495

i saw the warnings while checking my r3mini dts...

arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: syscon@1500=
0000: '#address-cells', '#size-cells' do not match any of the regexes: 'pi=
nctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/clock/mediatek,ethsys.yaml=
#
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3-mini.dtb: ethernet@15=
100000: Unevaluated properties are not allowed ('#reset-cells' was unexpec=
ted)
	from schema $id: http://devicetree.org/schemas/net/mediatek,net.yaml#

so i thought it is a good idea to fix this now ;)

but basicly not related to my dts as these are inherited, so i can drop bi=
nding-changes...

regards Frank

> Best regards,
> Krzysztof