Received-SPF: pass (google.com: domain of linux-kernel+bounces-170229-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <9cb43d83-466d-471c-a101-b2394b281f0c@nvidia.com>
Date: Mon, 6 May 2024 10:25:34 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] selftests/alsa: missing a return value in unused
 dump_config_tree()
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>, Shuah Khan <shuah@kernel.org>,
 Takashi Iwai <tiwai@suse.com>, Ivan Orlov <ivan.orlov0322@gmail.com>,
 linux-sound@vger.kernel.org, Valentin Obst <kernel@valentinobst.de>,
 linux-kselftest@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
 llvm@lists.linux.dev
References: <20240505210824.55392-1-jhubbard@nvidia.com>
 <875xvrif0c.wl-tiwai@suse.de> <a80cb2a2-735d-4539-a758-a536296975cd@perex.cz>
 <87zft3gz8u.wl-tiwai@suse.de> <ZjjsybLA3VyY0r_N@finisterre.sirena.org.uk>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <ZjjsybLA3VyY0r_N@finisterre.sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZzVocFRXZkNmY3VSL3JSZno3SUhOMG1DNEhVbVk5cEVibExUQXR0WUJHU2lW?=
 =?utf-8?B?SWZ5YWJuYzFwWFQvbUc0OG9IY0R3VEtyVWY2elpETlFQaEtZc0ltQTV3eDJi?=
 =?utf-8?B?UlVIZlFVcUNmTm0xdDBjUXgwV0tveE5IbnZHMjdOQk9KdzNCa0k0NkJLU1d1?=
 =?utf-8?B?WGVuaUZFWXg3dlN1SDJIMkphaGRSL002V0VObGQrNzJybUM2Sk96bVB2Vlk4?=
 =?utf-8?B?M0RraFlESFo4S2xBTlV5TkVKQk1zZ093Mng4NzBDeGJITjlhV1ZVdGRPbGVY?=
 =?utf-8?B?VytwcHNVaUVNeWwxbklrS3FkQkpJc2YrZG1KMG51cEhGTUlKNmtlaWJlOHc3?=
 =?utf-8?B?QXJOc1M1enEwY3FWbkxZREhTV0NNaFhPWUc5c3lUT3FSN3dvMndvc09WUXB2?=
 =?utf-8?B?ZGdXZkhqNStydXhFMGIrYkhMU1oxNG5zM3lLSWdTbDBTZnpoVnU2dFdpNm9M?=
 =?utf-8?B?dGtJZEs5RlRvc3huQUpJT0ZBTVBvSnc5cGVabVRIU0doaWZZSDdOa3FWMlU2?=
 =?utf-8?B?TURYTjFYTGxwNHQxN2d2VmptcFE4Wit1b1lib3pNM2xvVkh5NVFkMWk2RWJ5?=
 =?utf-8?B?UzZtNXJmSHRSdmNXODZSS0p4M29saThOLzl0SG52TWlsN3pid1hwRlQ1Mks0?=
 =?utf-8?B?Nkw5c0NzOCttT1BlL3I0cGpKWExYRDRBcFVEY3BRMTlSQmpvVkNwU0krK2sr?=
 =?utf-8?B?Nis4Yjk4L3pLcGdTdTBqWmxxdVcyaDE4cERpNFdqQXl3akVmNEU3c0RXNmZo?=
 =?utf-8?B?TkJ6TC9GT3F6L1c4NHZVQWdUN2RWZmErWkVxQ0tWWldDQ3pyTElNT01vMjJ5?=
 =?utf-8?B?S1dONUpIVnJLcDNiK1J4a21Hd0w5R0hiRFBvdFJDMExYVmFLNlhtUWRYOC9R?=
 =?utf-8?B?Si9IQWQ4QnRabTR3SnpkWEtZdDkyUE01VFRPUVF5UzZMc1NxejlIaVJubVg0?=
 =?utf-8?B?V094THN3dmwxS1ZncGFuNVFMZUJSWXh1V0RFU1EyeU1sUHVTK1VmalZxM01V?=
 =?utf-8?B?aEdzaGJwTTZudUh5UFdlTHRTdGcwblVxOFg5OEpYWDNYU2RjZlZ4d1paUUR5?=
 =?utf-8?B?YmFLKzZWNEsxeVI4YWdrOFdQdVc0R1Jyb0c5NWJxZ2xvZzB6REVtUjVFTTlR?=
 =?utf-8?B?MFVaeGxUZnBTZFB6d3RlaUprVW80Z2w2Q2RHcFJxNjZsWFh1V3QzSmZ6L1pV?=
 =?utf-8?B?ZWJuQTJQeWIxaUJBU3hBUVJXbEtWeDM4QkRLek9UdXdvT3FUMHYzWHh3TGND?=
 =?utf-8?B?R1BkS0hXZWhwOG5oRC9yT1NrQjFFOThOU2MwbUlUSE1FQnVuUDk5NllTaXBt?=
 =?utf-8?B?K2RMcEpuNmNmaU9IcDNXdEV2YmdsWFBZQ1pyclZIRnpwMWE3T3pmbGFObnpK?=
 =?utf-8?B?L0I0c25WNExqZkZJVlpRZ0s5TENHRlhqU0czckZ1MXBoZWhVVDI2blJxQnhU?=
 =?utf-8?B?Z25YbE5DV29DK3lwR1lmZjhDcnZySDZiT29lSWVCcjNpWitDYVlWYzdUTnNm?=
 =?utf-8?B?QWpqTDJpa2ZEZmFRS0ZidENhQUtkVmdLdWFCTFE4dnZZcStXZzRCTjJacTFu?=
 =?utf-8?B?cjhKa2RHYmR5MUljV0QrWTIzV3J4T2VQU0lCQlVScGQ5OU0wdG0vZGo2SS9R?=
 =?utf-8?B?dnBPVEYzdnBRWndvV3IxbW0xSkN4eWcvaDlhSXExOFR2bDFiQ2ZYMW9Jckcw?=
 =?utf-8?B?UFJrd0gxQ1lucnNvY2pqc1ZscWpvSVdWVTdlOXhNNS9PcElNR3VNczUxL0RM?=
 =?utf-8?B?bE5LMm1DelE4eVZHdGI2dFNNSTVrenUrclp1UXptV1NLcXdGbDNRVzFQR1F4?=
 =?utf-8?B?T0h4RXk3U1FuQWpTbHBnOTlqbmFqQ1RINnpXV213aU9KVmFxTUJQeG0zQnNa?=
 =?utf-8?B?SEpmMnZvMlhacUZ3VEZYMmgrV3ZJWnVVT1JMYzlZS2NNTmNMWHJ5R01mUGlL?=
 =?utf-8?B?NDVrK1RXWWJQZTNpTjFndkZ1YU5lbkYzZFJmQ3VDZGUvRU5QUmRIQ0JsWmc1?=
 =?utf-8?B?b1lUcmM4dEJvaGFkVUZSK2wyMk5JYUNNWmh2TkluN3ppamNEcEEwbnVFdElv?=
 =?utf-8?B?bU1FOCtiYkIzRm8waHlrM0RDcndEY3k4eHIrWUorOXVIbkxERHo3emt5eWxw?=
 =?utf-8?B?Y2NpWG5hWWVIT3dyWnpSQmRXU3ZOM2o5MTN6M1FJSTFyMUFVdzYzNWFFU1Nx?=
 =?utf-8?Q?1TvXMxPdJ3ZQ1H2cYUvNFq4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eeb50558-e775-48a3-b3c4-08dc6df18f82
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 17:25:44.3071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pqf6mJ3ab01C1+e91wh3cTwzdNhlSnfv9g/DJI6GGTpGDW4eGqP/MJLUZ8b4ktGmMPbFI+tmuYDcFp6CCKTyQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8111

On 5/6/24 7:44 AM, Mark Brown wrote:
> On Mon, May 06, 2024 at 09:45:21AM +0200, Takashi Iwai wrote:
>> Jaroslav Kysela wrote:
> 
>>> This function is nice for debugging. I'd prefer to keep it with the fix.
> 
>> I'm find in either way; just submit a fix patch, then.
> 
> The fix was already submitted as v1, I noticed that the function was
> unused in review.

It's generally considered a best practice to delete unused code. If
there is something you especially like for upcoming code, you still
have git history, and even a lore.kernel.org link, to bookmark it.

So I'd recommend going with v2, but of course it's your call! :)


thanks,
-- 
John Hubbard
NVIDIA