Received-SPF: pass (google.com: domain of linux-kernel+bounces-170237-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 6 May 2024 19:38:09 +0200
From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>, 
	Guenter Roeck <groeck@chromium.org>, Tzung-Bi Shih <tzungbi@kernel.org>, 
	chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, Dustin Howett <dustin@howett.net>
Subject: Re: [PATCH] platform/chrome: cros_kbd_led_backlight: enable probing
 through EC_FEATURE_PWM_KEYB
Message-ID: <ae29f036-5e39-47ee-98d3-c023a263a3ef@t-8ch.de>
References: <20240505-cros_ec-kbd-led-framework-v1-1-bfcca69013d2@weissschuh.net>
 <cd9c5b6a-0155-434a-b868-a9ea52e878c9@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cd9c5b6a-0155-434a-b868-a9ea52e878c9@amd.com>

On 2024-05-05 08:42:21+0000, Mario Limonciello wrote:
> On 5/5/2024 04:41, Thomas Weißschuh wrote:
> > The ChromeOS EC used in Framework laptops supports the standard cros
> > keyboard backlight protocol.
> > However the firmware on these laptops don't implement the ACPI ID
> > GOOG0002 that is recognized by cros_kbd_led_backlight and they also
> > don't use device tree.
> 
> Something I'd wonder is if the GOOG0002 ACPI ID can go away entirely with
> this type of change.  Presumably the Chromebooks with ChromeOS EC /also/
> advertise EC_FEATURE_PWM_KEYB.

Sounds good to me in general. It would make the code cleaner.

But I have no idea how CrOS kernels are set up in general.
If they are not using CONFIG_MFD_CROS_EC_DEV for some reason that
wouldn't work.

If the CrOS folks agree with that aproach I'll be happy to implement it.

> <snip>

Thomas