Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp46743lqh; Mon, 6 May 2024 10:46:06 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWNZWqF0Ldlrcf0yq3QmwbGX7Ih8gjMqVvemYO6Kk021ofraGcLJHwS3LdNUovgaaLf7DdtnEwhZ3HEit+5X+rRGoteK9GMcjz+tW7Z9Q== X-Google-Smtp-Source: AGHT+IFoidd7Wxa0Pguj4rp2PCGo0xaZYIOZEd4H28Ze679jbD8iKdVwhQ/OL7ppZU9jyJ5F4nt2 X-Received: by 2002:a17:902:dac4:b0:1e3:e243:1995 with SMTP id q4-20020a170902dac400b001e3e2431995mr13922205plx.1.1715017566181; Mon, 06 May 2024 10:46:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715017566; cv=pass; d=google.com; s=arc-20160816; b=d+7GFo9OILLm1s8uLu+NlzVr4Sfg6t5jGwcEwlN4520nSr+34bM0krUarbiI/dtZpW Gc35qrKtWDWYfPJBzTB6FkXLEGxgVWwFM0AzGuhekcXE1+831hmsc4b8e1FmnUAsIZUL zHP+4uoqCSSVmy6dUaxPLcshqh1OlHxAXpV8NEpaW7xOxJM6CLUy+Q7PIx29C4otO7Uo 5Qu8eQoXPOCuom2YsFdqqBH9lQyZ/mymgMVRA8NSYrM2LW1VQeY3t7mS1ccafjRoIoHN uuILZBtp4XyVebXWvmtOs4Rwr/MhJVVa+H1DzZBe6vgZDIy4IfoHEfhnt6WkuH8BrwAs GXDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :reply-to:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature:dkim-signature:dkim-signature; bh=poHDJP5x9pFXKSGFxv6b+OoTvegRQpkqsTgZ4FwrCws=; fh=ukuM4K8x/2FcMbEU6mFAG1Kdxyd3ptNZTsUqWHGwKcs=; b=zT7X9RO2LzE7cXI4o1GobqjrpBCOYZaigo+MSLtaODBucWN0h9S+Ar4CNIRRC/tcad Mji8f6kgUP54zLyc5g1ya/pAiTOmfWZdr74PUdO/bdRqKXDNDrmchR/hc+1xuMMdKn13 +VIKqKQ+pTfW9io8rS0bgQqY798+cAF4BrGVhDAZ9+ox2sgZFT6f/9CU4Ra4xcaLnmhx Owg3tJTP5imAPnM1KY4TmIFebDehF+iy8JfPoKiqArkv75QAEokVrWAn1XER9qtHhdR6 g/qZtOi04mXhkZoqyHmIfe98S7GCND1zGiLm65KZVxI7ndJZAvR/5NK5v+jIwE/E8S9D 8Rqg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=hM9Ug9rK; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=hM9Ug9rK; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-170244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170244-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id m14-20020a170902db0e00b001eb22fab1b0si6726063plx.618.2024.05.06.10.46.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 10:46:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=hM9Ug9rK; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=hM9Ug9rK; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.cz dkim=pass dkdomain=suse.cz dkim=pass dkdomain=suse.cz); spf=pass (google.com: domain of linux-kernel+bounces-170244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170244-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C82A2B21EEC for ; Mon, 6 May 2024 17:45:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CCF83157A45; Mon, 6 May 2024 17:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="hM9Ug9rK"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="HMILEJsY"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="hM9Ug9rK"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="HMILEJsY" Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A0F815749A; Mon, 6 May 2024 17:45:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715017545; cv=none; b=hoWrSsAq/UkYx6A6p/pZ/OXJvX5xUWVBCDHE6HPHQ68B4JzyQC3QMbs8CjrX+5tlCfDx5XYh8kLYu9NwKuEr4D7R3fovtuEFE27ttJwKk1D4q8J0A8izRtB4UkCA6DHuMS5hyzXPohBZlO4pAfDLh+SfBnetTLbePwX30I9/Gdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715017545; c=relaxed/simple; bh=SnuVaKANezsK89xhLaJCVZPrBbMHyA1Px7Ry2U4l1t8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dt1mfcM944rRPyoW74bBq1aZVc3slSlBxY1wrCQ7x8wEgIXFUk6+azrBZkcTx94RKFxGwgJmK0zyNgpVJTB/U8sN+CbROrwLmMYgs90J4bmf94Ac/PN/RUMivKfJLMe2nIxZDP7NB3ytM/hVlg0x8iu5zq8XTfwMGde933/Be/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=hM9Ug9rK; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=HMILEJsY; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=hM9Ug9rK; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=HMILEJsY; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 874172197F; Mon, 6 May 2024 17:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1715017542; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=poHDJP5x9pFXKSGFxv6b+OoTvegRQpkqsTgZ4FwrCws=; b=hM9Ug9rKRsgNpYl++rSDDkd+Grp9WSTCevgoNZGR7+6H0MADW5ZcEylme6CgFuuFoGqmzr 7ucZTjP4BTs0WIbMSFxm12cigm16aD8wCLSBgjor90gG9qxJrhTng28rUhJdB/GuUL7JnQ 9Xec4kZ49hiDqnaYYhqYERd3taq96es= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1715017542; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=poHDJP5x9pFXKSGFxv6b+OoTvegRQpkqsTgZ4FwrCws=; b=HMILEJsY4oEupbOF+SEgaWaJF+Qazyypsvqo1cgrKzHAarNlrSDGrZetTb8zL/GloYCmuL Uo94IpaLa3HZsGBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=hM9Ug9rK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HMILEJsY DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1715017542; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=poHDJP5x9pFXKSGFxv6b+OoTvegRQpkqsTgZ4FwrCws=; b=hM9Ug9rKRsgNpYl++rSDDkd+Grp9WSTCevgoNZGR7+6H0MADW5ZcEylme6CgFuuFoGqmzr 7ucZTjP4BTs0WIbMSFxm12cigm16aD8wCLSBgjor90gG9qxJrhTng28rUhJdB/GuUL7JnQ 9Xec4kZ49hiDqnaYYhqYERd3taq96es= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1715017542; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=poHDJP5x9pFXKSGFxv6b+OoTvegRQpkqsTgZ4FwrCws=; b=HMILEJsY4oEupbOF+SEgaWaJF+Qazyypsvqo1cgrKzHAarNlrSDGrZetTb8zL/GloYCmuL Uo94IpaLa3HZsGBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5B17313A25; Mon, 6 May 2024 17:45:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nL2sFUYXOWZsNAAAD6G6ig (envelope-from ); Mon, 06 May 2024 17:45:42 +0000 Date: Mon, 6 May 2024 19:38:24 +0200 From: David Sterba To: Dan Carpenter Cc: Boris Burkov , Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] btrfs: fix array index in qgroup_auto_inherit() Message-ID: <20240506173824.GG13977@twin.jikos.cz> Reply-To: dsterba@suse.cz References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Flag: NO X-Spam-Score: -3.95 X-Rspamd-Action: no action X-Rspamd-Queue-Id: 874172197F X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.95 / 50.00]; BAYES_HAM(-2.74)[98.88%]; NEURAL_HAM_LONG(-1.00)[-1.000]; HAS_REPLYTO(0.30)[dsterba@suse.cz]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.cz:+]; RCVD_COUNT_TWO(0.00)[2]; REPLYTO_ADDR_EQ_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[8]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] On Sat, May 04, 2024 at 02:38:41PM +0300, Dan Carpenter wrote: > The "i++" was accidentally left out so it just sets qgids[0] over and > over. > > Fixes: 5343cd9364ea ("btrfs: qgroup: simple quota auto hierarchy for nested subvolumes") > Signed-off-by: Dan Carpenter > --- > >From static analysis. Untested. A real bug, thanks. Patch added to for-next.