Received-SPF: pass (google.com: domain of linux-kernel+bounces-169960-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 6 May 2024 17:17:58 +0300 (EEST)
To: "Dr. David Alan Gilbert" <linux@treblig.org>
cc: bhelgaas@google.com, dave.hansen@linux.intel.com, x86@kernel.org, 
    linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'
In-Reply-To: <20240506004647.770666-1-linux@treblig.org>
Message-ID: <948a3829-96da-2708-60f8-f25546683436@linux.intel.com>
References: <20240506004647.770666-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Mon, 6 May 2024, linux@treblig.org wrote:

> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> This doesn't look like it was ever used.

Don't start with "This" but spell what you're talking about out so it 
can be read and understood without shortlog in Subject (or looking into 
the code change).

> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  arch/x86/pci/ce4100.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
> index 87313701f069e..f5dbd25651e0f 100644
> --- a/arch/x86/pci/ce4100.c
> +++ b/arch/x86/pci/ce4100.c
> @@ -35,12 +35,6 @@ struct sim_dev_reg {
>  	struct sim_reg sim_reg;
>  };
>  
> -struct sim_reg_op {
> -	void (*init)(struct sim_dev_reg *reg);
> -	void (*read)(struct sim_dev_reg *reg, u32 value);
> -	void (*write)(struct sim_dev_reg *reg, u32 value);
> -};
> -
>  #define MB (1024 * 1024)
>  #define KB (1024)
>  #define SIZE_TO_MASK(size) (~(size - 1))
> 

-- 
 i.