Received-SPF: pass (google.com: domain of linux-kernel+bounces-170289-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: "Bird, Tim" <Tim.Bird@sony.com>
To: Wen Yang <wen.yang@linux.dev>, Shuah Khan <skhan@linuxfoundation.org>,
        Christian Brauner <brauner@kernel.org>,
        Andrew Morton
	<akpm@linux-foundation.org>
CC: SShuah Khan <shuah@kernel.org>, Andrei Vagin <avagin@google.com>,
        Mathieu
 Desnoyers <mathieu.desnoyers@efficios.com>,
        Steven Rostedt
	<rostedt@goodmis.org>, Dave Young <dyoung@redhat.com>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] selftests: introduce additional eventfd test coverage
Thread-Topic: [PATCH] selftests: introduce additional eventfd test coverage
Thread-Index: AQHanvs9FAxJ40hn5k6c626r1bhaQLGKiF0Q
Date: Mon, 6 May 2024 18:30:02 +0000
Message-ID: 
 <SA3PR13MB6372229283A34550FD52F913FD1C2@SA3PR13MB6372.namprd13.prod.outlook.com>
References: <20240505144648.18347-1-wen.yang@linux.dev>
In-Reply-To: <20240505144648.18347-1-wen.yang@linux.dev>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?igNFPOHZcDaFnrsf6Eqqu7gk59fb7JAqpXqrUhefdAOknD1c+vV09RkC9jdu?=
 =?us-ascii?Q?W+sT6ryjUv+Tgdwasrqf3LvmsXb8VpBHWKgF7rbSkIISoZ2hxFLn72sgomd0?=
 =?us-ascii?Q?bIszHX541ka0OV/3e7C1g+rZ906d4flcqVpFfn8PhcIItZcWKdKpQJBYn8EL?=
 =?us-ascii?Q?GIFfwUC8bC4HvFkTTXXH973JV895bfNjl/+tKnDl0SGkDCn7qwY+2f4vb9+s?=
 =?us-ascii?Q?xpWbi9vltpF75m7o2L7wN74QsFYUO9wB4rSGSdX61ItNXhYJjlnrPuDRYkyL?=
 =?us-ascii?Q?B+cKPANhRb/M7pXwH4xkQuC4YwY+60ieoTEAlR358JL4ZNxHwQFFMbcS5943?=
 =?us-ascii?Q?bbX0IUgYAFVmnfVzWt0mVAnKchz9PxnDN0I+hDtruV6YehKNv090pWdAXr8u?=
 =?us-ascii?Q?FjBIvT9jvdiiEZL31sjpc3l6pxYWhSy1IvsE6dEvAw0XXV5RCVeS296mf0vn?=
 =?us-ascii?Q?mVxkH0vQfROFsPLElW+I6CRQbhmpp9UNKXjalxAdTNbX+janDsuONaKef/Op?=
 =?us-ascii?Q?szCnb9brAPTgaTsO9oqrLgGfMRiurhXbTaJCvIGw4qaVZ6cNo/wcGb7zl56k?=
 =?us-ascii?Q?Ky6YwVwZ3Tlkkp6XyUwaqRw3XQX8EHXFSg9M8jWT1K38YBdYtIndf5TPgZ85?=
 =?us-ascii?Q?PdomJ+tXr9P7d0AHPVi6D9mauayWoliQu0XPRBKNfRrSI7fBtBTwXVa65PVW?=
 =?us-ascii?Q?0Zj8YuE4mgv9sPAO7G99SDOAEN8izqLEpctYgrm5b86rl6Pn0fppccsB0rQL?=
 =?us-ascii?Q?MYDChfCprAOZNIn840ygNl5/efn5DWByQTZgLdEh7Rb7pzXZw7s730Uo0/5O?=
 =?us-ascii?Q?LkzSsnCT1w1F21L5tdTqPdOOTZCKgVklXSHd7L5znTQEhMeHFTRWUMd9Xp5Y?=
 =?us-ascii?Q?mhuT7mRngzRDbhlE+YaOgClphtJEyZGLX/duX1paGLR5bTUU8+Wb0Agycpc6?=
 =?us-ascii?Q?26S9MNI+qmHinIYD14R08WVMzh4eO6fFKN6kAfQqhIAYsxAlclSH3dpPLqDc?=
 =?us-ascii?Q?9Ye+A+tMOE0dDvK2quUDPoeEuwpGM7URMzZ7hqnpqUVKwyS6Tp7KJ2dDTxvf?=
 =?us-ascii?Q?nBOHkl8pY+sMbBcp/zhRAqMbhwpjatns0dHiN0clst0mxMw0AMGTZIWivNNW?=
 =?us-ascii?Q?q9eBL/IH9pSDbe9IZyHyNlwrlZo6/m5axCe8iKQxH/T1EwG3FW5xXVQKUPTX?=
 =?us-ascii?Q?HkA/elnpc9XuwUtlhNr/CdWjRRclHzGS5Nh5mDl/WPYKifS5SWDfxqgdlxRu?=
 =?us-ascii?Q?NHvY/m1q7pcc4UibYpVv4rnFpI2WJ0q79sMXe7y5T6mC4qz0LIcpwlXeMnzw?=
 =?us-ascii?Q?aVN4G5JqbV08LGuW9IZVjJIW/xHu9rgoMMR4euIszABvLt/TuSm52B7tJqyR?=
 =?us-ascii?Q?hGHvxRxWMe7HwYxElBGi7hzPFsA7neix6xIeaqcpHrilAhBd8LSgd6UWy34W?=
 =?us-ascii?Q?Fqr27CWf3yMdGtPm1TDvF6J5I5fsIm0KQdmRbTpxGmJrgPjr+qC+9UKlsb7W?=
 =?us-ascii?Q?bUhL+3Si5ZsaG3EWp8oGG9uErteBCmH4589K8MORx6fUmKQnfccqbfQweF5h?=
 =?us-ascii?Q?H8rHYY2X3AYhmBs6geY=3D?=
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	7RJvKpM/LaCr3e10VsRAdt/FlpJx7EC+zAD2ZoUKjXqwtflhWIS3eMnVGenb7kWKWiXfF3fpF2+YRrbt9QhCtSB5IvsR+PPNqBqTkLwOFdGFkaSMTPLYrpfiQ4VwAfV6vy1pD5aRAzx7ofsYNMi1R3gNWJwYYRrrSeBopVvjUJDq8tbFvICYjanoInhifW5znhIxQd3RvCIVMgSQqkRSII73a0hQsfhwmqSxJtjVuogwyqrYo1ImPZjKgoRlc1FYCUDWeh8r2OxoiDEiegnSeMS5LrgdozYwpvzrzet5wa5HXBTk8GNyAMbImtiLEGlqYp0Gr8mg/VtJPp+1vmYYUP6qYs72OYr0cT+JADTJVLka6rzw/Dtn9MGSAlTl6PEIei1EZRRLzh19wVEy20yNFWIfo4GINyNy9hhgsVjlJG2pyYYyN61/0B/tyjp0pGKIOmkAXQexEgL7Xa594L5NDtgtzpI5ub/9HkNcpC/fS0CwpsQALgCI/LnC6EhuF+yd8U+EmmwfxGVEOsxAf9eQGW9mAwlzrCkLfXTIbqmQRiP7a+JddoSNUr2SDLwAfH6tCHD94FrZaVLup4RYGm0qCFdGsy+K3lC+hXLrfwOsth20Fss6Uzlff0nqUxExXd+p
X-OriginatorOrg: sony.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA3PR13MB6372.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 13cc71cc-20d0-4cbb-5c8d-08dc6dfa8b1e
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2024 18:30:02.2434
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FtsWZYJf8dxqMMPWQ0MUBlW/g1iQiY/f6V2NFlyMshYF0g33itq5/NmSl3N6PBFSYeaKDCU01I+e3uWZGNGTIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR13MB6996
X-Proofpoint-ORIG-GUID: -IE7KEZsgApLh0oMp0Og9J3wziULzeU8
X-Proofpoint-GUID: -IE7KEZsgApLh0oMp0Og9J3wziULzeU8
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
X-Sony-Outbound-GUID: -IE7KEZsgApLh0oMp0Og9J3wziULzeU8
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-06_13,2024-05-06_02,2023-05-22_02


> -----Original Message-----
> From: Wen Yang <wen.yang@linux.dev>
> Add several new test cases which assert corner cases on the eventfd
> mechanism, for example, the supplied buffer is less than 8 bytes,
> attempting to write a value that is too large, etc.
>=20
> 	./eventfd_test
> 	# Starting 9 tests from 1 test cases.
> 	#  RUN           global.eventfd01 ...
> 	#            OK  global.eventfd01
> 	ok 1 global.eventfd01

These are horrible test case names.  Can you please use strings which indic=
ate
what is being tested, that are useful to a human?
 -- Tim

> 	#  RUN           global.eventfd02 ...
> 	#            OK  global.eventfd02
> 	ok 2 global.eventfd02
> 	#  RUN           global.eventfd03 ...
> 	#            OK  global.eventfd03
> 	ok 3 global.eventfd03
> 	#  RUN           global.eventfd04 ...
> 	#            OK  global.eventfd04
> 	ok 4 global.eventfd04
> 	#  RUN           global.eventfd05 ...
> 	#            OK  global.eventfd05
> 	ok 5 global.eventfd05
> 	#  RUN           global.eventfd06 ...
> 	#            OK  global.eventfd06
> 	ok 6 global.eventfd06
> 	#  RUN           global.eventfd07 ...
> 	#            OK  global.eventfd07
> 	ok 7 global.eventfd07
> 	#  RUN           global.eventfd08 ...
> 	#            OK  global.eventfd08
> 	ok 8 global.eventfd08
> 	#  RUN           global.eventfd09 ...
> 	#            OK  global.eventfd09
> 	ok 9 global.eventfd09
> 	# PASSED: 9 / 9 tests passed.
> 	# Totals: pass:9 fail:0 xfail:0 xpass:0 skip:0 error:0
>=20
> Signed-off-by: Wen Yang <wen.yang@linux.dev>
> Cc: SShuah Khan <shuah@kernel.org>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Andrei Vagin <avagin@google.com>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: linux-kselftest@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  .../filesystems/eventfd/eventfd_test.c        | 116 ++++++++++++++++++
>  1 file changed, 116 insertions(+)
>=20
> diff --git a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c b=
/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> index f142a137526c..eeab8df5b1b5 100644
> --- a/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> +++ b/tools/testing/selftests/filesystems/eventfd/eventfd_test.c
> @@ -183,4 +183,120 @@ TEST(eventfd05)
>  	close(fd);
>  }
>=20
> +/*
> + * A write(2) fails with the error EINVAL if the size of the supplied bu=
ffer
> + * is less than 8 bytes, or if an attempt is made to write the value
> + * 0xffffffffffffffff.
> + */
> +TEST(eventfd06)
> +{
> +	uint64_t value =3D 1;
> +	ssize_t size;
> +	int fd;
> +
> +	fd =3D sys_eventfd2(0, 0);
> +	ASSERT_GE(fd, 0);
> +
> +	size =3D write(fd, &value, sizeof(int));
> +	EXPECT_EQ(size, -1);
> +	EXPECT_EQ(errno, EINVAL);
> +
> +	value =3D (uint64_t)-1;
> +	size =3D write(fd, &value, sizeof(value));
> +	EXPECT_EQ(size, -1);
> +	EXPECT_EQ(errno, EINVAL);
> +
> +	close(fd);
> +}
> +
> +/*
> + * A read(2) fails with the error EINVAL if the size of the supplied buf=
fer is
> + * less than 8 bytes.
> + */
> +TEST(eventfd07)
> +{
> +	int value =3D 0;
> +	ssize_t size;
> +	int fd;
> +
> +	fd =3D sys_eventfd2(0, 0);
> +	ASSERT_GE(fd, 0);
> +
> +	size =3D write(fd, &value, sizeof(value));
> +	EXPECT_EQ(size, -1);
> +	EXPECT_EQ(errno, EINVAL);
> +
> +	close(fd);
> +}
> +
> +/*
> + * If EFD_SEMAPHORE was not specified and the eventfd counter has a nonz=
ero
> + * value, then a read(2) returns 8 bytes containing that value, and the
> + * counter's value is reset to zero.
> + * If the eventfd counter is zero at the time of the call to read(2), th=
en the
> + * call fails with the error EAGAIN if the file descriptor has been made=
 nonblocking.
> + */
> +TEST(eventfd08)
> +{
> +	uint64_t value;
> +	ssize_t size;
> +	int fd;
> +	int i;
> +
> +	fd =3D sys_eventfd2(0, EFD_NONBLOCK);
> +	ASSERT_GE(fd, 0);
> +
> +	value =3D 1;
> +	for (i =3D 0; i < 10000000; i++) {
> +		size =3D write(fd, &value, sizeof(value));
> +		EXPECT_EQ(size, sizeof(value));
> +	}
> +
> +	size =3D read(fd, &value, sizeof(value));
> +	EXPECT_EQ(size, sizeof(uint64_t));
> +	EXPECT_EQ(value, 10000000);
> +
> +	size =3D read(fd, &value, sizeof(value));
> +	EXPECT_EQ(size, -1);
> +	EXPECT_EQ(errno, EAGAIN);
> +
> +	close(fd);
> +}
> +
> +/*
> + * If EFD_SEMAPHORE was specified and the eventfd counter has a nonzero =
value,
> + * then a read(2) returns 8 bytes containing the value 1, and the counte=
r's
> + * value is decremented by 1.
> + * If the eventfd counter is zero at the time of the call to read(2), th=
en the
> + * call fails with the error EAGAIN if the file descriptor has been made=
 nonblocking.
> + */
> +TEST(eventfd09)
> +{
> +	uint64_t value;
> +	ssize_t size;
> +	int fd;
> +	int i;
> +
> +	fd =3D sys_eventfd2(0, EFD_SEMAPHORE|EFD_NONBLOCK);
> +	ASSERT_GE(fd, 0);
> +
> +	value =3D 1;
> +	for (i =3D 0; i < 10000000; i++) {
> +		size =3D write(fd, &value, sizeof(value));
> +		EXPECT_EQ(size, sizeof(value));
> +	}
> +
> +	for (i =3D 0; i < 10000000; i++) {
> +		size =3D read(fd, &value, sizeof(value));
> +		EXPECT_EQ(size, sizeof(value));
> +		EXPECT_EQ(value, 1);
> +	}
> +
> +	size =3D read(fd, &value, sizeof(value));
> +	EXPECT_EQ(size, -1);
> +	EXPECT_EQ(errno, EAGAIN);
> +
> +	close(fd);
> +}
> +
>  TEST_HARNESS_MAIN
> --
> 2.25.1
>=20