Received-SPF: pass (google.com: domain of linux-kernel+bounces-170301-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
From: Ricardo Ribalda <ribalda@chromium.org>
Date: Mon, 6 May 2024 20:38:15 +0200
Message-ID: <CANiDSCs8i5Eid-FhDkgxTghFu8Sk831SojZwAohJ-CbKRch5KQ@mail.gmail.com>
Subject: Conditional guards
To: Peter Zijlstra <peterz@infradead.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Peter

Probably a stupid question.... but I'd rather ask the expert directly :)

I am trying to fix some of the cocci warnings with guard() and there
is a  use case that I do not know how to do. I have something like:

void use_hardware(priv) {
  if (priv->model =3D=3D 42)
      mutex_lock(&priv->lock):

  // DO things here

  if (priv->model =3D=3D  42)
      mutex_unlock(&priv->lock):
}

if I replace:
  if (priv->model =3D=3D 42)
      mutex_lock(&priv->lock):
with
if (priv->model =3D=3D 42)
     guard(mutex)(&priv->lock)

gcc screams at me:
drivers/media/dvb-core/dvb_frontend.c: In function =E2=80=98dvb_frontend_op=
en=E2=80=99:
/include/linux/cleanup.h:119:9: error: expected expression before
=E2=80=98class_mutex_t=E2=80=99
  119 |         class_##_name##_t var
__cleanup(class_##_name##_destructor) =3D   \
      |         ^~~~~~
/include/linux/cleanup.h:164:9: note: in expansion of macro =E2=80=98CLASS=
=E2=80=99
  164 |         CLASS(_name, __UNIQUE_ID(guard))
      |         ^~~~~
drivers/media/dvb-core/dvb_frontend.c:2776:17: note: in expansion of
macro =E2=80=98guard=E2=80=99
 2776 |                 guard(mutex)(&apadter->mfe_lock);


Is there a way to support something like this?

Regards!

--=20
Ricardo Ribalda