Received-SPF: pass (google.com: domain of linux-kernel+bounces-170305-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240505214754.891700-1-andreas@kemnade.info> <20240505214754.891700-4-andreas@kemnade.info>
 <CAHp75Vdnwrxw96prr9hyLdZ2u6t1uNcj6pyxCp52UoVOpatTpg@mail.gmail.com> <20240506182111.3c6673a0@aktux>
In-Reply-To: <20240506182111.3c6673a0@aktux>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Mon, 6 May 2024 21:43:14 +0300
Message-ID: <CAHp75VchLWQgmdxKPSbwH-m43zFHT9ADk4aH7-jvD5-MaVOtEw@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] Input: ektf2127 - add ektf2232 support
To: Andreas Kemnade <andreas@kemnade.info>
Cc: dmitry.torokhov@gmail.com, robh@kernel.org, krzk+dt@kernel.org, 
	conor+dt@kernel.org, u.kleine-koenig@pengutronix.de, hdegoede@redhat.com, 
	siebren.vroegindeweij@hotmail.com, linux-input@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 6, 2024 at 7:21=E2=80=AFPM Andreas Kemnade <andreas@kemnade.inf=
o> wrote:
> On Mon, 6 May 2024 15:05:52 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > To: Andreas Kemnade <andreas@kemnade.info>
> > Date: Mon, 6 May 2024 15:05:52 +0300
> > On Mon, May 6, 2024 at 12:48=E2=80=AFAM Andreas Kemnade <andreas@kemnad=
e.info> wrote:

..

> > I'm wondering if you are using --histogram diff algo when preparing the=
 patches.
>
> No, I am not using that, it seems to not make that chunk nicer.
> Yes, we want
>
> +       int status_shift;
>  };
> +
> +struct ektf2127_i2c_chip_data {
> +       int status_shift;
> +};
>
> But that is not shorter or simpler, just more readable.

And that's exactly what histogram is about. I suggest making it
default for the Linux kernel project (or globally in your
~/.gitconfig).


--=20
With Best Regards,
Andy Shevchenko