Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp82820lqh; Mon, 6 May 2024 11:59:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUAifWDq9kByRCY90AF8ssU7Xf3adQ91UrPeOuF/raQ7jay4lntdIKlzsnrUCjslafksErV+mYYV3mWmV+Q1eR2ez1M3V2SpRJwQZU2zg== X-Google-Smtp-Source: AGHT+IEPgwZO5t+jKyaeHGNI+Se1rDUqKhgVGgbmNGKNM/lTeuSPbDYfWnrzUVWnwNHF91r7ebus X-Received: by 2002:a17:902:e88f:b0:1ec:31f5:16d5 with SMTP id w15-20020a170902e88f00b001ec31f516d5mr12824376plg.33.1715021978430; Mon, 06 May 2024 11:59:38 -0700 (PDT) Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id e1-20020a170902784100b001ed37286134si6698217pln.311.2024.05.06.11.59.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 11:59:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-170313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170313-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C762FB215D8 for ; Mon, 6 May 2024 18:57:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 29931158DC1; Mon, 6 May 2024 18:57:17 +0000 (UTC) Received: from fgw20-7.mail.saunalahti.fi (fgw20-7.mail.saunalahti.fi [62.142.5.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 467158494 for ; Mon, 6 May 2024 18:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.142.5.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715021836; cv=none; b=a1fXieGUbP5n23bE5f3XWYUI2VYZ1hsMjk8CW/mjvWb6MZf37szuXepR7r+osQ2xUbIMQjwtlwDZieRfRF+8jqy4bSgfmnr86wmI9vLyeh05ijlYgR2GHagj6o4Y6Kvypm/FTPMVeUZD0dAdLMLZH+Qu+Ha0MP79hkRMIRv1uqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715021836; c=relaxed/simple; bh=dMhPV3IMcLOLNuDvwfw8BsOYqG4R3kM9nwX10XYlXyA=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=goZDd3PSuaM1rpnFIccgUkr8zkIm2a5E3QSTkTi+xeQWgNJec3bQVCF2EoZ7c0QHEPc0/hQnHVEXDZ7V6clBrkb5bMslDQK5KX9NSSIcifJUKydmlHJcU2JmvJAZLc3Z1HnDMRsxiGETTudzkAl+5WLNKYkzY6f10Xz+PU3qwjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=fail smtp.mailfrom=gmail.com; arc=none smtp.client-ip=62.142.5.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=gmail.com Received: from localhost (88-113-25-208.elisa-laajakaista.fi [88.113.25.208]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id 4a9edbaf-0bda-11ef-b3cf-005056bd6ce9; Mon, 06 May 2024 21:56:05 +0300 (EEST) From: Andy Shevchenko Date: Mon, 6 May 2024 21:56:05 +0300 To: Johan Hovold Cc: Lee Jones , Mark Brown , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Das Srinagesh , Satya Priya , Stephen Boyd , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 02/13] mfd: pm8008: fix regmap irq chip initialisation Message-ID: References: <20240506150830.23709-1-johan+linaro@kernel.org> <20240506150830.23709-3-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240506150830.23709-3-johan+linaro@kernel.org> Mon, May 06, 2024 at 05:08:19PM +0200, Johan Hovold kirjoitti: > The regmap irq array is potentially shared between multiple PMICs and IRQ > should only contain static data. > > Use a custom macro to initialise also the type fields and drop the > unnecessary updates on each probe. .. > +#define _IRQ_TYPE_ALL (IRQ_TYPE_EDGE_BOTH | IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW) This is repetition of IRQ_TYPE_DEFAULT. .. > - dev_err(dev, "Failed to probe irq periphs: %d\n", rc); > + dev_err(dev, "failed to add IRQ chip: %d\n", rc); dev_err_probe(...); ? -- With Best Regards, Andy Shevchenko