Received-SPF: pass (google.com: domain of linux-kernel+bounces-170323-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <1ff60e91-ac20-476b-a83e-8f9f2f797eb4@nvidia.com>
Date: Mon, 6 May 2024 12:08:41 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] selftests/exec: build with -fPIE instead of -pie, to make
 clang happy
To: Kees Cook <keescook@chromium.org>
Cc: Shuah Khan <shuah@kernel.org>, Eric Biederman <ebiederm@xmission.com>,
 Muhammad Usama Anjum <usama.anjum@collabora.com>,
 Mark Brown <broonie@kernel.org>, linux-mm@kvack.org,
 Valentin Obst <kernel@valentinobst.de>, linux-kselftest@vger.kernel.org,
 LKML <linux-kernel@vger.kernel.org>, llvm@lists.linux.dev
References: <20240504022301.35250-1-jhubbard@nvidia.com>
 <202405061007.F1A46E89@keescook>
Content-Language: en-US
From: John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <202405061007.F1A46E89@keescook>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TXBYbWNUcktJelU0TkRxd0s5YzBiMnJkQ25iNmhUTHdPVHkwVEw0MmpOQk93?=
 =?utf-8?B?LzRKT0w2SXRZVXorYzhkTWgxVUJnSStSU3NtYXNWOFFMOHVNNFM3RmRLSzJq?=
 =?utf-8?B?dURLYUloemc3VEVZRVNhOVkyYUVYT0VnMmU5MGZxUitZNEVJb2ZqbmN1UGRu?=
 =?utf-8?B?TXlrRkVsOUt2Wm9sYlY2OVNnYU5UTzRRcm5KSTlBblQ1QWhORTlwaWtDVXpL?=
 =?utf-8?B?bjduaWs3ejVFNUhxQ3gzYUJlcVJkSFozTWlEUDdCT2ZvUHJialYrSnVvMkVx?=
 =?utf-8?B?OFViQUNhSEJHRXM5ZFdRdjRaditWdDVhMzhPM25LSlZJejNjaFMxTFRMek4z?=
 =?utf-8?B?L3dLeWV0US9XOS9RbEx0THpjQ1BXcm54aUVpdUNQSVBRcDNEbzgzMHhiSkFy?=
 =?utf-8?B?cjBDYVR2TlY3Z2FQVDQxdU5vcHZQQW9WVWplbU8zM1YySG9xdnp0MkZlU2FZ?=
 =?utf-8?B?WFRLK3lSeUxmRVpUU0JDZE0rWVMyYlVTQ0JpVWtoQ1BxSXNTVXkyaEdOVmtX?=
 =?utf-8?B?aGl6aHFYQUQ5Mlo1RWZsM09CU3ArY05YRlZJbmk4ak9sdHdvcURaN3lEbVN6?=
 =?utf-8?B?K0laSDNsaEFwdFlFcjRwOU12dWRKcDBraG1IWi9GbDlGaGtpdnZuL2cwTnZw?=
 =?utf-8?B?a2JScGJXWkpBdzBaK1lPUUV4UHc3VmRxVHYwTGEvRVVVR29ESlBWUjlDTzhP?=
 =?utf-8?B?emVRN1VXbHI2bTBaMG1YSi8zMDdsQXhMUVFudE91ckpiS3BWVElmcHpOU0V5?=
 =?utf-8?B?S1FMeDZEV0dIem1OcktZRzVobDJOb25EUnUvMWxVazRReVA2M3RzaGVQcGpV?=
 =?utf-8?B?N2s5YXBNTkpqTHdMVFZBOGE3RXdKMEZqOWpBQXJQd2xVdHRVM0VLMjhUQlNa?=
 =?utf-8?B?N2xhYVMweVlJMEtPclJwN3VQem8zNzF1RUpFM0RmY3E0WUpOemVyeG5WQndF?=
 =?utf-8?B?L3VHR3crQTRzbUdGUGNtMmxIZTB4NGZMdHVEbzZ4MmFGN3d6WTNrditXOGgv?=
 =?utf-8?B?bWkxZUhyckJqdUVWWHNDb0JjS3V2WXc1N2FIVUtubGpKNVdPck5RL29JdUpO?=
 =?utf-8?B?eFp1WklqZ2xJRUpjc2hBN3ZTWVZBYi9haGtoVTk3UHZoUlRNYnFVZHl4T3hp?=
 =?utf-8?B?eERJem9rV1hoZUU0MUJQVlRmS1l5dDlQQ2lOYnZ1R1ZVUTZ5dGJ6bVBhcW5Y?=
 =?utf-8?B?bmEvZnZqMUFsdVd3dFFQdldpZVlqZ2dyWUsveFdDT0FrS2tyQ3MwS04yT0Ey?=
 =?utf-8?B?SndWZXd0TVFjZ1VzNEpyQmkvUHJsZkU1c2tVamR0azV1RkhPSXRMT1Y3eGpq?=
 =?utf-8?B?UVlTeVVrWWt4Vk9PZk9UVnFaSDZ1V1p0SlZNYVM3Y3Bob0MzdkVHS2dWOTM1?=
 =?utf-8?B?My9uc2x0Zk1nbFkxYU5iNHF2eEE3bHZiK1BTTmVnUVBPMmYrQmZHTkFkWVls?=
 =?utf-8?B?eUZDZjloOGtrcTBSenllOHVudnoraWZBMDRUdzhIQy9xSGdRZWpvM0ZmUG1i?=
 =?utf-8?B?MzFvdllOdnh3T1hTV09SaDZ1ZmpoR2NVR25kaEZhdEV0Y1lnWkpST0szWVl4?=
 =?utf-8?B?K2h4bzltRzMxWGt6clVqYXpIdlp1NW82SVduMmNWTVVsWjYrM1hvdjVQYkhw?=
 =?utf-8?B?YUNDSWdURmx1cURnWk5wOWhkSkQveGh6MDBQUnp1Y3h5ZE16WG00Wk91VU82?=
 =?utf-8?B?VVNZSksrejV4cVVFT1AydUNHamdZTVNOdCs3bTZTZmdlWVowUjEwWjdXWFht?=
 =?utf-8?B?V2NWUXh6QUpFRGNNR3U1SHJMYU1tS2hDVzV1Z1ppYTN0ZG5UMjZOSmdMSElK?=
 =?utf-8?B?OVMwMmhscVRDMis3NisyalRzb054N0tINGdKNVVOZng1akNvRUNnaGYxY3Nm?=
 =?utf-8?B?dXlvMmwyaUw0dnZjMU1HSUdoMUdKV2NBYTJUbWZJa0diQ1hlSkJ0YmlVQWtI?=
 =?utf-8?B?UzNxL25pclBIWEs0T1JDZFFiUlNqMld3cmNDak1zSVdzQWw4b0JuN2xRTTFk?=
 =?utf-8?B?SDUxT3VBY2lJUGxjU01rUnE4S0FMVGRJTXpNUjZmblhjSVEwTU1RMmxDbmNI?=
 =?utf-8?B?d1AvQzJ2NXM0eXdwTXM3U1hpMTN4NUYzcHB4OEdxVUsvUmVrYkZraThEZVNR?=
 =?utf-8?B?N0F1aGN2dDdVSUF1SUpKaHF6aWhFbWdXL3ZzZHRPQ2hqdG9OK2NKYW9NbXZt?=
 =?utf-8?B?K2c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1afdc90e-200f-4de1-28e1-08dc6dfff71e
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 19:08:51.0997
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a8e56/MZSVPSwLv2++k098BQZeh7ebFsSphCGcMUeBJlzLLVNTvlbMgdtqqO/HiyAF7Xc1xaIoeP7+j6sB+YDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7880

On 5/6/24 10:09 AM, Kees Cook wrote:
> On Fri, May 03, 2024 at 07:23:01PM -0700, John Hubbard wrote:
>> clang doesn't deal well with "-pie -static": it warns that -pie is an
>> unused option here. Changing to "-fPIE -static" solves this problem for
>> clang, while keeping the gcc results identical.
>>
>> The problem is visible when building via:
>>
>>      make LLVM=1 -C tools/testing/selftests
>>
>> Again: gcc 13 produces identical binaries for all of these programs,
>> both before and after this commit (using "-pie"), and after (using
>> "-fPIE").
>>
>> Also, the runtime results are the same for both clang and gcc builds.
> 
> Thanks for this! It got solved differently here:
> https://lkml.kernel.org/r/20240416152831.3199999-1-usama.anjum@collabora.com
> 
> Does that work for you as well?
> 

Yes it does. Please drop my patch and let's use yours instead, thanks!

(As an aside, outside of the compiler sources themselves, it has
proven quite difficult to find any in-depth documentation of linking
options and behavior--now, and in the past.)

thanks,
-- 
John Hubbard
NVIDIA