Received-SPF: pass (google.com: domain of linux-kernel+bounces-170333-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 06 May 2024 15:23:45 -0400
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: John Hubbard <jhubbard@nvidia.com>, 
 Shuah Khan <shuah@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>, 
 Eric Dumazet <edumazet@google.com>, 
 Jakub Kicinski <kuba@kernel.org>, 
 Paolo Abeni <pabeni@redhat.com>, 
 Steffen Klassert <steffen.klassert@secunet.com>, 
 Herbert Xu <herbert@gondor.apana.org.au>, 
 =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, 
 Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, 
 Matthieu Baerts <matttbe@kernel.org>, 
 Mat Martineau <martineau@kernel.org>, 
 Geliang Tang <geliang@kernel.org>, 
 Pravin B Shelar <pshelar@ovn.org>, 
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>, 
 Alexander Mikhalitsyn <alexander@mihalicyn.com>, 
 zhujun2 <zhujun2@cmss.chinamobile.com>, 
 Petr Machata <petrm@nvidia.com>, 
 Ido Schimmel <idosch@nvidia.com>, 
 Hangbin Liu <liuhangbin@gmail.com>, 
 Nikolay Aleksandrov <razor@blackwall.org>, 
 Benjamin Poirier <bpoirier@nvidia.com>, 
 Sebastian Andrzej Siewior <bigeasy@linutronix.de>, 
 Dmitry Safonov <0x7f454c46@gmail.com>, 
 netdev@vger.kernel.org, 
 linux-arm-kernel@lists.infradead.org, 
 linux-actions@lists.infradead.org, 
 mptcp@lists.linux.dev, 
 dev@openvswitch.org, 
 Valentin Obst <kernel@valentinobst.de>, 
 linux-kselftest@vger.kernel.org, 
 LKML <linux-kernel@vger.kernel.org>, 
 llvm@lists.linux.dev, 
 John Hubbard <jhubbard@nvidia.com>
Message-ID: <66392e41e6889_55f25294dc@willemb.c.googlers.com.notmuch>
In-Reply-To: <20240506190204.28497-1-jhubbard@nvidia.com>
References: <20240506190204.28497-1-jhubbard@nvidia.com>
Subject: Re: [PATCH v2] selftests/net: fix uninitialized variables
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

John Hubbard wrote:
> When building with clang, via:
> 
>     make LLVM=1 -C tools/testing/selftest
> 
> ...clang warns about three variables that are not initialized in all
> cases:
> 
> 1) The opt_ipproto_off variable is used uninitialized if "testname" is
> not "ip". Willem de Bruijn pointed out that this is an actual bug, and
> suggested the fix that I'm using here (thanks!).
> 
> 2) The addr_len is used uninitialized, but only in the assert case,
>    which bails out, so this is harmless.
> 
> 3) The family variable in add_listener() is only used uninitialized in
>    the error case (neither IPv4 nor IPv6 is specified), so it's also
>    harmless.
> 
> Fix by initializing each variable.
> 
> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks!