Received-SPF: pass (google.com: domain of linux-kernel+bounces-170373-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <c37e5aac-3bc7-4013-b58a-e29c6bfbfd1f@oracle.com>
Date: Mon, 6 May 2024 12:54:17 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] mm/madvise: Add MF_ACTION_REQUIRED to
 madvise(MADV_HWPOISON)
To: Miaohe Lin <linmiaohe@huawei.com>, nao.horiguchi@gmail.com,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20240501232458.3919593-1-jane.chu@oracle.com>
 <20240501232458.3919593-3-jane.chu@oracle.com>
 <0c7dbf7d-dcb6-f9f2-4a2a-9700ea465a47@huawei.com>
Content-Language: en-US
From: Jane Chu <jane.chu@oracle.com>
In-Reply-To: <0c7dbf7d-dcb6-f9f2-4a2a-9700ea465a47@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?YW8yV2Z1UjM2cDB2OGFQbk4ySmdqUG5sd0x4ZHNBenpodXprZ1UzNGRtNVNX?=
 =?utf-8?B?K1ZhMk1rcjhDU2V3RmxNWnBBYzcxZ1lMRXpIYWhjbzBUVjZNSGk4b0FCejJv?=
 =?utf-8?B?aHdxS0hXdkZOWk5pSWg4LzBVbXRrZjVBUE5hcVdXa0s3MXdoSkhYWm5MMHV5?=
 =?utf-8?B?VU9JQ0xkQmp5cmZPclNWRWJlaDIrallpTG9CNGliWkZ5bFZva1hkcmpUL0RP?=
 =?utf-8?B?S1kzQy8yUEpEbWNKbUkwamlsUC9LUGRnOHhBaUZUM3hoSGtYMVd1dHBqM3lw?=
 =?utf-8?B?aXFBUGgzSzIveHRoYlFIZExNNFE2SWxFMTlQM2E1U0FDcUsxcStaaWtqbXhp?=
 =?utf-8?B?SFBWTVV0UXZYSHkwOXZCZ2pPc1JMWHJ5YUI1Q2lFaWJwQzQvZC9jaGg1NEUw?=
 =?utf-8?B?RThsNnM2M1FZWGdhcUNMb0owQS9Rdm9mZFQwa2JVU2E4U2Rna1E0UVBxcXZ0?=
 =?utf-8?B?ZWNPZEdIOG1iUCt3UGd1UWtyMndORSs4a0lhVTBNS3FQc1VuaTJFSkVNWDRl?=
 =?utf-8?B?N21XdUwxN29QNjVwWVNLeU5qdW1CSXJUY0ExNTlYeDNtM2F1MHhQSGFEaTdH?=
 =?utf-8?B?b1Iya1QrQjZaM3pGSGtWVldjK3pBUlpNWHlOWGNnL3daeXZ4VGpLTmRDc1ZH?=
 =?utf-8?B?UFIrNm9IRGgzMHdMcTVYSnZnZUZLL1RUSmJGOWJ3QjMwdmkzYmVSdGRrKzF1?=
 =?utf-8?B?dm5WZStoN2ZGYkI4aFRlVTlRTjBuZUMxcEUzNG42YjI2TDJlTm02dTBDREpE?=
 =?utf-8?B?WmdMQ09EaG1LeGdjb0p6OE40N1ZrS2dJN09pZTY0MXgzOU5XTGRoYXNrNlhN?=
 =?utf-8?B?WUc4TjNKdXF0V0xYNFFxT0g2ZnA1TksvUzAvR2x6bW1GaDk0WDZWOC9uWTBQ?=
 =?utf-8?B?NTJiTlY1TGVDZTYxbHNzdWF5OGZPTG9FT2huQU5wV3F4bE92cVRMRUxxb0hD?=
 =?utf-8?B?dVZMVm9WT3pxRVpDYmxKNFIwem9pQlpNU3FFZkZoTWtZVFBVRFYwL3JqOHRZ?=
 =?utf-8?B?TnRybHJRYldQOWw4dm9OT2FxVlRxblhzSnJwckdHUitITExPb3Buc2NxcGY0?=
 =?utf-8?B?dGtqdTRYcVJDRGU1MWtsMU1KMVpoOGRFL1hkUGd5SlE4N3REYjFKaEhFdGlY?=
 =?utf-8?B?dG5SYVJobmhVNERRaTNjcmRaMWJIS05jaWhkRGJLSlhxaGlpVndKWWR3dG9l?=
 =?utf-8?B?VVNOK1U4YWNWNmZLdXYvdGExdm1UNVlSK2dER2o4YmZGRC9mWUtNTjUyd3Nw?=
 =?utf-8?B?UnFENFloODZENTV2RWYyckdUS1ljM0NCeVlMZmN5eFQxdHJqQlhBZEVMY2ln?=
 =?utf-8?B?UjhZOThpTXVRdGhYS0d0RmtYSmlWZXJxZitHVk5OT29sa1NXNERNYW41aDZU?=
 =?utf-8?B?MTIzdmZlZ3VVc3BYaERkcEY4WFFsaGNNakpwSXdFOXNMaWVkSnJXQyszK3A3?=
 =?utf-8?B?YzV4eGY0bERaSmxuLzR3UE1zbE8yeHRMdk1mcVBNS1VUeUEwR21UblN3bzZs?=
 =?utf-8?B?dk93cmVmSzFZSTNTZkh3ZjN0ZVcrbkhQUWtzQUcxL0RycDF1eC81OWwrYjlo?=
 =?utf-8?B?WkltQWFHZ0x3b3Q5bGw1S3BTUFFxSmFRTlhjNmRqZ2VZTW5pVEVWeVFtNXRV?=
 =?utf-8?B?UXVUaVpEaFpDQWI3NzJkaWExNWxiallqWVBjMGsxU0libGVVeENmeVZVSHEx?=
 =?utf-8?B?dHhBWm5yYk9SZ05nTHk0QVM1SUFmTkNidTRGOFV1OUlNbTdqVEJYbWkwd0tp?=
 =?utf-8?B?d3RwZXUybjBOd1l0SlZQbjRaclNPaHQzc08yemptdzBSYTJoUS81eEkyZWRp?=
 =?utf-8?B?TUpPVUFNelJ1dkNIenpBNUswK1FKcnFscTdmcEg0cXBmUVJiS3JJb0ErWWsx?=
 =?utf-8?B?dklqOGk4SDRTT3ZoR1NyblR0RWZEcHUrbFRVYWZDR0xka2dGVzR2MUIvdGM5?=
 =?utf-8?B?UjZEelpFUkpsU1lCb2g3OXh6SWUwL2Vrem5NZHJqTUY3VGdTUmJIOWRvalAw?=
 =?utf-8?B?RnpKUlExWXNxdE5Vd3JnN0RwOGxDQklyUjRCTUk3UlFaOFpOdk8ycUw1bHox?=
 =?utf-8?B?U0RsT3B6RGUyRUw3VGVwRW5OWmt2UTB6KzFlQkhPT09pM2FUV0FwazExQzdK?=
 =?utf-8?Q?qgd75pzODqe207o8AH1H5kCmw?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	VdOogne9bMWGCyIqMzoLYyNSOf17VvOyaC8TqLa0CHWRuoVdpDadVMbgNn1HWPKXHJXd76mkaRZyZydaS2/jBJqtz//RahCBwvDWKwHaEokl2ivR4jiZoAbxrR32bvm0zpxon2XbC45rUzsgOV6Q559bJbRnR2NhaiEVjH6izoKfmHyoPNqG3gjkuOUq8DIs7S/7ZFSnRAvf0YxuZdfLJU+zuvesEKpEUkTItgoCglG+H5dh2OaYJ0fAWMrr+27MdmikmQBWcEB0sOWARiZYwfdweznCNVTouJ5KQFzsGd2HF7F+qLmG25Mp34H1SrwjZ1M+2y2IHeVofthohyBxtAVu+V31MOyX7z3Gn5wRbZZZ0B3glS4VqbIqudpAQPv1o/NQjrAN81jg633EotB7QXvvuM7w37XaFK0069hAi4zBZfQ33mEF56P7rSLhPqw1OWS++K6mfDxQHJIsheInf5PlTIZ0l0YtI5ZBkIPA4dg5uS1eBH7d8gADOTu7L4fTrgRuKJcReXP6NUDx6MIDxdLd0aa7u1fN+35Y+ZaFnRP16D3UJaN1ABvX0wwyY2WYTuPRHFRNZiia7pVB5f344r2Ds/0Zv/2lJLUkYlHbGAM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1c75205-c89d-4139-749e-08dc6e06510a
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 19:54:18.9517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sEFh/C8NfbTwGBTI+xqRgCjdaEuIOReIxFPgZheQjx4s2e1ASA3Bzg+lujyU70z4v6mzEOMqFV+zd1n3wiczSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4787
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-06_14,2024-05-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0
 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2405060144
X-Proofpoint-GUID: y_PXnLBMaPk8CB4m5FD4xhE_gGjKKgOy
X-Proofpoint-ORIG-GUID: y_PXnLBMaPk8CB4m5FD4xhE_gGjKKgOy

On 5/5/2024 12:02 AM, Miaohe Lin wrote:

> On 2024/5/2 7:24, Jane Chu wrote:
>> The soft hwpoison injector via madvise(MADV_HWPOISON) operates in
>> a synchrous way in a sense, the injector is also a process under
>> test, and should it have the poisoned page mapped in its address
>> space, it should legitimately get killed as much as in a real UE
>> situation.
> Will it be better to add a method to set MF_ACTION_REQUIRED explicitly when inject soft hwpoison?
> Thanks.

So the first question is: Is there a need to preserve the existing 
behavior of  madvise(MADV_HWPOISON)?

The madvise(2) man page says -

        *MADV_HWPOISON *(since Linux 2.6.32)
               Poison the pages in the range specified by/addr/  and/length/
               and handle subsequent references to those pages like a
               hardware memory corruption.  This operation is available
               only for privileged (*CAP_SYS_ADMIN*) processes.  This
               operation may result in the calling process receiving a
               *SIGBUS *and the page being unmapped.

               This feature is intended for testing of memory error-
               handling code; it is available only if the kernel was
               configured with*CONFIG_MEMORY_FAILURE*.

And the impression from my reading is that: there doesn't seem to be a need.

A couple observations -
- The man page states that the calling process may receive a SIGBUS and the page being unmapped.
But the existing behavior is no SIGBUS unless MCE early kill is elected, so it doesn't quite match
the man page.
- There is 'hwpoison-inject' which behaves similar to the existing madvise(MADV_HWPOISON), that is,
soft inject without MF_ACTION_REQUIRED flag.

thanks,
-jane

> .
>
>> Signed-off-by: Jane Chu <jane.chu@oracle.com>
>> ---
>>   mm/madvise.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/madvise.c b/mm/madvise.c
>> index 1a073fcc4c0c..eaeae5252c02 100644
>> --- a/mm/madvise.c
>> +++ b/mm/madvise.c
>> @@ -1127,7 +1127,7 @@ static int madvise_inject_error(int behavior,
>>   		} else {
>>   			pr_info("Injecting memory failure for pfn %#lx at process virtual address %#lx\n",
>>   				 pfn, start);
>> -			ret = memory_failure(pfn, MF_COUNT_INCREASED | MF_SW_SIMULATED);
>> +			ret = memory_failure(pfn, MF_ACTION_REQUIRED | MF_COUNT_INCREASED | MF_SW_SIMULATED);
>>   			if (ret == -EOPNOTSUPP)
>>   				ret = 0;
>>   		}
>>