Received-SPF: pass (google.com: domain of linux-kernel+bounces-170387-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <119fbe0f-9688-4382-9263-220f69caa718@amd.com>
Date: Mon, 6 May 2024 15:23:02 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [RFC PATCH v3 04/17] x86/resctrl: Introduce
 resctrl_file_fflags_init
To: Reinette Chatre <reinette.chatre@intel.com>, corbet@lwn.net,
 fenghua.yu@intel.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
 dave.hansen@linux.intel.com
Cc: x86@kernel.org, hpa@zytor.com, paulmck@kernel.org, rdunlap@infradead.org,
 tj@kernel.org, peterz@infradead.org, yanjiewtw@gmail.com,
 kim.phillips@amd.com, lukas.bulwahn@gmail.com, seanjc@google.com,
 jmattson@google.com, leitao@debian.org, jpoimboe@kernel.org,
 rick.p.edgecombe@intel.com, kirill.shutemov@linux.intel.com,
 jithu.joseph@intel.com, kai.huang@intel.com, kan.liang@linux.intel.com,
 daniel.sneddon@linux.intel.com, pbonzini@redhat.com, sandipan.das@amd.com,
 ilpo.jarvinen@linux.intel.com, peternewman@google.com,
 maciej.wieczor-retman@intel.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, eranian@google.com, james.morse@arm.com
References: <cover.1711674410.git.babu.moger@amd.com>
 <363c14eeeac99eb0453ac3429f9e7bd446b2acdb.1711674410.git.babu.moger@amd.com>
 <55fa3189-b5da-494f-8ec2-7f0ab4b8d33e@intel.com>
Content-Language: en-US
From: "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <55fa3189-b5da-494f-8ec2-7f0ab4b8d33e@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z09aSU0xZFh1L3N5dXBsS3NSRkJia0YwZGg4NFJ6ejhXQkZkd2NnemoxN0Ez?=
 =?utf-8?B?Mk41MWlXMHMrMHByNXlLQlVPUjBXaFFPY1VVeFUrSytWMlcwTHd1VCtNOTBo?=
 =?utf-8?B?N21NYkJ0NUFoUnFBdWZSaWI3WnB3clN5UVJoRzV1bFlEMFhUb0RWNjdyZmVj?=
 =?utf-8?B?ekU4a2ZXYjI2d2JuZ25OMlJZR2xGbERvUGtJQUV3YlQ0U0k4dG0yVjU0QW9k?=
 =?utf-8?B?eWZpUU5xV21rblR6bHVPdUQycFJIU2tWcC9YVmViS2VDQllweVc1ZTZhUXda?=
 =?utf-8?B?bVdYSzF6NWMrQW5xMXQzUDlndDZNd2ttQ3EydUowMmMzR056VzI4VGU2cTE4?=
 =?utf-8?B?ZHNIdlczZFg0bTduTWNzYlZJRVNDKzN4U1FVdnpFbW92cGdNVkZKVzlxSTBD?=
 =?utf-8?B?bXlja01vcGRxZUJCVWR6dHpRMEMxeXRXaGs3ZlB3aGRGYTVyVjVRT093Z2d6?=
 =?utf-8?B?SWdGcVdvL1kxUmtvbmxtWWZwSnE4cWxEQlM5MWJ1RGFZdStVWmxHZGVUeTYz?=
 =?utf-8?B?NE9GTzdUb2N2TkRMU0ovbnRFdmtlZ3NVSTJ3VVlOT1ZLYytzVWpyeHBEeXBS?=
 =?utf-8?B?RUpQb2RZSUZJMVl1TDFVSHU1M2EvdkxtNTluNWMveldtdkxWcUFjUFJFWDU4?=
 =?utf-8?B?TnhjTUlocVF6OVBDaSszM0tYa1FRUVR5b0syRWtZK0pQRVdGMzhqYXQxYll3?=
 =?utf-8?B?Z004bm1qSkZ0RFlpdHpaS3JZNDZYdjlGelc4RG1Cekp3RE1GRWNwanZsTk1a?=
 =?utf-8?B?bWFYODU3YmpsMmI4UGJsVDlILzJMRTYyTjg0RzB1ZnY2Y1AxdmlVdVhWSXpY?=
 =?utf-8?B?S3FuNzRodFNkZGxmRWU0NGViVHB5MVZ0dTNjU1NmR1c0elBtTEQwOWpwMXpX?=
 =?utf-8?B?VzI2aFNycGR0eTRHNTUxckFqQkhVNWkzb3l2VG52M2lDUHhaOC9RRVV1R1hL?=
 =?utf-8?B?azVWblh5S3hqbXNDaXdQNnphelczVmplMFRSY2FCWHdBT292bnp5MlpJUTlQ?=
 =?utf-8?B?eWowUGFUSUpxOTYvZ2I2aVNGZ3RwQkw4ejNZMlFtdngxUlg4VEhOUVBtRS9U?=
 =?utf-8?B?N2ZLRzZFYUVzQ2owbm9xQVFwbkQ3Qzg5UjAzVFZLQjZoU3RYK1RZR3lCajdv?=
 =?utf-8?B?clVDYWgxWncxR3VNVkgweXhodUdJMy9NL21xcUg3aVE2akJ2Wml2TjFHaFpL?=
 =?utf-8?B?alZkNitsdEZJeHNvTEFYRnh6OWpQMXloTDhwektYa1V6cCsrVkQrS3RDcVJY?=
 =?utf-8?B?bnJSVmtqc1F6UHJZUDVRcFRjVUJOSjNuaHpSV251VjdDYmtTd082UTVvZHZp?=
 =?utf-8?B?ZGZ0SloxUlduRVJybTJqaE1ucmEyUlNLbEJZcTJoYzZOcThXZlZ5S01KclV0?=
 =?utf-8?B?T3ZlYWI5M2xuM3ZPT1VGaTYvV2E4VzMxcmtyYXVNV05UT2V4ZWM1eGg2L1hP?=
 =?utf-8?B?RGNKMldkc29kUVRjWXhyVUtKdGV6cEtaQ1dxOWtxNnpzWnNZZHYvMk5NKzRh?=
 =?utf-8?B?NXRwQk4xK2NtY2grTWFVQitsdkFTOTVPLzVDaDVvazZkR3hVS3VRbm5leGZB?=
 =?utf-8?B?SXJQTlFxaTJlYW55ZU1FOTVmVlR3WFQxT0RIZC9NU0RWZ05FOTBUb3Y3RGVm?=
 =?utf-8?B?cUdISW05V0luYWtWVnZndEtsYmZNMmJpc0t5V0I4MFRZN2c5U29nZ0RDbkUr?=
 =?utf-8?B?OWJNM2YrNkJJSThFVkNHVUhyek9NOEN2b3JkUzh6eVYvN2NXdmdmSzU1ZkRy?=
 =?utf-8?B?QzEwY0c5NmtESXFWRTJIOWhRcGI1bEF0MWVpQVlHMkNrcmlRTUFjRi9sRnVS?=
 =?utf-8?B?S1kvTG9Uam55blZFTDd0TzF6bHQrNW95UXRsTFc2U0prclNVOWF3cUNETWZ5?=
 =?utf-8?B?R041aDJPL1dISVlneFRzanBsby9zZkcxVEozcmJSejd3MnNXUjVVOHZhT1hW?=
 =?utf-8?B?ejJVSXp1dGV4aFJkUjhnYktCb2M4SVp3RzZsQ0xLcXpOeVNtSmFGeUFyWWlx?=
 =?utf-8?B?eUpDakpLZVV3cmVMUStNZzByUm0wSHpBT3krdUc1Sk9sZWNETkxUSUlRa2ZB?=
 =?utf-8?B?aUR6Y0M5bmdtSjBMaDE0bmFabWNaQndOY3dyYktxZ1ZrY3RZY2pGR2RsYmFl?=
 =?utf-8?Q?P3Zc=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9461f2fa-719f-4072-0421-08dc6e0a56ff
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 20:23:07.0743
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: O4IUh9b+jEzFfm2nbPwzQkbbUBapWNxKkc4KMfPphsWf1a9z7xfLwgnIbwz9WgB1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5598

Hi Reinette,

On 5/3/24 18:26, Reinette Chatre wrote:
> Hi Babu,
> 
> In shortlog, please use () to indicate function:
> resctrl_file_fflags_init().
> 
> On 3/28/2024 6:06 PM, Babu Moger wrote:
>> Consolidate multiple fflags initialization into one function.
>>
>> Remove thread_throttle_mode_init, mbm_config_rftype_init and
>> consolidate them into resctrl_file_fflags_init.
> 
> This changelog has no context and only describes what the code does,
> which can be learned from reading the patch. Could you please
> update changelog with context and motivation for this change?
How about this?

Consolidate multiple fflags initialization into one function.

The functions thread_throttle_mode_init() and mbm_config_rftype_init()
both initialize fflags for resctrl files. This can be simplified into one
function passing the file name and flags to be initialized. It also helps
code simplification of new flags initialized for ABMC feature.
-- 
Thanks
Babu Moger