Received-SPF: pass (google.com: domain of linux-kernel+bounces-170392-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <c172fa3d-d4a4-4605-8f39-df0536718bd5@oracle.com>
Date: Mon, 6 May 2024 13:26:19 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/3] mm/memory-failure: send SIGBUS in the event of thp
 split fail
To: Miaohe Lin <linmiaohe@huawei.com>, nao.horiguchi@gmail.com,
        akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <20240501232458.3919593-1-jane.chu@oracle.com>
 <20240501232458.3919593-4-jane.chu@oracle.com>
 <038cffc0-e027-b518-460f-40099819c588@huawei.com>
Content-Language: en-US
From: Jane Chu <jane.chu@oracle.com>
In-Reply-To: <038cffc0-e027-b518-460f-40099819c588@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ZC8xZ3Q5MFFvMlhNclRDYkE5YkErNGNzUXBZV1BWSWlFQi80VlpLSUVONTZi?=
 =?utf-8?B?RE5iR1pPcmFhRjlhend0UVFrdy9Ga0NNSzA1ZVZpSGd3aUltWTU0cFlQTGlP?=
 =?utf-8?B?MlZTUStIMi9jOXMyaFZHMmJwVnJNK2FnMWY0dGt5WGFZMUI5MHY4VG14cFc3?=
 =?utf-8?B?ak5uQUVVRkpBVUJNWTRRU2ZZSlBsNS84dkZNejNtWFNWaUdpcGhnWklYT0NV?=
 =?utf-8?B?VVZUQmdMK2dyWHBtTVByMTd0Y2J4WGZPeUhSdUZ0eVRVTDd4YkNkRlNnY0Fl?=
 =?utf-8?B?T3dXaE5ramY0N3RRWlcyclFnYkxodVl2d2IwUGNIZUJkOUtleFBJUnpJcWZ4?=
 =?utf-8?B?RDJXR0tOa3ZJUW1uNVdnTk84VFoyelNVaEFKZGdFclk3R0kraTJwWDVXOEwx?=
 =?utf-8?B?ZVNzWFRNMDlNb2hNNTcwOHMwMkpyS0RYYWxZb3M2cDdacng5bm5HZE0vYWxO?=
 =?utf-8?B?a014cy9VN2NaanpoWVk1UXJydnIveENNay9iWG9BYjhxNnBuakFUeC84ZFJo?=
 =?utf-8?B?eGhSRnRHRkJIeWUzYWEySm5BbWhXUFo3RjNBU2R5LytVVWhPcjVFWVMyVFBs?=
 =?utf-8?B?NHk5V09hN2x4REFlVFB1Wml1bWUxU0ZaTXBKbnJ6MHpzV0NLNzlxRmtFZmxO?=
 =?utf-8?B?WW5KVEdrQVFJUk1rYSsxdTZMTURsTmJLdTdyZU05R245RHp5NENvN2NQOXVm?=
 =?utf-8?B?NVdZczZIcDg3WC9CMGp5MVNjQm8rTGdQV1pEUnBZYnFGRFdBaHlZRFczWXoy?=
 =?utf-8?B?R3d6eDAwY1o5cmN2WVRWa29vWVBLanZVSGRSVFdTOCswamF1U2NmRXluQ0Zo?=
 =?utf-8?B?VThuUzdETGJLVHBjYmpVRzNkK3JXUEM1eUdKSlJyMnQ0Y3habDROdU9HM1hH?=
 =?utf-8?B?czNheTRRbGlKMStpVU90TUZPemRnbXo2VjJTYmRRckVDSGNHREFIRWN0K0Jy?=
 =?utf-8?B?MTVVUjZmdlNWYndoLzAxL2xXclRzb2J4MkZmNHRlQkxHaW4zYVpZWU53eUNr?=
 =?utf-8?B?eWlJVzlnN0h1bkUvdTdhcXgzNkt1dzBJMlZacVZFamZlcG5GSHZTTlpYeGFK?=
 =?utf-8?B?T2thbFpBaXRISEJ4cUYwcnZrU0d1NVNYMGtVaW5WMlBPMHJMZ1JsMUdjUUdm?=
 =?utf-8?B?T2xVcmp1ZHh1L08veXBVS2JXTnZDMjN5MkhWU2lVMUROTG1Ka1JnR0JZZm9R?=
 =?utf-8?B?aUN0U0VHNVRMNHB5Q1dOYkM5RC9LRWVJa1hkQSt0OTVMbmRPcFJlMVQ5RmNP?=
 =?utf-8?B?NDdlcER1c1dMdW9TbUNMcWlTWFZOUWxvWkkxL3o3R05LdUdYRWlpWllBblZ6?=
 =?utf-8?B?SFhTYy8xTHlmV3dTekFnQkI1T2ZtdlFCQTkxVjBwcXdWQVA1cWNiY3FXSjR5?=
 =?utf-8?B?T1NSdnFSZTRwV280cnFNdk5hYUZTangzUGpLK3ZvNmtzck02WW92WjRlTGYx?=
 =?utf-8?B?ZGpEOUtYeHVXekl4d0ZNNTVKKzVpbzlVb1RreFJzS091T0c3SFZaV2NsRWFK?=
 =?utf-8?B?R05iL0lhMzBCWGREd3BRSExMc0Y2N3A4UFVjWExTdlhZNWFxWlR4WlVoRElK?=
 =?utf-8?B?NktWakYwSDdKRzZCV3VqeG5GSkZra1R0Uk9WbzluNXkydGJldGNnak43bWwy?=
 =?utf-8?B?d2txRWJRelhuSTF5Q2hROVR0bDJlWVRsMFZUdnA2Y3I0ZkZnMjRrVjVLZTBQ?=
 =?utf-8?B?eEh3dGJuSDArY2kxU1FDZ1pNSG5tcUlDMHFaNURWSFNsdEY1RW1aLytoZURp?=
 =?utf-8?B?ZldQSWMyUmtUUTEyQ0N6QVRxTVN5OFBVTDh1blg3S1dXaUtFb1VhUFJQa2w5?=
 =?utf-8?B?K2tUTXowMWJGVmtYeUtWSTh5MnJmczhkck9FbDEyR2hRdXg5RWY2aEZLemtj?=
 =?utf-8?B?Tk9XMU00RElESy93UEFNS3c1VTNVd2d2dXFqd1ZzQTRDSFJRTC91MlRqVGl6?=
 =?utf-8?B?L2xmeWF4WFkydm5Ia0RueXpUV0F4bXNuSXpETDl6WGVHQlhZblJadEtvYjhJ?=
 =?utf-8?B?SHAyQkpCeDN5WHpNblB0dFVpa1Y3MitBdm5zMndaMm1uVjJuU0pIYkhKODAy?=
 =?utf-8?B?VjBod3dDenEzZmtYZlVhNTdnMXo1Tkp6bFhaeFpnODgvNEZjZGp4ODgzUnBW?=
 =?utf-8?Q?Fzdgk+aou9bFPk6eWP/ha4gt5?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	0Vd6dE9gOq2WbJtv92gd4g1muvbW6OIscKHbQ3TIgWMk3IbBrpJqa96gl8JBS6ugFBbwtYva0ZB7LpTwrqRoFH0/DyO0eiLe8lHGtjAflm7uXEmK18O6XFrpVAufOuNE8JGtFSFoRQLZisvoszAyVuLzPPQt64KdgPtQZXhTOkF3BjwC4Lhz90QbhV0oI1wJner0yjTJJ43a6TzpjWPZb7+sWUy0cdOM+7iTbl6CoEBHnKSTi2UtLHmWcoI1aWWx7AcxKrQRhBh41SE8GeP/hpE9dlSrQwnHNw4kS1z2GkPd0+FsIcFetgKbrrPvpZ5p6IId3ejjxK4Tq5H9al4gNo3rWuwOGw/rMUgNlHEOeHc1TzCgRN8HHbjIKRXwLNMEUDavxF8BcYaYGRpsgUONA6kqGDKR9UBF9XHDW7XeuqtfK+AcG4C6SdZ+IeB2aQVcMCAqRl/kB8aR6xZSkzcpRuBDy5IW6Wot/BaR/N/g1f9sG7ty1rZ7kxSsEdzAVOQ4iyEViWi9eeYK9EmmiZSWNq7bobThT7wLttu1M3HxB9YxpV0QH8f66vN+QpK2j0pEE5p59qZiWEZOsfCYRYrJXl70tFvIWw7bsxrHPXWmsO8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee7c1412-0562-4322-3682-08dc6e0acb2a
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4429.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 20:26:21.7977
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C9snlki6QegXjN2+j97MQ7Oeb7TpVvhtUwCO7cSItI8LfLpU22RuKZqMfTZf6kVVBpsgL2c8DZ2PtiJJHEWFSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7558
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-06_14,2024-05-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0
 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2405060148
X-Proofpoint-GUID: mOhfk-OL8uhytkSDWA9Ij2rxyxJ1k11t
X-Proofpoint-ORIG-GUID: mOhfk-OL8uhytkSDWA9Ij2rxyxJ1k11t

On 5/5/2024 12:00 AM, Miaohe Lin wrote:

> On 2024/5/2 7:24, Jane Chu wrote:
>> When handle hwpoison in a GUP longterm pin'ed thp page,
>> try_to_split_thp_page() will fail. And at this point, there is little else
>> the kernel could do except sending a SIGBUS to the user process, thus
>> give it a chance to recover.
>>
>> Signed-off-by: Jane Chu <jane.chu@oracle.com>
> Thanks for your patch. Some comments below.
>
>> ---
>>   mm/memory-failure.c | 36 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 36 insertions(+)
>>
>> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
>> index 7fcf182abb96..67f4d24a98e7 100644
>> --- a/mm/memory-failure.c
>> +++ b/mm/memory-failure.c
>> @@ -2168,6 +2168,37 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags,
>>   	return rc;
>>   }
>>   
>> +/*
>> + * The calling condition is as such: thp split failed, page might have
>> + * been GUP longterm pinned, not much can be done for recovery.
>> + * But a SIGBUS should be delivered with vaddr provided so that the user
>> + * application has a chance to recover. Also, application processes'
>> + * election for MCE early killed will be honored.
>> + */
>> +static int kill_procs_now(struct page *p, unsigned long pfn, int flags,
>> +			struct page *hpage)
>> +{
>> +	struct folio *folio = page_folio(hpage);
>> +	LIST_HEAD(tokill);
>> +	int res = -EHWPOISON;
>> +
>> +	/* deal with user pages only */
>> +	if (PageReserved(p) || PageSlab(p) || PageTable(p) || PageOffline(p))
>> +		res = -EBUSY;
>> +	if (!(PageLRU(hpage) || PageHuge(p)))
>> +		res = -EBUSY;
> Above checks seems unneeded. We already know it's thp?

Agreed.

I  lifted these checks from hwpoison_user_mapping() with a hope to make 
kill_procs_now() more generic,

such as, potentially replacing kill_accessing_processes() for 
re-accessing hwpoisoned page.

But I backed out at last, due to concerns that my tests might not have 
covered sufficient number of scenarios.

>
>> +
>> +	if (res == -EHWPOISON) {
>> +		collect_procs(folio, p, &tokill, flags & MF_ACTION_REQUIRED);
>> +		kill_procs(&tokill, true, pfn, flags);
>> +	}
>> +
>> +	if (flags & MF_COUNT_INCREASED)
>> +		put_page(p);
> This if block is broken. put_page() has been done when try_to_split_thp_page() fails?

put_page() has not been done if try_to_split_thp_page() fails, and I 
think it should.

I will revise the code so that put_page() is called regardless 
MF_ACTION_REQUIRED is set or not.

>
>> +
> action_result is missing?

Indeed,  action_result() isn't always called, referring to the 
re-accessing hwpoison scenarios.

In this case, I think the reason  is that, we just killed the process 
and there is nothing

else to do or to report.

>
>> +	return res;
>> +}
>> +
>>   /**
>>    * memory_failure - Handle memory failure of a page.
>>    * @pfn: Page Number of the corrupted page
>> @@ -2297,6 +2328,11 @@ int memory_failure(unsigned long pfn, int flags)
>>   		 */
>>   		SetPageHasHWPoisoned(hpage);
>>   		if (try_to_split_thp_page(p) < 0) {
> Should hwpoison_filter() be called in this case?
Yes, it should. I will add the hwpoison_filter check.
>
>> +			if (flags & MF_ACTION_REQUIRED) {
>> +				pr_err("%#lx: thp split failed\n", pfn);
>> +				res = kill_procs_now(p, pfn, flags, hpage);
> Can we use hwpoison_user_mappings() directly here?

I thought about using hwpoison_user_mappings() with an extra flag, but 
gave up in the end.

Because most of the code there are not needed, such as the checks you 
mentioned above,

and umapping etc.

thanks!

-jane

>
> Thanks.
> .
>
>> +				goto unlock_mutex;
>> +			}
>>   			res = action_result(pfn, MF_MSG_UNSPLIT_THP, MF_IGNORED);
>>   			goto unlock_mutex;
>>   		}
>>