Received-SPF: pass (google.com: domain of linux-kernel+bounces-170409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: <Woojung.Huh@microchip.com>
To: <o.rempel@pengutronix.de>, <davem@davemloft.net>, <andrew@lunn.ch>,
	<edumazet@google.com>, <f.fainelli@gmail.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <olteanv@gmail.com>, <Arun.Ramadoss@microchip.com>
CC: <kernel@pengutronix.de>, <linux-kernel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <UNGLinuxDriver@microchip.com>,
	<dsahern@kernel.org>, <horms@kernel.org>, <willemb@google.com>, <san@skov.dk>
Subject: RE: [PATCH net-next v7 02/12] net: dsa: microchip: add IPV
 information support
Thread-Topic: [PATCH net-next v7 02/12] net: dsa: microchip: add IPV
 information support
Thread-Index: AQHanVvYOrS/w3MF/UCWVV5PJclUi7GKpGpQ
Date: Mon, 6 May 2024 20:43:48 +0000
Message-ID: <BL0PR11MB29131C40E4B39B119F9891C2E71C2@BL0PR11MB2913.namprd11.prod.outlook.com>
References: <20240503131351.1969097-1-o.rempel@pengutronix.de>
 <20240503131351.1969097-3-o.rempel@pengutronix.de>
In-Reply-To: <20240503131351.1969097-3-o.rempel@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ZixoYwVfCUYYxtS2ZzdeDBI89MnwrgsYhrxfL/V4N6d5XPCh5/ADdWq1IL?=
 =?iso-8859-1?Q?4pdR9t5aCpMk+FaakdYmCYmnW1Yl0TYYLLmC5UhLkwP3CJkg8pJMzDzdBL?=
 =?iso-8859-1?Q?Ru9vWaDH/utLqPorQ405Am/wiLyajto9C7wQqS+hsiX4SpiIj/TsVUWufu?=
 =?iso-8859-1?Q?YAQ9IYEEN6oGu0U4dnqfQyK5Smxk/Sg8YI8CbkhQ/OJYSDJE+y4B7HJM1j?=
 =?iso-8859-1?Q?qGXdpjVysyQ/USf9GP5JTwWCU2/c3Wua+eWIbJbE4UKtj6pkKjvYMyMWcs?=
 =?iso-8859-1?Q?WF6oH89JhLhcRP1ki9cK/pB2t+XZuddK1vHC+l67+S9HKuFjzxaPpqSNnM?=
 =?iso-8859-1?Q?dbIbBH6AdiG4P288qmnebfjsUbqGTGN5ghDaZW6OHiajIHl3zF4iJEIL+3?=
 =?iso-8859-1?Q?IGUTe4Utmd36QpY5S5S4X0VGwtdHk2yGsihks4b5GNeI+Dt6Z57txyfrgS?=
 =?iso-8859-1?Q?DDhsFsUfFTrAfYKDvKVq51//YOyf2HxX1p542qnMOoFoH4a76alL4G1fDs?=
 =?iso-8859-1?Q?pm0dRjI0TA2HDT7aBjpo+B8vRtLN3k+N9gx92UB0I7EWtt5gRwaF+wmhbU?=
 =?iso-8859-1?Q?U/TQPxaLYfmpAWtxSVogiTmvAAfkX1c7JmOY7FY3hcBkIy2ihb23bc8ImJ?=
 =?iso-8859-1?Q?jVWEHP6TB+mmkhk1if2vYYBkZM68Z5Pd2souM8/TcinkzQYyRjM9soLseT?=
 =?iso-8859-1?Q?nCKQeljjwijfuYTB63hnAbEgQZeBizbigBox7ZvcCvkpOIGpPCuEPHjUhc?=
 =?iso-8859-1?Q?za9aOiocRQXGvNZ/Q7wHZSqM9kc3oZRxSgd19pZCrDwTKIlaygfCdbs+5+?=
 =?iso-8859-1?Q?1YP9k7ILbOrVmKKgQ9G5bezXQSE3hmhszRlIitrWLZOXGlLLzFcaSZC7gq?=
 =?iso-8859-1?Q?ol5tvZP1wUbsM7+YWI779mZ8+urhMECG51sPDgMEOIV4DVgUfCkyJjzel0?=
 =?iso-8859-1?Q?UPB+gKwO+bAKWdpi70k7N0UNF00GdVV/gGEoaMlC/brHjziKZhbJxb+fMu?=
 =?iso-8859-1?Q?a+EqiBb4dCa0d1nC0LHaw9Wx9kS4TO6CiOKwiSTEO+162HiKIKF6iX3Q0I?=
 =?iso-8859-1?Q?nwvs7E+cwvFMI3kl3Ol2R8m5MwTzUn8IVS53VhJSDLWEQdDRm/4pksrh/r?=
 =?iso-8859-1?Q?ZmNEBlh074OoQw9XUzz47XCgpWtxLvCn0tFkwK3ov1n8AEk9aS1u4TPOCP?=
 =?iso-8859-1?Q?WdQ0l4YsSWBJ/G0FzW4eL7U8LYOERTERpkzTCIc6y+sJpMuXNg0NmBZAy8?=
 =?iso-8859-1?Q?QI0W3pivBejF2r14wUIzKwyz932GGW667IsgJctkfCDo2qsowG+oTlSo1d?=
 =?iso-8859-1?Q?LHZiAI65fV1yeiK6C/epfXw9TZMaiN6rFpSe+/UkXpu/OP1HLDfppOpUXk?=
 =?iso-8859-1?Q?zgS26r3XG8TmowA/QT+GQJ9TpucNAmg5LglIwuSyNWSYs3LUEIKMn83y7b?=
 =?iso-8859-1?Q?l8tRX37kFgoCDEddI5/ub/JG5st3tmC03TypxBOzz5lYOZ9lb28zSIX3An?=
 =?iso-8859-1?Q?L8tIMSKeqrz4ABmJMzURxSbJgkrJUoXhuinzl75dY7SJOuKui8lsrRNHm6?=
 =?iso-8859-1?Q?jZKJv0lG4SUh/dh5I9WHJRk6srs2MvmJxQH1n8509ofi8ktBbB/Jv7seZQ?=
 =?iso-8859-1?Q?hKmyXkHWfI8hjveUKYfsaSsQVpQeOIGoqP?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB2913.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e025bd0f-8a8c-4d56-0861-08dc6e0d3b4b
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 May 2024 20:43:48.7817
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XR+iNr0pf1xRN+awq7I1LTAzX2RPqHpqT3ny4Dds7EUEvyb/j6IZszSB39t1tIOaNPgvxbQXaBOdigTAMLEkY05te0YO3/ahlTIk8SO8x8k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7026

Hi Oleksij,

Thanks for the patch and sorry about late comment on this.

I have a comment on the name of IPV (Internal Priority Value)
IPV is added and used term in 802.1Qci PSFP
(https://ieeexplore.ieee.org/document/8064221) and, merged into 802.1Q (fro=
m 802.1Q-2018)
for another functions.=20

Even it does similar operation holding temporal priority value internally (=
as it is named),
because KSZ datasheet doesn't use the term of IPV (Internal Priority Value)=
 and
avoiding any confusion later when PSFP is in the Linux world,
I would like to recommend a different name such as IPM (Internal Priority M=
apping) than IPV.

How do you think?

Best regards,
Woojung


> Most of Microchip KSZ switches use Internal Priority Value associated
> with every frame. For example, it is possible to map any VLAN PCP or
> DSCP value to IPV and at the end, map IPV to a queue.
>=20
> Since amount of IPVs is not equal to amount of queues, add this
> information and make use of it in some functions.
>=20
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> ---
> changes v3:
> - rename max_ipvs to num_ipvs
> - drop comparison of num_tx_queues and num_ipvs. It makes no much sense.
> ---