Received-SPF: pass (google.com: domain of linux-kernel+bounces-170415-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e1b142bc-50e4-4117-945a-7d74dad763d8@oracle.com>
Date: Mon, 6 May 2024 15:52:12 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi:iscsi: Remove unused list 'connlist_err'
To: linux@treblig.org, James.Bottomley@HansenPartnership.com
Cc: linux-kernel@vger.kernel.org, open-iscsi@googlegroups.com,
        linux-scsi@vger.kernel.org
References: <20240503232309.152320-1-linux@treblig.org>
Content-Language: en-US
From: Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20240503232309.152320-1-linux@treblig.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?L0ZRS0k2QmlrYXl3Q1FIQnduamVmc2hDNG5mY01wdk5RTXNhcGpiWDY0d3Bs?=
 =?utf-8?B?b2xxdHVpR216aXNzTnhJNU03MWY1STlZL05pbmg2V3Y1R0tnQk1wOTNpTkZ1?=
 =?utf-8?B?VldHYXR5YzkxQmgvVGkxQmhZbDkxbTZIK2pjb3BXSFVOeWxCZGtBVEgzbTJS?=
 =?utf-8?B?Uk04RFhFUjBnMEZocjdkeEVJM3NmN0xYaXRTREIxZ1ptdEx4S25kbGVUbmoz?=
 =?utf-8?B?NkErcXJrM01FdmRTVU0rdlpnL2g2R25CL2ZNd3BybXBDMEVCcHZVNnJLejBJ?=
 =?utf-8?B?TmdoVUs5YTNNL1phaXhVQktKRFJPaWp1NWN2eDdQZ3FmUUMxbnBvZHpyL1hi?=
 =?utf-8?B?bXl3WFdCcG54RjhTT3Ivc0loYnpPTGUzSHh3NHlWMXV6ZXhIU2Jpb2JpY3Uw?=
 =?utf-8?B?VERzNVZ6RTFJRXFCOXgrTEpReHc4VnY2YUl5K3JNOENRTGI4VUFPYTF4Zisv?=
 =?utf-8?B?ZHZscmF6anZiQlI1YStiUUx3aW9BQnRSS3pkOWVRZXppMW56K3Fody9wbDYv?=
 =?utf-8?B?MFN0ekZCV3RIYms0bXlybE9WYXVWVGJrQVQwMlVuQVVZTE9MMUJBMW1lTW42?=
 =?utf-8?B?dkpvMm5Dc0ZvV3pxQkF3RlpyQ0NvdzdTalJseGlFYzFsclluV0dsK05pdnRN?=
 =?utf-8?B?RkYvVGgyK0VqNkN2dGNOY2wvbXgvdnB4NUR4aUVBUm9YL3B2UTV1OEppSzZN?=
 =?utf-8?B?ZU5JdzM3QlQ3QXdnaXhYeVZLZnRnYTFVeE1oWTNMeElGM2RyNElqNzQ2MGJq?=
 =?utf-8?B?ZmJxNCt1V2VMUW5jWDJJK0xCYlN1NzhES3lxc0U5d29sOGdkRitJZjlBVDBy?=
 =?utf-8?B?Qm9iSXhZamtYOU9zcHQ3bjBkekNzRHF1S2E1OTNCYmJCYkVaRmF3S2NKSVpI?=
 =?utf-8?B?dnpyWFc4OTF3dDZKMmkxdENkenl3RHlleTIwUXJaZGNxWk8vU3Y5cmVoMHl4?=
 =?utf-8?B?SXdqbkhLS2ZrNzlZMkpieE5wWVhKRUFvcU9ZZi8zekV0cGg0QWwxNDhncVRI?=
 =?utf-8?B?c0I2MW9RS1BteHJudXZTSXlPOWpFalp4VmVoazVLbTJ3ak5yZ1FkNGptamtV?=
 =?utf-8?B?U2lkWmRWbTZGak1MVE1kZmluS0NuVmxOTUVkT2szY0kva3N3QlRNYy9pWUtt?=
 =?utf-8?B?RVlKSlh0TlpZaTJFbnFTSjRodFZSVElpZk9VYlRjL1lKZGhMV2o1RTRhc3JH?=
 =?utf-8?B?VDdCMVMvTnJwQVAycXJWWSs0Q1I0ZFBTenZwZzczTFZmSUV0dy85aWpTMTBD?=
 =?utf-8?B?S09hY3VBTTFHTzhQeS9XaGxzZ2lTK0JyR29GN1NBVUxyb2RubWY5SlRUanZt?=
 =?utf-8?B?bmNmY3JuRmMvYlJoRjdaRnpDQWJCM3R4YVFqcmRoMC9ZOUgxaDFSRlV1MGp4?=
 =?utf-8?B?ZVdSSk1UZmJWN042WWV0a1RleXpmU0J1Ymd2QXRWaDE2bU9BM2J6bnZ4MkdF?=
 =?utf-8?B?WWFNR0JpaDZ2YlVrNERhNWc2UnpuN0JaSEdXeUMrRTBNa1djcHUvLzV0QThm?=
 =?utf-8?B?SXVDMmVya29wd0RmMnZ1MUhGN3VQaEFmOTJsSnZ4WExiM2s4K284MGpNbFdv?=
 =?utf-8?B?SjdBOGRhSVZ2MlpKTDl6STFFOWNnNDh0UEdWWDdXcHgrMjlTbGFtSlZ6U1hw?=
 =?utf-8?B?WmtMWjZxOEJlV09NajBpQy9LKzBjdGdPYVRxQ3JlY00yV3V3Y3R6amxDWmZn?=
 =?utf-8?B?UUkzRCtqcjVzTFJKNVo0djBWMnVac3NHQThlbGF3K0o1bGtubzRDWE4xbUlj?=
 =?utf-8?B?K2l0VmdiaEZnemR5Nmd1eHg1aHd5V1RtUldQYm4xUDJQYXQ4Q1NPK2J6OWdP?=
 =?utf-8?B?S2MrZTE3MitJd01NbzdyTWlmeGdKcjdlakt4eHZkN2lPUEU2N3gxVWxJQW1Z?=
 =?utf-8?B?SkV6bkcySDlWaThZTk5tbHVjTCtsU1NkdXRzN3hNS0Via09TOWVYb2pmcHFY?=
 =?utf-8?B?a2JpQWhQZWtHdm1ocVA3dG5vdmxjRE5PYlFGcVgrTUdaSXhVeVhER2kwODlz?=
 =?utf-8?B?TTN6QXJ0TjZwbHVRL1BuZnozeDVzSU4zc3BlZmxQeDFYVFZMSWNCbXBkaFgw?=
 =?utf-8?B?K0VwQTcwNGlvajZKMzA0YTRoRUZDV1R1S1BMTnNncUx2NFJJbHlXZVkrVDkw?=
 =?utf-8?B?U0RVNVg2Nk5nMmRWdEhmL2Y5NExmYjhEcTJFRVdHaUFnWVF2cVpJclAyaVZH?=
 =?utf-8?B?ZlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	TWjIKUWyoX5km9E5QWKa5ENJyoeMtg4a3RQCHQI7ORzni6J6T2Z49AnoOf0ZMHVLEpTBZFbP88Z8dreRlCm08Dp/pmEX3UPZrQ1IQvr5tQHFutnAemWV1v/CVL9F9PmwrcbyWPbuOIPhQ2Ngf8FBlf4D32iAFExlxOPodmzR0mgCUWg0O0SgpfaRCiSXgRILMeDMEO1TYgwIfD2mO/JVZLoOZk9mLdASxJzHyjNVHKudqmpJSGQvjXCtX/qkjrQWl52/UR5j/6/p3aSUDePzk+6bjN8F8Mh7d/ra7Rz4kbbx81kN4cVfmFFZPNEX02ZNngDyDjYTW+MFC/FeqjrSJ1GEs8OAi3HKzh6gXrWp0kV97YvBXD7Dr/z7T2n1Fe/zTARG6KsDPqwkhcyR+CVrEPDN8b12xQ1nIuZnVrqv4vNFPK67gUCfyVQcv/GTwQEjJm/X8DxyNWIlVawoS8Si6Ua6xCELxjfk10GfFZ4+4u0HJNPjj+Xj/wwsvXiP7pRs3LEapx0RN95DXLz7Lwi0oK7h489bg0A3lqFk7EWSoMulvrf8XMgSofi/vZtzKj77Ya1tZZGRcdC/OEbM413MNj4PzwUzJSYQa7bGODi6FE8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cde35632-a8fa-404a-c7b7-08dc6e0e684e
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 20:52:13.9967
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tNVdNNDPm1XNACqhQFOGMs1wkuh7fvwiLCaDYTnMzqtgmzSs7msbvx1CEIxOTnpm1GzVUwLYI+WXFHS9dKf80Owu6EUg/i6NdhWqPMcw+GM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7128
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-06_15,2024-05-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2405060151
X-Proofpoint-GUID: KLAy3FmqToG25Q-CddewcH3x_cHZahxy
X-Proofpoint-ORIG-GUID: KLAy3FmqToG25Q-CddewcH3x_cHZahxy

On 5/3/24 6:23 PM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> I think the last use of this list was removed by
>   commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
> handling").
> 
> Build tested only.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/scsi/scsi_transport_iscsi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index af3ac6346796b..123b861d2a9fb 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -1603,7 +1603,6 @@ static DEFINE_MUTEX(rx_queue_mutex);
>  static LIST_HEAD(sesslist);
>  static DEFINE_SPINLOCK(sesslock);
>  static LIST_HEAD(connlist);
> -static LIST_HEAD(connlist_err);
>  static DEFINE_SPINLOCK(connlock);
>  
>  static uint32_t iscsi_conn_get_sid(struct iscsi_cls_conn *conn)

Reviewed-by: Mike Christie <michael.christie@oracle.com>