Received-SPF: pass (google.com: domain of linux-kernel+bounces-170419-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PATCH net] selftests/bpf: fix pointer arithmetic in
 test_xdp_do_redirect
From: patchwork-bot+netdevbpf@kernel.org
Message-Id: 
 <171502922848.22261.11157218747353339667.git-patchwork-notify@kernel.org>
Date: Mon, 06 May 2024 21:00:28 +0000
References: <20240506145023.214248-1-mschmidt@redhat.com>
In-Reply-To: <20240506145023.214248-1-mschmidt@redhat.com>
To: Michal Schmidt <mschmidt@redhat.com>
Cc: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net,
 kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com,
 andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
 yonghong.song@linux.dev, kpsingh@kernel.org, sdf@google.com,
 haoluo@google.com, jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org,
 aleksander.lobakin@intel.com, toke@redhat.com, netdev@vger.kernel.org,
 bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:

On Mon,  6 May 2024 16:50:22 +0200 you wrote:
> Cast operation has a higher precedence than addition. The code here
> wants to zero the 2nd half of the 64-bit metadata, but due to a pointer
> arithmetic mistake, it writes the zero at offset 16 instead.
> 
> Just adding parentheses around "data + 4" would fix this, but I think
> this will be slightly better readable with array syntax.
> 
> [...]

Here is the summary with links:
  - [net] selftests/bpf: fix pointer arithmetic in test_xdp_do_redirect
    https://git.kernel.org/bpf/bpf-next/c/e549b39a0ab8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html