Received-SPF: pass (google.com: domain of linux-kernel+bounces-170429-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 6 May 2024 17:10:59 -0400
From: Benjamin Marzinski <bmarzins@redhat.com>
To: Joel Colledge <joel.colledge@linbit.com>
Cc: Christian Loehle <christian.loehle@arm.com>, dm-devel@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] dm-delay: fix hung task introduced by kthread mode
Message-ID: <ZjlHY02it0wBL0TB@redhat.com>
References: <20240506072523.399767-1-joel.colledge@linbit.com>
 <20240506072523.399767-2-joel.colledge@linbit.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240506072523.399767-2-joel.colledge@linbit.com>

On Mon, May 06, 2024 at 09:25:23AM +0200, Joel Colledge wrote:
> If the worker thread is not woken due to a bio, then it is not woken at
> all. This causes the hung task check to trigger. This occurs, for
> instance, when no bios are submitted. Also when a delay of 0 is
> configured, delay_bio() returns without waking the worker.
> 
> Prevent the hung task check from triggering by creating the thread with
> kthread_run() instead of using kthread_create() directly.
> 
> Fixes: 70bbeb29fab0 ("dm delay: for short delays, use kthread instead of timers and wq")
> Signed-off-by: Joel Colledge <joel.colledge@linbit.com>

Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>