Received-SPF: pass (google.com: domain of linux-kernel+bounces-170430-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 6 May 2024 23:11:31 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
cc: Chen Ni <nichen@iscas.ac.cn>, bentiss@kernel.org, even.xu@intel.com, 
    lixu.zhang@intel.com, kai.heng.feng@canonical.com, hongyan.song@intel.com, 
    linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: ipc: Add check for
 pci_alloc_irq_vectors
In-Reply-To: <95fadbf4772d575bff777ddb738cb6c25b85b779.camel@linux.intel.com>
Message-ID: <nycvar.YFH.7.76.2405062311100.16865@cbobk.fhfr.pm>
References: <20240429085422.2434036-1-nichen@iscas.ac.cn> <95fadbf4772d575bff777ddb738cb6c25b85b779.camel@linux.intel.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Thu, 2 May 2024, srinivas pandruvada wrote:

> On Mon, 2024-04-29 at 16:54 +0800, Chen Ni wrote:
> > Add check for the return value of pci_alloc_irq_vectors() and return
> > the error if it fails in order to catch the error.
> > 
> You can write as
> "
> Add a check for the return value of pci_alloc_irq_vectors() and return
> error if it fails.
> "

Srinivas,

my understanding is that with the changelog rewroding this patch has your 
Ack?

Thanks,

-- 
Jiri Kosina
SUSE Labs