Received-SPF: pass (google.com: domain of linux-kernel+bounces-170437-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 6 May 2024 23:25:12 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: Allan Sandfeld Jensen <kde@carewolf.com>
cc: lains@riseup.net, hadess@hadess.net, benjamin.tissoires@redhat.com, 
    linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, 
    Allan Sandfeld Jensen <allan.jensen@qt.io>
Subject: Re: [PATCH] Add Logitech HID++ devices
In-Reply-To: <20240424113130.60386-1-kde@carewolf.com>
Message-ID: <nycvar.YFH.7.76.2405062323420.16865@cbobk.fhfr.pm>
References: <20240424113130.60386-1-kde@carewolf.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 24 Apr 2024, kde@carewolf.com wrote:

> From: Allan Sandfeld Jensen <allan.jensen@qt.io>
> 
> Adds a few recognized Logitech HID++ capable mice over USB and Bluetooth
> 
> Signed-off-by: Allan Sandfeld Jensen <kde@carewolf.com>

Thanks for the patch!

Two nits:

- the shortlog (subject) of the patch didn't really follow the pattern we 
  are using in HID subsystem. I have fixed it, but please take care of 
  that in your next submissions.

- the patch was against some old version of the code, so it didn't apply
  cleanly (more entries are now present in hidpp_devices[]). I've fixed 
  that manually, please cross-check the end result in the git branch

Thanks,

-- 
Jiri Kosina
SUSE Labs