Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp150776lqh; Mon, 6 May 2024 14:28:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVa7mW8p7ZU3KtL6CD4IO1FPeefWG3ofwzzptNAprsuCOvXbGfV90YUtd9tONJE7CrQy7SKuIa+a/imUNpd5On1mPPpu6oEK0zH644O3Q== X-Google-Smtp-Source: AGHT+IE+JNQEhgWifnQiydtPdXj0NcIN9nrjsYp68bBZLmbZrqZQEvIix4TtTQP10ejkNxOBPoaP X-Received: by 2002:a05:6358:5912:b0:192:3eeb:d0a4 with SMTP id g18-20020a056358591200b001923eebd0a4mr1622994rwf.14.1715030917959; Mon, 06 May 2024 14:28:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715030917; cv=pass; d=google.com; s=arc-20160816; b=M2jyOuNwmeUvOBpjo9YVGorwLEG0DyTRXZQy1xu5HNoA3kgco8cC8emBranFBXjUOJ RMiv6eQtXoDDZRwkd/JJRwGWvmYfBY94tCsB/6MCAij+NNLDpwIsAkYYyEQsH52VHKOJ sQ8taChEAVU15Ey8OX/cXJTOltCImOvYlQcuuIaCiv1+P4TJHo9e7QfJmPIzlYpiFjIr jkyS0MDjPKpYnR4qDjethL3sxpoLAyjLcN27YuMc5GMZtm/7GywoIirpeGCKiBotwyz+ /28nqLECj56JIXYaqsYccKKlQ/M2IHxlvl+zvn4B9EGil5aV5wVTnzkZIbW3vf0ZaDNK VRXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=BUulxJtJH/9IijJto8S3LvIg0Eeu3yNlcTggINLr4kE=; fh=/sB8mEui+2Pi84RmW4XUanJaQ7KM31NfFk00d+JSSwo=; b=vyqd/Mo+pS3V6pgIHg9mcpqZIjtSvBXeZWLJImoCVxlfbXj2l/ZH2fd5DroYckG/hS uawh50+M7J3AK415MZfsc6mR8oezI2uer4KgLZloLIQHcxA9cOgSRDEvrXoZ7CRfjQGr TOdx7d0DvK1pcYYLYxfgck2PPTOsjwQ+I/s1zv/9JReqv7u9/BQ86WPeqAU1LJ5Hy9Iy BYX7xw0XlivuSFm6HMG5KB4SLIuY9PJBovzMVbnk1NhHRRGfeK1THWHokzVHzok6WAoa cQwnrjgGMe/iTG5xc/ASd7pDgunA2lCdU+EyFmXxl5GykFHqhZZTKf6I6p8Vq+BFOQAD gThA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TRVkSZF4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170441-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id i3-20020a63cd03000000b005dc4ec48cbesi8884736pgg.827.2024.05.06.14.28.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 14:28:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TRVkSZF4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170441-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 87DFB283C77 for ; Mon, 6 May 2024 21:28:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3962E15B986; Mon, 6 May 2024 21:28:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TRVkSZF4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 602DAEBB; Mon, 6 May 2024 21:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715030910; cv=none; b=fHGM3qkQB/uBXlEktwTP71i7eUDGZnT0btTv0iJ48FAiKjQAYxgYBgzk3L5UgK0WnXgJKIbODX9T8bwBDG/Kk336S6VzpKxGqomyDA0DEMP/dH+JSE/jZ2INjTD4vRi5GpS2Zdx4kGfsVtRfPiM6UVu1+FJlrK00G6BD08y8z0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715030910; c=relaxed/simple; bh=JA7evhWLJ0IZ4zTkJf05xGBiQ8YPkHnZLXlcFVlni7w=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=eEQ1kmTa/m4VMPh2ob9IAn8NtVtnfMbb3WttHvkdAPoDhCAQXs++TOOvBYZ1eMHlk1IJiOkojh2kjPX/FWfNzTwcaqsien25YQn9AINlo1lYmr9mlubkE/Sbyuyfv2YhhXlTwz/b9tRbb8iZKFurH9q3aHc2JpK91pinjvrZbKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TRVkSZF4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59602C116B1; Mon, 6 May 2024 21:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715030909; bh=JA7evhWLJ0IZ4zTkJf05xGBiQ8YPkHnZLXlcFVlni7w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TRVkSZF4kcolQMYOiDSpr+qCzH4NnNEIuxWXtmMbfte6FQtEWSLtEy2VmA44IfkGI Aft5AG1IjlkJtVGcl8eGgmtstiCB70Y+AsqcUjlfMnLbPO8iDtZZZ2DQR2CIpvOUTu wE5EsCKiWZV8Rrh159QeRSPm2wGaIBdcTOl/BJRq71UpBlaYqZUomXytkbmTM+esrf Ettu0iO/JWyd15W1z3PrfCDFwtBDjIOIde7ZKc+g3gXHDAmJHXp5f4FpUqwgzeU2VZ poI6x2n0rbCfnVABHiT1gZUsAjmpjQcWCv8N0CBr1r4Kv9OruUWG8n0GX/5s0cswlq JYNp7s+K3BlzA== Date: Mon, 6 May 2024 23:28:27 +0200 (CEST) From: Jiri Kosina To: Kenny Levinsen cc: Dmitry Torokhov , Benjamin Tissoires , Douglas Anderson , Hans de Goede , Maxime Ripard , Kai-Heng Feng , Johan Hovold , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Lukasz Majczak Subject: Re: [PATCH 0/2] HID: i2c-hid: Unify device wake-up logic In-Reply-To: <20240429233924.6453-1-kl@kl.wtf> Message-ID: References: <20240429233924.6453-1-kl@kl.wtf> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 30 Apr 2024, Kenny Levinsen wrote: > Third time was not the charm[0]. After Dmitry's comment[1], and after > looking some more at the I2C drivers, I have given up on removing the > smbus probe for now. We can always revisit this later if the situation > improves enough, but there are more important things to fix. > > Instead, go all in on the address probe with retry and use it for both > initial probe and resume, replacing the previous retry on power on > commands. This gives us consistency and a single place to update and > document. > > [0]: https://lore.kernel.org/all/20240426225739.2166-1-kl@kl.wtf/ > [1]: https://lore.kernel.org/all/ZixvUNooESC02cJK@google.com/ I really apologize for belated response to all this, I've been completely swamped for the past two weeks. This is now queued in hid.git#for-6.10/i2c-hid. Thanks, -- Jiri Kosina SUSE Labs