Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp152500lqh; Mon, 6 May 2024 14:32:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW8KVHSZ5RFb5HIemBcZMAYWRIEGCapI5CTdCu792eXamS81wd5ZTE74qrs6M7RDQlJ6t0PdyM2md7YHhZbJTEkz9rwt3yDfjw46Vgi3g== X-Google-Smtp-Source: AGHT+IFQ1g1dQdZ9AzJEE4lqZ69elEruMCpWv38pUaQXlMYmdH1/AMjxX9uvo/vYsssK6NRXfhgv X-Received: by 2002:a05:6359:411d:b0:18d:6d87:be2c with SMTP id kh29-20020a056359411d00b0018d6d87be2cmr9985210rwc.7.1715031144378; Mon, 06 May 2024 14:32:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715031144; cv=pass; d=google.com; s=arc-20160816; b=IEsITRL25LuFR9LfbxtI5fXtjp3iknPf7XvBzDDUCSu5rG+5+52QZA9fgriwbIHrbY /lw4ufd6W2bqtHb2W9g8avZPLOOIo/SBxm7xbTmm2rufRUuIBcnJm8VeUZHdcMclQNfZ 0IPf55Ce2ENH6vdRQ9qxSGc4+uEpLzTXVQahVhIwqXb8dYAmq2NivgiVA6LxunUWoq6H g9YLuQUTPrxqaGbHeB69v1HPQzO0anK+KUng7vyYoWvkkYG3Pz0lSlPANRydTmh1XPAP +c+Y4htQL6wiNjYnVqg4Cr4GWaUgN1GNCMsYeHbyVXIiNvJnPH+8ywcN6a9rCLsBKA4F 3qXg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=ELpWrLd7cKdn5KXvwhvdLzoR6yT4I7AnXeu5H3iuWwU=; fh=MSF9Gpun6xJBWaXToD5Brtt1cByQUpvBoviPSALQ8DU=; b=U9JjfLMr+Cw4PUj+WmssrcYGV5bEwVR0Oqe/wkF7SoNkeWirSBvHnhOsqhRjGkf/sU LqJ3I9XWAkIsW0aPloHDUQwHxd+vMEbBPyuNly/BHL3xoyLIvQb47ndHLIF3YW0Tutd3 AKbTossB58onhD2uYLo0WxXZs9Sp8co/2ZdHDw0/+Xyyt2ykuHqcmbJhmD9zDj1zzW7M 24SZ7sOQK4MrY9vn/hHvRlR8dF+UvP3EvamVXt60Fm4jfNYmd5T41RLYMcjXtKrcKE5o lHPur2ec1BfOfHwtRCrbrZGKbYsdpuKbSLrxf9BRZ7LINGeAsuxkf5/8bwvzBFyGlLKi PnQA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VGRWUeZG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170446-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170446-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id f13-20020a63554d000000b0061afbfee29csi8704264pgm.726.2024.05.06.14.32.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 14:32:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170446-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VGRWUeZG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170446-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170446-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E671128177F for ; Mon, 6 May 2024 21:32:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D810B15B98D; Mon, 6 May 2024 21:32:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VGRWUeZG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0931415B0FC; Mon, 6 May 2024 21:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715031137; cv=none; b=hW4tJLIhrkSEgueS3hBQkgy+KZ+sIMBMYWY2aUwiJpPhzrF317z6g2Ym0DN9dzC04gcHWMtSg8ZVoQhbCMGQKj5PnyiI7eJxbB2V71y4XnpjWTnh0wOgZ8LS0x4faZgs9CwsG4wY1f0kgMZ+XcSdK7zEkW2Jb7ANeuai0TZcbzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715031137; c=relaxed/simple; bh=Ewip+AdAKCpL4v6StD/FXI4OK0nqlbKX8uj894inBtc=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=FSXCAJwqGyOVcFAJQm5ohK01XKJ1CwsqvUj2EXhwwb841XVbBpY+puk6Sr+CYB1swgqC2rUJxIVi3vFDuKI6HccTJnWlPH4FbMPExQb2ethsCX3KIKgPXineTzFHeK/tzg+QjSjTmxDVWeFpC0pEc3W1MCFudicnXFZ2QhDFRtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VGRWUeZG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40011C116B1; Mon, 6 May 2024 21:32:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715031136; bh=Ewip+AdAKCpL4v6StD/FXI4OK0nqlbKX8uj894inBtc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VGRWUeZGEieljxvi+vrdndEw7/2Q9zUlEvC4hN/1zVH1CU5gESL/bPGOp1BCES5yF 8ZY4y7L9pVWvfqZPrtMJKFz9vkKcNpiwYoXnyaKQ40zZUgBh+1hUVtQFTLaCGUrw/W 6hGlRUrS6m9YS1wKG6AoqwK4VE9j6VTX0FW/eJte7tYYx827lw8ZAr8VvDKl9PCfwr l8v5VzfgoyUv5I164JvfSuQzNTjHPvGe5k6UZOJXhVIE5L90bblOLtEhGdNfRTjL76 w/2DnBAqFmICUFQ9F2YEqEir/Trc2zpYC4+p06zUVRD9/KPiu1/sex2SUFQFi1Orwc 9OBoZG8Lj33oQ== Date: Mon, 6 May 2024 23:32:14 +0200 (CEST) From: Jiri Kosina To: Max Staudt cc: Roderick Colenbrander , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] HID: playstation: DS4: Fix calibration workaround for clone devices In-Reply-To: <20240504165531.21315-1-max@enpas.org> Message-ID: References: <20240504165531.21315-1-max@enpas.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sun, 5 May 2024, Max Staudt wrote: > The logic in dualshock4_get_calibration_data() used uninitialised data > in case of a failed kzalloc() for the transfer buffer. Good catch, this completely escaped my attention during review. > > The solution is to group all business logic and all sanity checks > together, and jump only to the latter in case of an error. > While we're at it, factor out the axes' labelling, since it must happen > either way for input_report_abs() to succeed later on. > > Thanks to Dan Carpenter for the Smatch static checker warning. > > Fixes: a48a7cd85f55 ("HID: playstation: DS4: Don't fail on calibration data request") > Signed-off-by: Max Staudt Now queued on top of the for-6.10/playstation pile in hid.git. Thanks, -- Jiri Kosina SUSE Labs