Received-SPF: pass (google.com: domain of linux-kernel+bounces-170446-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 6 May 2024 23:32:14 +0200 (CEST)
From: Jiri Kosina <jikos@kernel.org>
To: Max Staudt <max@enpas.org>
cc: Roderick Colenbrander <roderick.colenbrander@sony.com>, 
    Benjamin Tissoires <benjamin.tissoires@redhat.com>, 
    linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: playstation: DS4: Fix calibration workaround
 for clone devices
In-Reply-To: <20240504165531.21315-1-max@enpas.org>
Message-ID: <nycvar.YFH.7.76.2405062331420.16865@cbobk.fhfr.pm>
References: <20240504165531.21315-1-max@enpas.org>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sun, 5 May 2024, Max Staudt wrote:

> The logic in dualshock4_get_calibration_data() used uninitialised data
> in case of a failed kzalloc() for the transfer buffer.

Good catch, this completely escaped my attention during review.

> 
> The solution is to group all business logic and all sanity checks
> together, and jump only to the latter in case of an error.
> While we're at it, factor out the axes' labelling, since it must happen
> either way for input_report_abs() to succeed later on.
> 
> Thanks to Dan Carpenter for the Smatch static checker warning.
> 
> Fixes: a48a7cd85f55 ("HID: playstation: DS4: Don't fail on calibration data request")
> Signed-off-by: Max Staudt <max@enpas.org>

Now queued on top of the for-6.10/playstation pile in hid.git.

Thanks,

-- 
Jiri Kosina
SUSE Labs