Received-SPF: pass (google.com: domain of linux-kernel+bounces-170450-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <5523c4770ce2de9e804a3020e0bd5c60fb401fc2.camel@linux.intel.com>
Subject: Re: [PATCH] HID: intel-ish-hid: ipc: Add check for
 pci_alloc_irq_vectors
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Chen Ni <nichen@iscas.ac.cn>, bentiss@kernel.org, even.xu@intel.com, 
	lixu.zhang@intel.com, kai.heng.feng@canonical.com, hongyan.song@intel.com, 
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Mon, 06 May 2024 14:52:22 -0700
In-Reply-To: <nycvar.YFH.7.76.2405062311100.16865@cbobk.fhfr.pm>
References: <20240429085422.2434036-1-nichen@iscas.ac.cn>
	 <95fadbf4772d575bff777ddb738cb6c25b85b779.camel@linux.intel.com>
	 <nycvar.YFH.7.76.2405062311100.16865@cbobk.fhfr.pm>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-05-06 at 23:11 +0200, Jiri Kosina wrote:
> On Thu, 2 May 2024, srinivas pandruvada wrote:
>=20
> > On Mon, 2024-04-29 at 16:54 +0800, Chen Ni wrote:
> > > Add check for the return value of pci_alloc_irq_vectors() and
> > > return
> > > the error if it fails in order to catch the error.
> > >=20
> > You can write as
> > "
> > Add a check for the return value of pci_alloc_irq_vectors() and
> > return
> > error if it fails.
> > "
>=20
Hi Jiri,

> Srinivas,
>=20
> my understanding is that with the changelog rewroding this patch has
> your=20
> Ack?
Yes, just to make it more clear. With that.


Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

Thanks,
Srinivas


>=20
> Thanks,
>=20