Received-SPF: pass (google.com: domain of linux-kernel+bounces-170512-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8bf65df598680f0785c3d6db70acfb9a.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20240504120624.6574-1-krzysztof.kozlowski@linaro.org>
References: <20240504120624.6574-1-krzysztof.kozlowski@linaro.org>
Subject: Re: [GIT PULL] clk: samsung: drivers for v6.10
From: Stephen Boyd <sboyd@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Chanwoo Choi <cw00.choi@samsung.com>, linux-clk@vger.kernel.org, Sylwester Nawrocki <snawrocki@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>, Peter Griffin <peter.griffin@linaro.org>, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Michael Turquette <mturquette@baylibre.com>
Date: Mon, 06 May 2024 16:44:51 -0700
User-Agent: alot/0.10

Quoting Krzysztof Kozlowski (2024-05-04 05:06:22)
> The following changes since commit 4cece764965020c22cff7665b18a0120063590=
95:
>=20
>   Linux 6.9-rc1 (2024-03-24 14:10:05 -0700)
>=20
> are available in the Git repository at:
>=20
>   https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/sam=
sung-clk-6.10

I'm getting compile warnings. Is there a pending fix? Also, why is GS101
describing clk parents with strings instead of using clk_parent_data?

In file included from drivers/clk/samsung/clk-gs101.c:16:
drivers/clk/samsung/clk-gs101.c:2616:7: error: =E2=80=98mout_hsi2_mmc_card_=
p=E2=80=99
defined but not used [-Werror=3Dunused-const-variable=3D]
 2616 | PNAME(mout_hsi2_mmc_card_p)     =3D { "fout_shared2_pll", "fout_sha=
red3_pll",
      |       ^~~~~~~~~~~~~~~~~~~~
drivers/clk/samsung/clk.h:236:44: note: in definition of macro =E2=80=98PNA=
ME=E2=80=99
  236 | #define PNAME(x) static const char * const x[] __initconst
      |                                            ^
drivers/clk/samsung/clk-gs101.c:2609:7: error: =E2=80=98mout_hsi2_bus_p=E2=
=80=99 defined but not used [-Werror=3Dunused-const-variable=3D]
 2609 | PNAME(mout_hsi2_bus_p)          =3D { "dout_cmu_shared0_div4",
      |       ^~~~~~~~~~~~~~~
drivers/clk/samsung/clk.h:236:44: note: in definition of macro =E2=80=98PNA=
ME=E2=80=99
  236 | #define PNAME(x) static const char * const x[] __initconst
      |                                            ^
drivers/clk/samsung/clk-gs101.c:2607:7: error: =E2=80=98mout_hsi2_pcie_p=E2=
=80=99 defined but not used [-Werror=3Dunused-const-variable=3D]
 2607 | PNAME(mout_hsi2_pcie_p)         =3D { "oscclk", "dout_cmu_shared2_d=
iv2" };
      |       ^~~~~~~~~~~~~~~~
drivers/clk/samsung/clk.h:236:44: note: in definition of macro =E2=80=98PNA=
ME=E2=80=99
  236 | #define PNAME(x) static const char * const x[] __initconst
      |                                            ^
drivers/clk/samsung/clk-gs101.c:2604:7: error: =E2=80=98mout_hsi2_ufs_embd_=
p=E2=80=99 defined but not used [-Werror=3Dunused-const-variable=3D]
 2604 | PNAME(mout_hsi2_ufs_embd_p)     =3D { "oscclk", "dout_cmu_shared0_d=
iv4",
      |       ^~~~~~~~~~~~~~~~~~~~
drivers/clk/samsung/clk.h:236:44: note: in definition of macro =E2=80=98PNA=
ME=E2=80=99
  236 | #define PNAME(x) static const char * const x[] __initconst