Received-SPF: pass (google.com: domain of linux-kernel+bounces-170533-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <f0a0d637-a4c2-48d0-b6f6-45688c8ef7da@oracle.com>
Date: Tue, 7 May 2024 10:58:13 +1000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/irq: Use existing helper for pending vector check
To: Jacob Pan <jacob.jun.pan@linux.intel.com>, X86 Kernel <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>
References: <20240506175612.1141095-1-jacob.jun.pan@linux.intel.com>
Content-Language: en-US
From: imran.f.khan@oracle.com
In-Reply-To: <20240506175612.1141095-1-jacob.jun.pan@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?WjJjTHRXVG5JZFIyckQwalJsNnJBZzZlbHdmRHFiZ25Ca3Z4cDhwRlRjMEdD?=
 =?utf-8?B?dW0yRWFUUGV5eHU2UlBMT1didHlRYTJodlN0eW9lTWZqMFRtemtwZU9hTHZI?=
 =?utf-8?B?Y1BsMXNMVXcwd0ZHVXliT3g5U0dpSjJDeXZmZnRZWkYvcWh2OTlyZTJxNTY3?=
 =?utf-8?B?c1FBMlRBNEFSd2pRNkhqdUowK1AxRU9sOXV5OXdadGRTYmNMcHR2aTluUk44?=
 =?utf-8?B?ZzBBOEk4RlFSN3loWkYrYXhoc25yeStXTVhPc0JmZng0dkxHU1FQS3VETFlm?=
 =?utf-8?B?cm44eDY0dWw4c2tSUCtTblJiTGZ0b3hVUFpaRmVtUjZvaXpjdFByaUFuTnB2?=
 =?utf-8?B?YmpGc2ZZYWFEbDJldXNtYnp4RTlJNHQ1b0M1MjdlSVhTOTB2MVFyMGNFU2kr?=
 =?utf-8?B?VjVodzdKMm91T3hzZVVTMVRObWlXcWtXZmZ5WWtuNHZNZXpsRncrL3V0alJy?=
 =?utf-8?B?TlZ6dEowQVN2SHZMdDNoL2oySjdBOVBRSllwK3BwWms0RkZjTUFNNUNxUWdJ?=
 =?utf-8?B?Ri9VMHVaMnREZ0toclZqWGE2TFE4NjVRSkZyZjVkM0VuMS9qN0wzdnJ2U040?=
 =?utf-8?B?NmErTTBRRDZqVURUeWtJNmNjZVRhd1Q0MmUrZTZaTkJ3dnBJYVJtaUZETU9L?=
 =?utf-8?B?V2h3VGIxdkVDVlJpREVxWU1sSmFEMC9sclhycXNFOW9lRVUyeENPRTNkQUZG?=
 =?utf-8?B?WDhrN2RXWS8xQVE5Y3pudDg1YnAxM016a3J5cmtCOXlPV3N2OVQrYzRmbU5N?=
 =?utf-8?B?eVNmSThQc3ZjTzF6QzJ0SFFDSnYrQ2F1N3pvamR3ZjBGZFhJU2dsdWR5NlRX?=
 =?utf-8?B?S0dQdTJvQ1gvK3BESTZtNnozNE9Ha2FwYnNiQ3N3YUZPdDJJRFpZcUkvWkhG?=
 =?utf-8?B?aGNtMlErV2I3a1FLeDNuNUlGNEtac1VOTkhrS3BOSldwbmxVVlNrZkdEeE9C?=
 =?utf-8?B?RjlRaEY2UUFjSkpMeElkMzRzREdaQ1JyQW05anQzZFVuMEhhcjRQdmVSSXVO?=
 =?utf-8?B?THVncGUzbW9qcXFZMTZ5Qi94WEQ1U0N3emhxUzhHSDdiRFpOWmY3alhkdUNm?=
 =?utf-8?B?NHF5OEVKUUtkdDFHL3lpT05JbkJVVUV1Um5KMmJvQzZaVklPUEM4Y0lBV2tO?=
 =?utf-8?B?SitrUW9LcWVZMStkVkMxMTB3TFNWc0NyVVVxb2RMTVRieTNBRkxzb3JYemxK?=
 =?utf-8?B?VlNrZ05MSnVtV3BKWSt5MkgzMUN6aFJTR3kyeFVyblptRVVOSStiK1NzdDVQ?=
 =?utf-8?B?N0pqV2pVK3BLQkJqTHhFL0QwaGcyWjJ2dXVsbHhSZ1hJR1ZkTWdXU3ZUNXpS?=
 =?utf-8?B?UTI1YW1YY0hYRERQR0VsK0U1MjdOWktXTFg2TkNiRFpJZEZ3SGJPM1JLejNV?=
 =?utf-8?B?cnJZeGJxREJmTjhGS29qZm5HUERYMGR6blpISE1UVC9oQ254Tm1YZFpOS2Jh?=
 =?utf-8?B?VVFTRHNxTGhNRjIzZUVMeE1qRGx3T0FPWDNKZ0dzZFBGZi9BTUdLQ0dIMC91?=
 =?utf-8?B?ZWtGMjZWQWk5K0phS3V1NFpjeWxIajJKU3Rzak9vOVloQTFwc1ZVSFdScWRj?=
 =?utf-8?B?dUFaZzZjYlVVTi9wc3VHUkE4d1AvZFJDNENJV05zUkpKS1NFcHhUWHVLM3RK?=
 =?utf-8?B?SFh4TEg5RkRxYVN5TEdyMEJKUG9kd09KM0w3TWxwQkZnNFl2OUMzT2wvbWpT?=
 =?utf-8?B?b0J2MTUyVnFUNnQ5QVFvZ1ZmYTd1cDJndGdSbGVIRWkxbFFmNjVTWEV6OHhE?=
 =?utf-8?B?ZnBEZ1Rnd3owM1lFVWt3dVRKckxkeG9ET1BYQjh3bm9LWkZOdEg2MVl5Y09E?=
 =?utf-8?B?S2cyYUtBc2J6akJsbXJrQjRYUWt1QTVwWVozZGZxZWVZYmZlekwrTjIxdGVM?=
 =?utf-8?B?cUNUbkVpZldnUDNDQ0NHcklBVGtNZkF3eGtnWG5Yam5zcGg2bUNYb2V0WW9l?=
 =?utf-8?B?ODIvRklweVhQYWFacFdlS0doa2dJaUlURTZGSTZ1SjdiT1Z3VnBjUmkzOUlv?=
 =?utf-8?B?MTh6OTJna0pZVEZ5M1B4eG5SemhSeG5mdnpjV3h6bkVEQ2ZrMUNZK1R3VFE0?=
 =?utf-8?B?MFdJb05OYVM5WWc3b09KVGhqUTNlMzM4eC95anc1L0R1TkM2aWE2OGFvNUpH?=
 =?utf-8?B?b1hxd2wwVWptNzdBVGNnK01NSEF6c1Z5SERCU2YrZFlRL1FMU2FnanZWckJr?=
 =?utf-8?B?b2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ENSMuiQoNBZZVg0shUHf8xn8dflGfQqJSjNkPubPyh2STnUhPjkShXl/0dxqICE7hI/ldbzbMIdCCdYWU1aZijKJJtZjhSrDa/uVY2Ljg0Df9HZaha344oNe8fhfuQAisTPWCALNasMV0MoIqQVbzYNtzzD07T5a4pXMDuD1b1FklCchABHT5mJV/dyc1IhiO66DvC2fKNbiqtoDuA/DFgTxudB4cG+xDru8WhfweetRswFxyA4OPgF7Q685sDRtVIo84Ymh1F3/gTm6EU+MXY9KalzLXUd702q1MYGZu/SDu7/Rsbx5KnO38FiZwGbBtnDogDjhfPmwzKN8x+JeypjFC4q01qyFHXaDIP6pQdCvzbETN9ZgXOFXDivHKk41oCtHwqbIDImpmuAYJzm6riQAVjy78Gp8tIxTqtEly7PZicV9q7FW7nsm141UdSiycrOxMahdCkV434V4AdeWkXbDkwZiAWaJOp1TC5pPcRRtpMMwimrK/RFQ9FexMGFjvSo17on7qVo1A0ChZ+EP44OkETKmtxRw/OYxPYSoYudYxZCy4lFT+LcNAxLzSpr/NUguLYE6l0s1FSi5XIa+3wzK+Lbg7UxVzYDvOknOWrw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c1a9190-b1df-408f-57e5-08dc6e30cab4
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 00:58:22.0446
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l9ySU0aMYjSXOg++EGvk710lzHBu0Bi183jq/6Oy1/y90YIhAMkr55+1+pKu7pfpjjSG7X8HgjORUj6FPAmZgg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB5943
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-06_18,2024-05-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 suspectscore=0 adultscore=0 phishscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2405070006
X-Proofpoint-GUID: oQOPNYzTa-bMk3DMPcaGr3GhSUc3uZ3F
X-Proofpoint-ORIG-GUID: oQOPNYzTa-bMk3DMPcaGr3GhSUc3uZ3F

Hello Jacob,
This looks good to me.


On 7/5/2024 3:56 am, Jacob Pan wrote:
> lapic_vector_set_in_irr() is already available, use it for checking
> pending vectors at the local APIC. No functional change.
> 
> Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Imran Khan <imran.f.khan@oracle.com>

Reviewed-by: Imran Khan <imran.f.khan@oracle.com>
> ---
>  arch/x86/include/asm/apic.h | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
> index 9122e93b89ea..d7a8ac961af8 100644
> --- a/arch/x86/include/asm/apic.h
> +++ b/arch/x86/include/asm/apic.h
> @@ -505,13 +505,7 @@ static inline bool lapic_vector_set_in_irr(unsigned int vector)
>  
>  static inline bool is_vector_pending(unsigned int vector)
>  {
> -	unsigned int irr;
> -
> -	irr = apic_read(APIC_IRR + (vector / 32 * 0x10));
> -	if (irr  & (1 << (vector % 32)))
> -		return true;
> -
> -	return pi_pending_this_cpu(vector);
> +	return lapic_vector_set_in_irr(vector) || pi_pending_this_cpu(vector);
>  }
>  
>  /*