Received-SPF: pass (google.com: domain of linux-kernel+bounces-170536-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 6 May 2024 18:12:54 -0700
From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, nalramli@fastly.com, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Paolo Abeni
 <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net-next v2] selftest: epoll_busy_poll: epoll busy poll
 tests
Message-ID: <20240506181254.09f10699@kernel.org>
In-Reply-To: <20240506205326.70502-1-jdamato@fastly.com>
References: <20240506205326.70502-1-jdamato@fastly.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon,  6 May 2024 20:53:22 +0000 Joe Damato wrote:
> Add a simple test for the epoll busy poll ioctls, using the kernel
> selftest harness.
> 
> This test ensures that the ioctls have the expected return codes and
> that the kernel properly gets and sets epoll busy poll parameters.
> 
> The test can be expanded in the future to do real busy polling (provided
> another machine to act as the client is available).

Hm, we get:

# timeout set to 3600
# selftests: net: epoll_busy_poll
# TAP version 13
# 1..5
# # Starting 5 tests from 2 test cases.
# #  RUN           invalid_fd.test_invalid_fd ...
# #            OK  invalid_fd.test_invalid_fd
# ok 1 invalid_fd.test_invalid_fd
# #  RUN           epoll_busy_poll.test_get_params ...
# #            OK  epoll_busy_poll.test_get_params
# ok 2 epoll_busy_poll.test_get_params
# #  RUN           epoll_busy_poll.test_set_invalid ...
# # epoll_busy_poll.c:204:test_set_invalid:Expected -1 (-1) == ret (0)
# # epoll_busy_poll.c:205:test_set_invalid:EPIOCSPARAMS should error busy_poll_budget > NAPI_POLL_WEIGHT
# # epoll_busy_poll.c:207:test_set_invalid:Expected EPERM (1) == errno (22)
# # epoll_busy_poll.c:208:test_set_invalid:EPIOCSPARAMS errno should be EPERM busy_poll_budget > NAPI_POLL_WEIGHT
# # test_set_invalid: Test failed
# #          FAIL  epoll_busy_poll.test_set_invalid
# not ok 3 epoll_busy_poll.test_set_invalid
# #  RUN           epoll_busy_poll.test_set_and_get_valid ...
# #            OK  epoll_busy_poll.test_set_and_get_valid
# ok 4 epoll_busy_poll.test_set_and_get_valid
# #  RUN           epoll_busy_poll.test_invalid_ioctl ...
# #            OK  epoll_busy_poll.test_invalid_ioctl
# ok 5 epoll_busy_poll.test_invalid_ioctl

https://netdev-3.bots.linux.dev/vmksft-net/results/584001/98-epoll-busy-poll/stdout