Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp248450lqh; Mon, 6 May 2024 19:02:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVbm+hcwyrYBBKcocUQ/qDyaWuiaa2NRoAxUfhStnJIEU0JFAsLrt/oLMTRRD2IeXFny306ltA6ttCqOwOPG35F4LGyf1DKEGqp3xQwrA== X-Google-Smtp-Source: AGHT+IEubjLIiVU++Jife/nWcW+08xTwfjP/mL4hrYXlHkqph/w/CGWRU8Lgk5XcC/fGfQ+cq9cU X-Received: by 2002:a25:fc16:0:b0:deb:3b69:c675 with SMTP id v22-20020a25fc16000000b00deb3b69c675mr11296132ybd.48.1715047375087; Mon, 06 May 2024 19:02:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715047375; cv=pass; d=google.com; s=arc-20160816; b=HI/YrVSn2zgINA14xRXxwOxQw26rg/mvHXhMnqn/RB3THPa00DTnUtrPiGsQl7Zw05 hjjdNa0PrqXtt6OWaGz/CZcEtKY8kHOXI4wd7dV/97iVefusyE4R6gZoTrMIEVSV/tzm Jb5kAuhmAyK/c1/7ffMUlr+mWoOMyKkED7EEjGglOPZeFnbo++UPHQUIrr8Sx2rn5Hnq 61muKDU2utft+VcD2rqpCqg+p68xkMXW03fuaX8uPI0Ymw+DvVG/UVnCihJOmh6hn8wG jMq8Z/ByWo7pH32oiziqVKXT+b2FSq8OUBZ7FbcXKCNBlsRXw1s00Duzuvtkdpi0SgJX xyjQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=ENTDrqJBrmT4Gqhjy8JnFacP2hxPdYxw2q+aocbbnZQ=; fh=7Vek+laWpHf1S6HEVZZEPfG2Q3rOwUwKKSawt39Omr0=; b=L77m/f5BMAkP23RkPkk9AvrsBlUt5dzte3sCRXqpoTIGc4tQGKpPtZdvpvFPAwbqMj Al87crGufSr5JcA3QU9Q6hYpMbNUUbFoHn3s70tegKuIfATXoLFQ468X+UfeCPbiurkM StHp7l19IxDjNZhmbk3IGFwzSAOsFLcc2UBZvp6sw4xB4EpieFiKhcslDUDl+xHIyg/b 8za1nUOqw/i1uoue2hbijtPNY95ax6EyQ7ojD8KH4w17Q9clEFWVvYNr2G39zqJ1c0rE oZGmf/X/vKBOZE4GCilShtqTCqlOiJ10XgQR1BTyvGdfyaihErnzOg1CgcI17czF4AQC //PA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OdwQiZlm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170575-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170575-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id cr22-20020a05622a429600b0043a6627ed79si10846799qtb.654.2024.05.06.19.02.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 May 2024 19:02:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170575-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OdwQiZlm; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-170575-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170575-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id CB3401C20FCC for ; Tue, 7 May 2024 02:02:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EB8704C94; Tue, 7 May 2024 02:02:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OdwQiZlm" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F0D8139F; Tue, 7 May 2024 02:02:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715047367; cv=none; b=sXuejVUHvAgxxyvwnvsdau0jGqwU4MDv/+pmwaQhg7g95GlDyp1QiZi6J43uKJxt6bDRgCZTgpB4QYPyiUXOVg7+hIxMSapX2SiLmEacIbNkDJz7TIgkxpwXLGu2EukDoeyIAUXHLIsIbAQfUnMTnHTEROUoRXES68qOtqz3H7Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715047367; c=relaxed/simple; bh=2PbTFHwii7HUApZIxpvCWJSS986WH4OcmVs2GTxmBKM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JGogmkuEVolbtJHTbxFni4JJNKtRwGyK3PNheuem6aL4N5Rok5ehNUvwUcS/DluWMKZCTJEeytyaG1lkhRHI9VrIBqtpFxoEF6QnNkmnz5MOx9XMJUiLalr0MGUAxOkuHttbrMa7I/+zuJrGlEGSvQxDwKl4dK93sB8QwnWK+kk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OdwQiZlm; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8039CC116B1; Tue, 7 May 2024 02:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715047366; bh=2PbTFHwii7HUApZIxpvCWJSS986WH4OcmVs2GTxmBKM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OdwQiZlmSF8Zx97j7kVtMYdl6YAp3ouOKiF7LDjDY5v6PFJ3Hoh9w2ZtYJCWZV41y gs+v+oS0eqA0xV8+piM5qli1VlfoVg0n9TTYvb0c9JHHD6Hg8bfr3uzqARz3EZw+Pk nZZivYpDoAcbFfx+2O8D64LPjlwj6igDXzaVIn/VJgIaTRyiNMRIDouVlQfmECqEUX vIf2A6JZ5RTUuI4wPSUz0C8XXOyYqhtVYtu4lv6tt217vR+rc5DEMJ6zYzrdsc76TY mHkGSiN10pm0wHCO0gDOR8fe2vMdgg8f5N/mcKb1AGH/Ejjtc7JEnpQxyL6YcIfenZ kZhjbIbhOV4EQ== Date: Mon, 6 May 2024 19:02:45 -0700 From: Jakub Kicinski To: Joe Damato Cc: linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, nalramli@fastly.com, "David S. Miller" , Eric Dumazet , Paolo Abeni , Shuah Khan Subject: Re: [PATCH net-next v2] selftest: epoll_busy_poll: epoll busy poll tests Message-ID: <20240506190245.3236424c@kernel.org> In-Reply-To: References: <20240506205326.70502-1-jdamato@fastly.com> <20240506181254.09f10699@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 6 May 2024 18:40:00 -0700 Joe Damato wrote: > Ah, sorry -- this is because I had assumed the test would run without > CAP_NET_ADMIN, but since: > > epoll_busy_poll.c:204:test_set_invalid:Expected -1 (-1) == ret (0) > > succeeds (ret = 0), clearly I am mistaken. Sorry about that. > > I think I'll spin up a v3 and I'll add a test with and without > CAP_NET_ADMIN to check both cases, which would probably be better anyway. FWIW the tests run a in separate process from the harness, so it may be possible to drop privileges inside the test, without affecting other test cases. But I've never done it myself, so not sure how easy it is to do in practice..