Received-SPF: pass (google.com: domain of linux-kernel+bounces-170602-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\))
Subject: Re: [PATCH 0/1] *** Replace KLP_* to KLP_TRANSITION_* ***
From: zhang warden <zhangwarden@gmail.com>
In-Reply-To: <20240507024151.6jto4zraqfbqxcw2@treble>
Date: Tue, 7 May 2024 10:56:09 +0800
Cc: mbenes@suse.cz,
 jikos@kernel.org,
 Petr Mladek <pmladek@suse.com>,
 Joe Lawrence <joe.lawrence@redhat.com>,
 live-patching@vger.kernel.org,
 linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4010C687-88C9-43FC-B8C9-80981B04807F@gmail.com>
References: <20240507021714.29689-1-zhangwarden@gmail.com>
 <0E399FCD-396E-448B-A974-6034F4CF2B53@gmail.com>
 <20240507024151.6jto4zraqfbqxcw2@treble>
To: Josh Poimboeuf <jpoimboe@kernel.org>


> On May 7, 2024, at 10:41, Josh Poimboeuf <jpoimboe@kernel.org> wrote:
>=20
> On Tue, May 07, 2024 at 10:21:40AM +0800, zhang warden wrote:
>>=20
>>=20
>>>=20
>>> transition state. With this marcos renamed, comments are not=20
>>> necessary at this point.
>>>=20
>> Sorry for my careless, the comment still remains in the code. =
However,
>> comment in the code do no harms here. Maybe it can be kept.
>=20
> The comments aren't actually correct.
>=20
> For example, KLP_TRANSITION_UNPATCHED doesn't always mean =
"transitioning
> to unpatched state".  Sometimes it means "transitioning *from* =
unpatched
> state".
>=20
> --=20
> Josh

OK, I got it. I will remove the comment later. After all, comment is not =
necessary at this point after we rename the macros.=