Received-SPF: pass (google.com: domain of linux-kernel+bounces-170636-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <ecd2b4c9-32d7-0436-a68b-17b94df85875@amd.com>
Date: Tue, 7 May 2024 09:38:44 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH 2/3] x86/bus_lock: Add support for AMD
Content-Language: en-US
To: Tom Lendacky <thomas.lendacky@amd.com>, tglx@linutronix.de,
 mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
 seanjc@google.com, pbonzini@redhat.com
Cc: hpa@zytor.com, rmk+kernel@armlinux.org.uk, peterz@infradead.org,
 james.morse@arm.com, lukas.bulwahn@gmail.com, arjan@linux.intel.com,
 j.granados@samsung.com, sibs@chinatelecom.cn, nik.borisov@suse.com,
 michael.roth@amd.com, nikunj.dadhania@amd.com, babu.moger@amd.com,
 x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
 santosh.shukla@amd.com, ananth.narayan@amd.com, sandipan.das@amd.com,
 Ravi Bangoria <ravi.bangoria@amd.com>
References: <20240429060643.211-1-ravi.bangoria@amd.com>
 <20240429060643.211-3-ravi.bangoria@amd.com>
 <bb6a554f-4823-59ce-16a4-48bd5b911d63@amd.com>
From: Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <bb6a554f-4823-59ce-16a4-48bd5b911d63@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFZtVjZRRTMxSGNTcVc5RHBXM1k2bkY2cC9DY01BdU0wc3ZGeEFmL3lHYWY3?=
 =?utf-8?B?bVo5dlBzd1BsQThkUmwzQWZsa3B6M2I0V1R1UTNzOUI5bFVpVklxT2EzTU53?=
 =?utf-8?B?U095VWdGZHY5cDQvbVRsQTRGZlJyOWFpbjhPOG1XRkd4aUhINUlyNDVZekV3?=
 =?utf-8?B?c1NqSkNkYjlpcEtiYVFnRFFydFVlSVRhbmR6V0IydkJ5bzBqOTFYQTN3c2FB?=
 =?utf-8?B?bVdnVFNYeEExQUVWSUZjalQrcmtwaDFVNTRYcnBKSnVrc1AreUFDVlE4djNu?=
 =?utf-8?B?cTk1dzM5cm9HSnpWZkR1UnhBVVoyaFk5c2l1V296WDdScVpwdU4xdTRUVEtG?=
 =?utf-8?B?K05KNUJTTHNaT0IxMGZPTW5tZlJLQmpKdnFUYjRUMlRqYm5QVWgvOEdrYW5E?=
 =?utf-8?B?YllHSUlndmlFVVBGUSs3VFQxYUlNMXNmaHlwRktWd1BFeGxVdGRCdVZlMU9j?=
 =?utf-8?B?aElhTkdoUUdXd2FvL05NTVM4MW8vNi9ac2FDZkduYzA5SUNocklqOUtsNEJo?=
 =?utf-8?B?NWpNcVk1T2JkYmlIMlBNODRJSVppNXFVZVlkcXlOSGVINEkwWm9XL0F2VDRY?=
 =?utf-8?B?TmlkRENaTlF6TG1ZS2FJV2lsVGEwMzVrTmdiTFVLbDhrbUNMeXVuMW1BSmVR?=
 =?utf-8?B?d29mbGFFYUN5T2xCaHVLNjVwTHdkNTZYb1MrMkJHdUxIbExPQWREckROQW5q?=
 =?utf-8?B?UkN3RjlQWk9pd2tiL2UyV24xQTBTVTBoL0JtNWpPRkVkWmpaeVBwTDVQRXZW?=
 =?utf-8?B?TkxPWU4xYWZJN0Mxc3ljMTNYQ2xpZC92MjRENEE2MkZqa0ZNYWZOUko3V1FQ?=
 =?utf-8?B?T240V3BaMndFS2h0enFaUE8wbHdlY21LY3I5UFh1VGxlUmFvS3NpM0lUTGp3?=
 =?utf-8?B?TjBuNDd3Wjk3UG92ZHpsZ29KNERRQ1RVdTRDc0szR1ZHa3VIbEpLbDlqdVdp?=
 =?utf-8?B?MnpiT3pTRThFaHJReTlrcTdxQ1JnODNaelZXeXNscjlrT1N0K0FJWjdFN3gx?=
 =?utf-8?B?OEM4d2l3NTlwdXBZekFwRVBvV3I0UXMwQ1dKTWVIcWhkekFrZ2FiRVYxaVZi?=
 =?utf-8?B?OTREeVJkb1ZOblNLbFFHa1dMRWxEYmJtTjNoQlJTaWVwZXc1Wm9pZnpodlVF?=
 =?utf-8?B?Z3NDTDJVbnViVHgyeWc2Y0phTGVuYVlUQkcrQzJGdXZsOEFGbkoyVytMRWYv?=
 =?utf-8?B?L0h6elJDMVdJSG5PK3hITlZvbnVmSEV6cXUxcVc3RWRLUlFKTVdTRmF3M1ZM?=
 =?utf-8?B?bmpaeEd4cS9oM1N0Q1htWmdYNGFHOHoyZVhOUW1OZFcyd21ZZ0NEUlhnd1Jh?=
 =?utf-8?B?U3AwTHRsT2ZZd0Ewb0wvS0hUdWJLSThDbVJ3Rzg4Y2pGS2FpbWJtcHNOMjc3?=
 =?utf-8?B?azg5WUk2aWs5bXl2eWphTU1JRTF4UE9HTnlGOGN3RFZpZm8xSHczTHRORHBE?=
 =?utf-8?B?amd1NmVEMHRNV1lLYWFnS3kwbVN1aFFpbTZ1MWJRakloLzVVbVJJSzNSWG1C?=
 =?utf-8?B?dTJHQ1dYWlgxeDF5cEJWUVhaT3k5N1JUaFFZQlZ0MTdqY1hYNUNRSFl3QnRp?=
 =?utf-8?B?V2dJTzVOUDdyU25KdkdxcURadDZ6dGFNT0RnZXVnRUlXSU5nbEFNUTN0RGxB?=
 =?utf-8?B?ejk0a3J3Sk82VWpCU1h6VElOcFR3eWhqZ2t5NGN2ODZOMG1PMk9TanFiTTc5?=
 =?utf-8?B?QmRjdHNoejE5VlRaSHN3NkNjN3NLUjFXV0Z0b2tYbUVSOWx0MWt4NXIxYWI5?=
 =?utf-8?B?c0dDTE4xOTRCdG9SczE5MVBJY2Z5UjVmcFM3c3Qvd203YTRvRU9Ic1JxUGJZ?=
 =?utf-8?B?SG5DK3BBUU11WVFCamRORTM0T3Nyc0xxSlkyTllyTGNVMXk2Qndnbkp2RHlU?=
 =?utf-8?B?NjRITVFoeGNkNVpGTmQ5MU5SQXExZ3EzNXAzZk1ZaXJraXp3VWZvd2FXZDBv?=
 =?utf-8?B?YVArd3dHUVNXMHZ5ZzdxdFIxZTR0MzhIN2hnUkRHVlVrd0VacGVHL3Z1OUhC?=
 =?utf-8?B?QVBlZ3BJYVNSWmp5SWJxVFljY0hTcmFUYXI0NmdaQ1hrZVlNa2pGZHJkRkF0?=
 =?utf-8?B?WEJjT21FZk9ZVDlUWmNXN0N2NlJ2eGk1QjV1Ti9ESkdRTVlwbGptMGx6d2RH?=
 =?utf-8?Q?o9Q5zsuUKqaqLyLbZU1NV7N/7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51b58ec2-3838-47cc-e3eb-08dc6e4b7070
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 04:09:06.9359
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OxqNPK65HLM6boAZGldAFBlshTWpOXK0ytd9fEVMUu0MvR7HFdfAwzaBfabWJaYgy3/hcIK87blFYFNDHEdhwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6496

>> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
>> index 39f316d50ae4..013d16479a24 100644
>> --- a/arch/x86/kernel/cpu/amd.c
>> +++ b/arch/x86/kernel/cpu/amd.c
>> @@ -1058,6 +1058,8 @@ static void init_amd(struct cpuinfo_x86 *c)
>>         /* AMD CPUs don't need fencing after x2APIC/TSC_DEADLINE MSR writes. */
>>       clear_cpu_cap(c, X86_FEATURE_APIC_MSRS_FENCE);
>> +
>> +    bus_lock_init();
> 
> Can this call and the one in the intel.c be moved to common.c?

Makes sense. Will do it.

Thanks,
Ravi