Received-SPF: pass (google.com: domain of linux-kernel+bounces-170654-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240506121906.76639-1-atrajeev@linux.vnet.ibm.com> <20240506121906.76639-4-atrajeev@linux.vnet.ibm.com>
In-Reply-To: <20240506121906.76639-4-atrajeev@linux.vnet.ibm.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Mon, 6 May 2024 21:40:15 -0700
Message-ID: <CAM9d7ciKUQErzu1Y7FnWCryW15xUkyJLSt-Jez9h8TYgp-tLjw@mail.gmail.com>
Subject: Re: [PATCH V2 3/9] tools/perf: Fix a comment about multi_regs in
 extract_reg_offset function
To: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, 
	irogers@google.com, segher@kernel.crashing.org, christophe.leroy@csgroup.eu, 
	linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, 
	maddy@linux.ibm.com, kjain@linux.ibm.com, disgoel@linux.vnet.ibm.com, 
	linux-kernel@vger.kernel.org, akanksha@linux.ibm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 6, 2024 at 5:19=E2=80=AFAM Athira Rajeev
<atrajeev@linux.vnet.ibm.com> wrote:
>
> Fix a comment in function which explains how multi_regs field gets set
> for an instruction. In the example, "mov  %rsi, 8(%rbx,%rcx,4)", the
> comment mistakenly referred to "dst_multi_regs =3D 0". Correct it to use
> "src_multi_regs =3D 0"
>
> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> ---
>  tools/perf/util/annotate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index f5b6b5e5e757..0f5e10654d09 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -2093,7 +2093,7 @@ static int extract_reg_offset(struct arch *arch, co=
nst char *str,
>   *   mov  0x18, %r8      # src_reg1 =3D -1, src_mem =3D 0
>   *                       # dst_reg1 =3D r8, dst_mem =3D 0
>   *
> - *   mov  %rsi, 8(%rbx,%rcx,4)  # src_reg1 =3D rsi, src_mem =3D 0, dst_m=
ulti_regs =3D 0
> + *   mov  %rsi, 8(%rbx,%rcx,4)  # src_reg1 =3D rsi, src_mem =3D 0, src_m=
ulti_regs =3D 0
>   *                              # dst_reg1 =3D rbx, dst_reg2 =3D rcx, ds=
t_mem =3D 1
>   *                              # dst_multi_regs =3D 1, dst_offset =3D 8
>   */
> --
> 2.43.0
>