Received-SPF: pass (google.com: domain of linux-kernel+bounces-170702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Feedback-ID: i7ce144cd:Fastmail
Date: Tue, 7 May 2024 15:43:58 +1000
From: Peter Hutterer <peter.hutterer@who-t.net>
To: bentiss@kernel.org
Cc: Jiri Kosina <jikos@kernel.org>, Shuah Khan <shuah@kernel.org>,
	linux-input@vger.kernel.org, Martin Sivak <mars@montik.net>,
	Ping Cheng <pinglinux@gmail.com>,
	Jason Gerecke <killertofu@gmail.com>,
	Aaron Armstrong Skomra <skomra@gmail.com>,
	Joshua Dickens <Joshua@joshua-dickens.com>,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 19/18] selftests/hid: skip tests with HID-BPF if
 udev-hid-bpf is not installed
Message-ID: <20240507054358.GA696790@quokka>
References: <20240410-bpf_sources-v1-0-a8bf16033ef8@kernel.org>
 <20240506143612.148031-1-bentiss@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240506143612.148031-1-bentiss@kernel.org>

On Mon, May 06, 2024 at 04:36:12PM +0200, bentiss@kernel.org wrote:
> From: Benjamin Tissoires <bentiss@kernel.org>
> 
> udev-hid-bpf is still not installed everywhere, and we should probably
> not assume it is installed automatically.
> 
> Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
> ---
> 
> I wanted to apply this series given that it wasn't reviewed in a month,

apologies. Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>

(I have a few improvement suggestions for the hidtools code but it's
better to do those there and then sync back).

Cheers,
  Peter

> but I thought that maybe I should not enforce ude-hid-bpf to be
> installed everywhere.
> 
> I'll probably push this series tomorrow so it makes the 6.10 cut.
> 
> Cheers,
> Benjamin
> 
>  tools/testing/selftests/hid/tests/base.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tools/testing/selftests/hid/tests/base.py b/tools/testing/selftests/hid/tests/base.py
> index 2d006c0f5fcd..3a465768e507 100644
> --- a/tools/testing/selftests/hid/tests/base.py
> +++ b/tools/testing/selftests/hid/tests/base.py
> @@ -8,6 +8,7 @@
>  import libevdev
>  import os
>  import pytest
> +import shutil
>  import subprocess
>  import time
>  
> @@ -240,6 +241,10 @@ class BaseTestCase:
>              root_dir = (script_dir / "../../../../..").resolve()
>              bpf_dir = root_dir / "drivers/hid/bpf/progs"
>  
> +            udev_hid_bpf = shutil.which("udev-hid-bpf")
> +            if not udev_hid_bpf:
> +                pytest.skip("udev-hid-bpf not found in $PATH, skipping")
> +
>              wait = False
>              for _, rdesc_fixup in self.hid_bpfs:
>                  if rdesc_fixup:
> -- 
> 2.44.0
>