Received-SPF: pass (google.com: domain of linux-kernel+bounces-170777-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: He Zhe <zhe.he@windriver.com>
To: namhyung@kernel.org, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        irogers@google.com, adrian.hunter@intel.com
Cc: zhe.he@windriver.com, linux-perf-users@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] perf bench: Fix trap divide error of perf bench internals inject-build-id
Date: Tue,  7 May 2024 14:50:26 +0800
Message-Id: <20240507065026.2652929-1-zhe.he@windriver.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?SY0GFv9QyjVFykE8k8r6Da7VhCcuwV2d7wJGKYiPgEzdtKipTHoJElqhKwER?=
 =?us-ascii?Q?p1nS5q4pxKn1YPrG8wLcN0SPqBJ9LtrojQLGy/jDYAUlQxUvNGvVbKT8nQP/?=
 =?us-ascii?Q?RAro9237Y2jAjE/oct+OKy7E6PgM81s70pfNqpBGrk2gTo8dhhAX4KFvYVwX?=
 =?us-ascii?Q?FuJ4nXtrXLKurUDV/iqGlhXX1eP1qg0S9vXw6PPnC6USa2aE92/bFB0lZDOR?=
 =?us-ascii?Q?D1ck7cJiKVrRarWzWg3jCgmmq8C3AK+20wc3bWQb61g2itTsk03aB/rItcnx?=
 =?us-ascii?Q?H37coh+u7z3tq0dUVX8gQVysRtOErNQfjLXlxCOoEfJubOuoHUiRf1Bs/i83?=
 =?us-ascii?Q?Pq5qDvZfc5hGyh5NjNZQwIWHV+9ttyEFsTofSe2qXMDHVuELpBxdrJ2/tDXi?=
 =?us-ascii?Q?XSkIdFUdexeGmyJ5BOPR7ytGz5EE/d5e3tLg/S6emup8SlMj9SGYDuonLktX?=
 =?us-ascii?Q?lVmpOJM1EOD7wk0soz2fxuzjf8LWHE36/j4tjUJ4lf7JZhnIP0SqeC868bif?=
 =?us-ascii?Q?q/ERhllAW0MrtkIz7WiwUn+mgdwCZZiA0+gNlKg3C/8bJB7HmtC2mcMIrAV8?=
 =?us-ascii?Q?ZRgwNEEqgAVbxOsGXsc7YfRtV+lHsJzITp8kLNhpwUhfeNF02hWDbzmhCoo6?=
 =?us-ascii?Q?kKi1BIjS3Gou+OZnGhWZsOlmN5DhUUcFTQzUeTeGKXo7LtFCG7XhCtr+PT8g?=
 =?us-ascii?Q?L2Saq8kPQkRdsNMpsj/E0MvwLp9PPP4QiVgvEHS5cU2+WiI5zRUyUJsThN55?=
 =?us-ascii?Q?SBEPF/e0XM6Wr1A98D+4OYgE1bdIzPU21VBhyyySK7aup2ClrU2PejBpjZT4?=
 =?us-ascii?Q?Rii1FNVAdejfqRrq7MajP4XjkmLVKvGPWmwHk9ksIzYYXTiX1F9ESrXnVAcg?=
 =?us-ascii?Q?uMjujmOBmeSd5Ggrl0FBMZ+A067xU/avV4fMiIIQhSRxecGeicqr8VzOfgBB?=
 =?us-ascii?Q?+ZyzaCYa2aRDrTKIHSoldkugUmVjWUm7rKTSBUF30jwAikf9koRIUF1eEtrU?=
 =?us-ascii?Q?/AZ1Mvc+qTGbb4vSSc6YenUJ9500xr+UR30ZsZhfXInEvEGoA/MGIlhUgyUP?=
 =?us-ascii?Q?QLW1lJVD2dtbBPblzPYA50RJl4QBxlzBLwJbtL0ICJ07TLosq0qBHo8H57Jz?=
 =?us-ascii?Q?QWWWvBKZoMOcq7hd/OTQKBsrMsJEtRAvibfVZKYIr7xulZvgBKfKx4pNAmPI?=
 =?us-ascii?Q?GMz+t0AguuXS/WD9F+Cr/br+qCl+k58SOr33U+yVntaXybJ21C5amhn7ldA6?=
 =?us-ascii?Q?oGfY2aY1HxGjBuBBD5oRPfWyeZtG4uuTBlBW4KSyqLMU95+7fa00Hj9fschL?=
 =?us-ascii?Q?R5zBYHiiB9q5hru5NVix2PhXynuAkP8ZLvrEff9TK7ToTIBreFEGCiacG4oh?=
 =?us-ascii?Q?s2zs06O2t/MpXz+FVupayI09vO465dz2tklADCK7CVleda2q2wJf2B+eZVUU?=
 =?us-ascii?Q?FIGMupC7h9LzxpgpO4Z3Hk/39QvF76lBmpnEsa+15I4Y6PF+89U3rQ6wy9oc?=
 =?us-ascii?Q?tPAOfZk+Val+vNB8qGPBOVXHVhZZCfC50nQuTQZ6k9alRaiJ5kuKmlqMMqxs?=
 =?us-ascii?Q?mDOIqQC20MJfunEhU96Ua1ZcD54RPSGfsWLZGuoO?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05bac93f-ed66-4e3e-a275-08dc6e620737
X-MS-Exchange-CrossTenant-AuthSource: SA3PR11MB7527.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 06:50:49.0415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1RgLr+tG+qPVwYVC+0+sAXKn/WU9fXD5cwOV4lGWm1cOaC613SYrxiG040BGWW3UqAckV02Vx8C8VbAUmjDdxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6019
X-Proofpoint-ORIG-GUID: yXRIa_82cqGIDP4xKt32oqVefADkagrJ
X-Proofpoint-GUID: yXRIa_82cqGIDP4xKt32oqVefADkagrJ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-07_02,2024-05-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0
 mlxlogscore=999 clxscore=1011 suspectscore=0 adultscore=0 spamscore=0
 lowpriorityscore=0 bulkscore=0 priorityscore=1501 mlxscore=0
 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.19.0-2404010003 definitions=main-2405070046

perf bench internals inject-build-id suffers from the following error when
only one DSO is collected.

perf bench internals inject-build-id -v
  Collected 1 DSOs
traps: internals-injec[2305] trap divide error
ip:557566ba6394 sp:7ffd4de97fe0 error:0 in perf[557566b2a000+23d000]
  Build-id injection benchmark
  Iteration #1
Floating point exception

This patch removes the unnecessary minus one from the divisor which also
corrects the randomization range.

Signed-off-by: He Zhe <zhe.he@windriver.com>
---
 tools/perf/bench/inject-buildid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/bench/inject-buildid.c b/tools/perf/bench/inject-buildid.c
index 49331743c743..a759eb2328be 100644
--- a/tools/perf/bench/inject-buildid.c
+++ b/tools/perf/bench/inject-buildid.c
@@ -362,7 +362,7 @@ static int inject_build_id(struct bench_data *data, u64 *max_rss)
 		return -1;
 
 	for (i = 0; i < nr_mmaps; i++) {
-		int idx = rand() % (nr_dsos - 1);
+		int idx = rand() % nr_dsos;
 		struct bench_dso *dso = &dsos[idx];
 		u64 timestamp = rand() % 1000000;
 
-- 
2.25.1