Received-SPF: pass (google.com: domain of linux-kernel+bounces-170768-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 6 May 2024 23:40:25 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Chandan Babu R <chandan.babu@oracle.com>, linux-xfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] xfs: check for negatives in xfs_exchange_range_checks()
Message-ID: <ZjnM2QBtL68KJtio@infradead.org>
References: <0e7def98-1479-4f3a-a69a-5f4d09e12fa8@moroto.mountain>
 <ZjnE2SjU7lGD0x5A@infradead.org>
 <d953392c-44d1-4c9f-a671-b25803181b97@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d953392c-44d1-4c9f-a671-b25803181b97@moroto.mountain>

On Tue, May 07, 2024 at 09:33:40AM +0300, Dan Carpenter wrote:
> On Mon, May 06, 2024 at 11:06:17PM -0700, Christoph Hellwig wrote:
> > On Sat, May 04, 2024 at 02:27:36PM +0300, Dan Carpenter wrote:
> > > The fxr->file1_offset and fxr->file2_offset variables come from the user
> > > in xfs_ioc_exchange_range().  They are size loff_t which is an s64.
> > > Check the they aren't negative.
> > > 
> > > Fixes: 9a64d9b3109d ("xfs: introduce new file range exchange ioctl")
> > 
> > In this commit file1_offset and file2_offset are u64.  They used to
> > be u64 in the initial submission, but we changed that as part of the
> > review process.
> 
> I've just checked again, and I think it was loff_t in that commit.
> There are two related structs, the one that's userspace API and the
> one that's internal.  The userspace API is u64 but internally it's
> loff_t.

Ah, yes.  The in-kernel ones probably just needs to move to use u64
as well.