Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp366973lqh; Tue, 7 May 2024 01:13:48 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUyBPCZoOPWSIQxS65k6FN2HgZk7GQEpSwcL4dP9WuarSp+jLAOywNeh3K7QdBK1oPutPU7b75/inEv0czMzmEcPct1JmQRQyZZ6s+cKA== X-Google-Smtp-Source: AGHT+IEKW0qJf2vUEF799os+/GCHqS14vFKAOcizBtfhGAjYuFGw2mnJbVR+7yM3RNBhZJoqj3tz X-Received: by 2002:a17:906:7009:b0:a59:efd0:e884 with SMTP id n9-20020a170906700900b00a59efd0e884mr517810ejj.27.1715069627931; Tue, 07 May 2024 01:13:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715069627; cv=pass; d=google.com; s=arc-20160816; b=LngWrduLrbpjaY2jtN4K0SorQ40AUp3LItT6xizqdSPhfZd5ZYeU47P28RpwgZx9nb QhnbhMFpU0FzdMGMwQpKUB13viC7PciimXuLBH44G5qL2Uc+NsYgCtJZZuTSlmnon5/g yzDyNhB+RecAfxX1914A23z4pjL/JafSzfFmjimOSumfeKl/wWjKDZX8Nxf4laexyaoe +gORflK9oCu0GQR2/TFnrOPZyQDoSjMfbytR3FXciRwdpSfh18gblp7T3zbDIlAM8VV8 YvT0rQSq/viRykztfRB2bpPp9VoXFDeYuY4jqo+MLmmKymeZDx7J9BakxOMRp7Wz0+lW HN5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=0D7kJ1qnE1ifbGitHrjWMHHalzkwljHgHWRhLR/9vEU=; fh=8pQ9Gm5MBu4E5BzwDl6Hkp2VeEgcEVfDG++cdUbS6kM=; b=z9rZeBo/nzZZNW3Sxlma6xD01pgRp0/1qrFYWby212bxP1lTOHuuY65DnX0yabLCNm ZJAWY8wkEVprJDxgLZcpKwZi7HXq0v2vvMj21gi3BQqOM4zPPxey+TjWkL1L+3gbRWLE NN0m0U8PEwMt3/zxB45AHE7kaSXGy87WkzCBLLnKJhmGXd0O2eK2amFtGAmjpAVxJo8m XdU8A6zThBrUReYga8VlDXT8BxPDlebQQg5UsqUBV6NBVE/ttw5G0zBvjwvDR9OPq6Q7 RtyLut1jmRLmWqvg12lTkL6UBJSVyy/U8Dx3AAccCkUMa2vzlmMwZ7GpXumeiy7DlR0I k/sQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BHLeldDj; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-170855-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170855-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id i20-20020a170906251400b00a59ab2b9a1csi3451205ejb.17.2024.05.07.01.13.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 01:13:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170855-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BHLeldDj; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-170855-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170855-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A87E51F21F48 for ; Tue, 7 May 2024 08:13:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 78A8313C902; Tue, 7 May 2024 08:13:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BHLeldDj" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F87E13C83C for ; Tue, 7 May 2024 08:13:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715069620; cv=none; b=u2GleN1R9/iHR2st+pEwnBQHHAjtXl5FeHgIoXJ+11YlSKdKTf0U2/G5NTSUiysN7IbppVyJ4SLi8kjZrJ3QzLO8hgnEZ7fRI9TD+dK+PXWJVwAJa8Nza32Ty+VGbDtVeEWgnvoRGrmEIerS7KJyEKpKpiOdSg2x5ZhApkVVAQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715069620; c=relaxed/simple; bh=pQZ460S954Xbp1GD9EA04b/dSVz3MlCUGoUOo0OYf+k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k0eW++wNdA3EX85bTziSJ/YOx6fRr4Ys+tz1hlbbOExqt87eb5kAcDWNIgbHdlTyks6UlyZPgJ/mUb1VWzGCG24VcuDLWwxzYbhJx1ikUTXL/7MyRe7qwqsYqQtTUmwDTPdmvbb/2WXODbKTzC+wMKk9xEeXUOSghiY1s3Eeb8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BHLeldDj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715069617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0D7kJ1qnE1ifbGitHrjWMHHalzkwljHgHWRhLR/9vEU=; b=BHLeldDjoEzlvmylTlHdElLwaD9rXBnoeGinMPjcyzBnuRg8A58xFTS2HPTU/aJCieBuwE gabqw2CZm1UIlYS2TWbv0VUH/UcIYPg47jue5kj7h8TmnxsKcFIwoWVDaBFM2MzE1X2ClC aY9jDUaDGLBVkL5glYuLBHPcmcB6SfI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-XN3DkVbyPZKAVHAMyBcojQ-1; Tue, 07 May 2024 04:13:36 -0400 X-MC-Unique: XN3DkVbyPZKAVHAMyBcojQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-418df23b51cso15126525e9.1 for ; Tue, 07 May 2024 01:13:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715069615; x=1715674415; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0D7kJ1qnE1ifbGitHrjWMHHalzkwljHgHWRhLR/9vEU=; b=RQanVNZFHFQoXKdl8QGgInuUNKIT34s/BG9DXCbGhTkjWMmwV1/wUablCU/IDqfUKv F5P+nFiwicTGWMe9slXZPvpLeabxsDERA2fVLNhexfCF7LgHSRAl7OU878kXy/w8iZ64 dQirNxFrWbKBTxqirOL0VgFlOcRzZLFbxXOJXiKYVY6uFz66I4NMCWdh6vZ5jQ1NDaRZ zi0oYs4IkgkUdFQWnuTj0LsyRuVsWmYXe5sBKaF+D6yf4XQT2JHySIvHmxs5sWzDlkDq S5bsshgydumrwykcn8oZO1sPmVtKva4SZoV8YVsvB83PbDpS9W7sD7vP6GU4ntbBhPb+ NEQA== X-Forwarded-Encrypted: i=1; AJvYcCWUEp9lLxvU41apwUlsv7Jt7a3AaahUK6SQdoeHRXNTf98B0trKcoToPjjQpT9QbSwsNiKnDVGnWxLawYfFRYb421UN4zFdFDgZ4ZQ9 X-Gm-Message-State: AOJu0YzSnhVmfDzhKuQs9g6upJ1OHsqY7t9mqOVNFX9gFXeL7xqD+Q/d 5ZNJcB3n9yDpYB7rLwawNY1nY/k8MdHY9pyiNviRfx9y4elWWQtiXoHVlXddQBejmYkkRRR1vgi masExybynY52mQCh2zH0mVyG4CMcwzw5OPflkelHOy1gIa8GidWfcy+3JSzg/hg== X-Received: by 2002:a05:600c:3512:b0:41a:c92:d323 with SMTP id h18-20020a05600c351200b0041a0c92d323mr9227587wmq.10.1715069615377; Tue, 07 May 2024 01:13:35 -0700 (PDT) X-Received: by 2002:a05:600c:3512:b0:41a:c92:d323 with SMTP id h18-20020a05600c351200b0041a0c92d323mr9227559wmq.10.1715069614957; Tue, 07 May 2024 01:13:34 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id j15-20020a05600c190f00b0041bf512f85bsm22268129wmq.14.2024.05.07.01.13.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 May 2024 01:13:33 -0700 (PDT) Message-ID: <016d8cff-efc3-4ef1-9aff-7c21c48f2d69@redhat.com> Date: Tue, 7 May 2024 10:13:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/fault: speed up uffd-unit-test by 10x: rate-limit "MCE: Killing" logs To: John Hubbard , Andy Lutomirski Cc: Dave Hansen , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , LKML , linux-mm@kvack.org, Peter Xu , Axel Rasmussen References: <20240507022939.236896-1-jhubbard@nvidia.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240507022939.236896-1-jhubbard@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The patch subject is misleading. This should be "don't flood the system log". Nobody cares about the speed of a unittest ;) On 07.05.24 04:29, John Hubbard wrote: > If a system experiences a lot of memory failures, then any associated > printk() output really needs to be rate-limited. I noticed this while > running selftests/mm/uffd-unit-tests, which logs 12,305 lines of output, > adding (on my system) an extra 97 seconds of runtime due to printk time. Recently discussed: https://lkml.kernel.org/r/a9e3120d-8b79-4435-b113-ceb20aa45ee2@alu.unizg.hr See the pros/cons of using ratelimiting, and what an alternative for uffd is that Axel is working on. (CCing Peter and Axel) -- Cheers, David / dhildenb