Received-SPF: pass (google.com: domain of linux-kernel+bounces-170858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <5305f69bd74d4d4ecff518b42287fbc4b9204918.camel@suse.com>
Subject: Re: [PATCH] firmware: dmi: Add info message for number of populated
 and total memory slots
From: Jean DELVARE <jdelvare@suse.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date: Tue, 07 May 2024 10:16:11 +0200
In-Reply-To: <b1d69d07-14a9-4f10-9155-a0a46d8ea872@gmail.com>
References: <b1d69d07-14a9-4f10-9155-a0a46d8ea872@gmail.com>
Organization: SUSE Linux
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi Heiner,

On Tue, 2024-03-05 at 21:55 +0100, Heiner Kallweit wrote:
> As part of adding support for calling i2c_register_spd() on muxed SMBUS
> segments the same message has been removed from i2c_register_spd().
> However users may find it useful, therefore reintroduce it as part of
> the DMI scan code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/firmware/dmi_scan.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> index 015c95a82..2c682b580 100644
> --- a/drivers/firmware/dmi_scan.c
> +++ b/drivers/firmware/dmi_scan.c
> @@ -42,6 +42,7 @@ static struct dmi_memdev_info {
>         u8 type;                /* DDR2, DDR3, DDR4 etc */
>  } *dmi_memdev;
>  static int dmi_memdev_nr;
> +static int dmi_memdev_populated_nr;
>  
>  static const char * __init dmi_string_nosave(const struct dmi_header *dm, u8 s)
>  {
> @@ -448,6 +449,9 @@ static void __init save_mem_devices(const struct dmi_header *dm, void *v)
>         else
>                 bytes = (u64)get_unaligned((u32 *)&d[0x1C]) << 20;
>  
> +       if (bytes)
> +               dmi_memdev_populated_nr++;
> +
>         dmi_memdev[nr].size = bytes;
>         nr++;
>  }
> @@ -824,6 +828,8 @@ void __init dmi_setup(void)
>                 return;
>  
>         dmi_memdev_walk();
> +       pr_info("DMI: Memory slots populated: %d/%d\n",
> +               dmi_memdev_populated_nr, dmi_memdev_nr);
>         dump_stack_set_arch_desc("%s", dmi_ids_string);
>  }
>  

Applied, thanks.

-- 
Jean Delvare
SUSE L3 Support