Received-SPF: pass (google.com: domain of linux-kernel+bounces-170863-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 7 May 2024 09:23:15 +0100
From: Lee Jones <lee@kernel.org>
To: Ben Greear <greearb@candelatech.com>
Cc: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info>,
	LKML <linux-kernel@vger.kernel.org>, linux-leds@vger.kernel.org,
	Miri Korenblit <miriam.rachel.korenblit@intel.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	Linux regressions mailing list <regressions@lists.linux.dev>
Subject: Re: 6.9.0-rc2+ kernel hangs on boot (bisected, maybe LED related)
Message-ID: <20240507082315.GS1227636@google.com>
References: <30819e01-43ce-638f-0cc6-067d6a8d03c7@candelatech.com>
 <89a9eec3-337f-3c9f-6bbe-00a26a15287c@candelatech.com>
 <20240411070718.GD6194@google.com>
 <de43c7e1-7e8c-bdbe-f59e-7632c21da24a@candelatech.com>
 <8736ebc8881e1e0cabfbbf033725a3123a5e8e90.camel@sipsolutions.net>
 <bc420f3a-5809-4c4a-80ad-ccd8a46853b6@leemhuis.info>
 <8ab88be5de30bcbd0d1cac3cfde6b2085dcfc8fb.camel@sipsolutions.net>
 <0197efe8-828b-43ae-85c9-5d521913a289@leemhuis.info>
 <20240502071908.GB5338@google.com>
 <8054cc9c-fbfe-a08d-5968-57b90a25af65@candelatech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8054cc9c-fbfe-a08d-5968-57b90a25af65@candelatech.com>

On Sat, 04 May 2024, Ben Greear wrote:

> On 5/2/24 00:19, Lee Jones wrote:
> > On Tue, 23 Apr 2024, Linux regression tracking (Thorsten Leemhuis)
> > wrote:
> > 
> > > On 23.04.24 11:06, Johannes Berg wrote:
> > > > On Tue, 2024-04-23 at 11:00 +0200, Linux regression tracking
> > > > (Thorsten Leemhuis) wrote:
> > > > > On 16.04.24 08:17, Johannes Berg wrote:
> > > > > > On Mon, 2024-04-15 at 13:37 -0700, Ben Greear wrote:
> > > > > > > 
> > > > > > > Johannes, you had another suggestion: changing iwlwifi's
> > > > > > > request_module() to request_module_nowait() in
> > > > > > > iwl_req_fw_callback()
> > > > > > > 
> > > > > > > Is that still best thing to try in your opinion?
> > > > > > 
> > > > > > I guess so, I don't have any better ideas so far anyway ...
> > > > > 
> > > > > [adding the iwlwifi maintainer; thread starts here:
> > > > > https://lore.kernel.org/lkml/30f757e3-73c5-5473-c1f8-328bab98fd7d@candelatech.com/
> > > > > 
> > > > > ]
> > > > > 
> > > > > Johannes, Miri, what's the status wrt to this regression? From
> > > > > here things look somewhat stalled -- but maybe there was
> > > > > progress and I just missed it.
> > > > 
> > > > What do you want? It got bisected to an LED merge, but you ping
> > > > _us_? Way to go ...
> > > 
> > > Sorry, to me it sounded a bit like you had an idea for a fix and
> > > were going to give it a try -- similar to how the maintainers for
> > > a r8169 driver and the igc driver provided fixes for bugs recent
> > > LED changes exposed.
> > > 
> > > But sure, you are right, in the end some LED change seems to have
> > > cause this, so the duty to fix it lies in that field. Therefore:
> > > 
> > > Lee, what's the status here to get this fixed before the final?
> > 
> > No idea.  Did you send a fix?
> 
> I sent what is probably just a work-around.  I also spent time
> bisecting and testing. The problem appears to have come in with the
> LED related merge.  I think it is fair to ask the LED folks to at
> least take a look at the lockdep debugging I posted.

I can't speak for Pavel, but I personally have no way of debugging or
reproducing this.  The only usefulness I can provide is to review and
apply fixes as and when they appear.

> It is not fair to expect anyone that manages to find or track a bug to
> also fix it.

No such expectation has been felt or communicated.

-- 
Lee Jones [李琼斯]