Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758269AbYA2XRv (ORCPT ); Tue, 29 Jan 2008 18:17:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754532AbYA2XRn (ORCPT ); Tue, 29 Jan 2008 18:17:43 -0500 Received: from de01egw01.freescale.net ([192.88.165.102]:42010 "EHLO de01egw01.freescale.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753780AbYA2XRm (ORCPT ); Tue, 29 Jan 2008 18:17:42 -0500 From: Timur Tabi To: apw@shadowen.org, linux-kernel@vger.kernel.org Cc: Timur Tabi Subject: [PATCH] checkpatch: add __asm__ to function-space-paren exception list Date: Tue, 29 Jan 2008 17:17:28 -0600 Message-Id: <12016486482483-git-send-email-timur@freescale.com> X-Mailer: git-send-email 1.5.2.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 32 checkpatch.pl thinks that __asm__ is a function name, so it complains about a space between the function name and a parenthesis when it sees "__asm__ ("mov ax,bx")". This change will also encourage developers to use '__asm__' instead of 'asm'. Signed-off-by: Timur Tabi --- scripts/checkpatch.pl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 579f50f..971c822 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1115,7 +1115,7 @@ sub process { # check for spaces between functions and their parentheses. while ($line =~ /($Ident)\s+\(/g) { - if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case)$/ && + if ($1 !~ /^(?:if|for|while|switch|return|volatile|__volatile__|__attribute__|format|__extension__|Copyright|case|__asm__)$/ && $line !~ /$Type\s+\(/ && $line !~ /^.\#\s*define\b/) { WARN("no space between function name and open parenthesis '('\n" . $herecurr); } -- 1.5.2.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/