Received: by 2002:a89:288:0:b0:1f7:eeee:6653 with SMTP id j8csp371094lqh; Tue, 7 May 2024 01:25:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUMoBl+zC7sKOokulcPCzD0fOp/c+kbeqEGZIRbS4sD+vASYXobLHRa/tsaK1RnvvWAlVHohCI3qHcx6t7/Llxsdawkt7HbXwqk7i47Lg== X-Google-Smtp-Source: AGHT+IEdAgSftCuvOz8LYpiRCASLM2UER2LDAmxK3dK+n5Pmqgz21iCxPuvIPU0pnraMxASfhInO X-Received: by 2002:a05:6359:4c1c:b0:192:84cb:925d with SMTP id kj28-20020a0563594c1c00b0019284cb925dmr718895rwc.8.1715070327849; Tue, 07 May 2024 01:25:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715070327; cv=pass; d=google.com; s=arc-20160816; b=JiIEj9Lp+PZa9oUoySwheVznbVUgw44dxQsAWCP9V3rIDKxa4O0lVxvrViq79b98Ti gttdNqwiQ69Zd7mE/RhH1gSNDjgfw3OJrSLZ4tFNwabK2QIdyrg4UqpsALw1xmlopQYq wpxIw0p3mAqZikUxYjnbst7a1EiLdn0+40CA0eO9orGiDvAWqp/sAca0VTlS+yeUi4CG seWh+MRiN0c1E/uGp02HxlTAuPncRORoDFi08XdzN99pPLp/xV2Xb0wRbjcvidgsVjhP ZI3bHsXBTO0JNAI7TprVBmku/wFYXHmehBEwe1r8Y3s5FylbMSWm5mQLUQrhoUij8NlG DNyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=F5DZY8gU0+Joi+JnnaHOWLrQHFkVrDgQianYT2ENUU8=; fh=rvosZWcK4NKA3dFolT82e3wTHpHXd+V9i4gl1vlehzc=; b=rsRnaZ+33R9antqkzBerlW99+CJ9Al4EW2HmL0wmIP3B5PtrIR4QcgjkZg7x/HDKij 77gMy9KKtzDiiIlmCmH1ffKMZPUmuxvT4sv1hdQuJQa3QlneE6wQr4Cqkx177V1Ds3bA l6zzU7GoVZZWu8Gj5CA7aEcsiKamGfUuYvc3+NqzJljEKrAlySY8K/4CKkDpusR3oj10 REPSFCWtGVEDlurtzj7io19FMm9kWbBU028uMEKyz9qW/FjKBw2TouPVhw/kD8yXtj8k a5RK4C0GHSTI2YWPOWoD0JHavq50R7N9nA+sftgOrNitwz9snlgXpkjhJGoTRLV2XivF vhLA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=uFrcjpQY; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-170866-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170866-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id a21-20020a637f15000000b0061d28a12cbesi8711988pgd.93.2024.05.07.01.25.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 01:25:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-170866-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=uFrcjpQY; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-170866-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-170866-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id AB890B2146B for ; Tue, 7 May 2024 08:25:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C590613C9B1; Tue, 7 May 2024 08:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="uFrcjpQY" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FFD513C8FE; Tue, 7 May 2024 08:25:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715070313; cv=none; b=ufEQSr23KvLo1HJwx57O90S5hje+GqzXcn0JYndxqGYZ+Rwj2gI5d3t2yL/L5N97ec6YMrjjtKEt7E4LsRCR4xJ6HLzyTB16KemLZU8XKr3TjTmWNj0iAR/cjD226DLuPyakYeHspNzquwuOiOKSy+d0SAPQU3tZjsVqHBkCaug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715070313; c=relaxed/simple; bh=aO/h+F2//p2M80GykcrtBjuSGZbnrmUKjiredPkuMzg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gHapn0aaeds8r7TajkI0ta6tQJg8k7zPwd7CV7XBlysyVeaXLbiIa5xciKViLuug/M3OtnGyAT2deqRJMopxqXhiA4eOfYo6UOItTTM1j0vhdPX/ghTiouZfIEjlknk4suA9vo2ZSXM3ABekJsG2W6ZuJuxXLFP0+W0q+S0IyhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=uFrcjpQY; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=F5DZY8gU0+Joi+JnnaHOWLrQHFkVrDgQianYT2ENUU8=; b=uFrcjpQYVjV7Qo7+4gBRP9/uln tRp2hHvTWZq3OjM10nvDmB0FX2qA23iNLxx/dk1VWPNglPXHV8ooivvU9olm9f1NzS79jp7x2Ql03 0cWYggr9wCynIE3GSjn54yklLtQuPJ1GGh20wwxoUikGR588wNN/JCG4i7hnIGQwJ2NFAZsZLeOk2 cZNFp8o9XxMkG0rJb/Oxpfw/vXVWT6DM7f22KLh/bMADx0SouTSAR6UsN+6GpcfacDtdko4NG17Jk ZOKY8OGW+QFsVN7mJOIXUBUU3dKll5r76pbhrcy9epbFXWxq7NoGouX+wiwAPJRXcFcHirUa94cxw umUkP4lA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:50346) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s4G8G-0003RS-0R; Tue, 07 May 2024 09:25:04 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1s4G8F-0000BQ-M4; Tue, 07 May 2024 09:25:03 +0100 Date: Tue, 7 May 2024 09:25:03 +0100 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Raju Lakkaraju , netdev@vger.kernel.org, lxu@maxlinear.com, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com Subject: Re: [PATCH net-next] net: phy: add wol config options in phy device Message-ID: References: <20240430050635.46319-1-Raju.Lakkaraju@microchip.com> <7fe419b2-fc73-4584-ae12-e9e313d229c3@lunn.ch> <4a565d54-f468-4e32-8a2c-102c1203f72c@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a565d54-f468-4e32-8a2c-102c1203f72c@lunn.ch> Sender: Russell King (Oracle) On Mon, May 06, 2024 at 03:28:33AM +0200, Andrew Lunn wrote: > You should first answer Russell question. It could be a totally > different scheme might come of of the discussion with Russell. Yes please. We definitely need to get to the bottom of what is going on here _before_ we come up with a solution. If we don't understand the problem, whatever fix gets proposed is probably going to be nothing more than a bodge job - and then someone else is going to have a problem and propose another bodge job and so we'll end up with bodge job on top of more bodge jobs. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!