Received-SPF: pass (google.com: domain of linux-kernel+bounces-170872-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Zhao, Yan Y" <yan.y.zhao@intel.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>
CC: "iommu@lists.linux.dev" <iommu@lists.linux.dev>, "pbonzini@redhat.com"
	<pbonzini@redhat.com>, "seanjc@google.com" <seanjc@google.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"luto@kernel.org" <luto@kernel.org>, "peterz@infradead.org"
	<peterz@infradead.org>, "tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de" <bp@alien8.de>,
	"hpa@zytor.com" <hpa@zytor.com>, "corbet@lwn.net" <corbet@lwn.net>,
	"joro@8bytes.org" <joro@8bytes.org>, "will@kernel.org" <will@kernel.org>,
	"robin.murphy@arm.com" <robin.murphy@arm.com>, "baolu.lu@linux.intel.com"
	<baolu.lu@linux.intel.com>, "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH 1/5] x86/pat: Let pat_pfn_immune_to_uc_mtrr() check MTRR
 for untracked PAT range
Thread-Topic: [PATCH 1/5] x86/pat: Let pat_pfn_immune_to_uc_mtrr() check MTRR
 for untracked PAT range
Thread-Index: AQHaoEaluFlXp2ccfkynqcQr/+5ZoLGLbskw
Date: Tue, 7 May 2024 08:26:37 +0000
Message-ID: <BN9PR11MB5276DA8F389AAE7237C7F48E8CE42@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240507061802.20184-1-yan.y.zhao@intel.com>
 <20240507061924.20251-1-yan.y.zhao@intel.com>
In-Reply-To: <20240507061924.20251-1-yan.y.zhao@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3cX+e2A7AHwhZ1znJyo70tYOCXFZz5RQ63Pn+PUiZ2qWtyhcN4vPNo8MmLMa?=
 =?us-ascii?Q?Bhe/fwXw+6PwHYC2jCQkBFFLwDDnd6Kmk2qe72dXKo579V4m9DvCLAasjuol?=
 =?us-ascii?Q?TqyRzE2fnT7wfHZ3Svnng1YbovBunIq1uWJY2T4rhkCzlDFbYMdVYlF1Lfvb?=
 =?us-ascii?Q?zwjFIwjrdCxo9YRZ7xdmEoMjhfx6/AyqYRQcQC9rhFcRl82IKP+XDE+gzloB?=
 =?us-ascii?Q?m7lZ25g/2kg3/PJwRwagl49fJnUaokhj/mSjoNRSV90fXtQD4EmX0S+ZgHKt?=
 =?us-ascii?Q?4KnWf4sMjPblENTXfYvxUnM2DzVgQYAnP6R8sMAiiPiyPINyPxwxkTcMojGx?=
 =?us-ascii?Q?AMnfRPw1QVOndsezigJLt9/S4f2N09xaAb10MtHYQtR8gn8khWP0Wxza+Nig?=
 =?us-ascii?Q?6M4+Es3Xmcrexib51fly85xjQBX1uoOmlKEFzpPyPCxFWa+JWWje0vMlLZV9?=
 =?us-ascii?Q?AB7ywVb+EK6a4DS9K2/QZ0wgqIYwNva3Dok4bx5ZV2gddQfpctUorE8SAGf1?=
 =?us-ascii?Q?eP5tHQlt3TH48UJhB2U7zHRTVwZEXsFOG8UeaKJqpqpUBKAkCtaQ2X9+ZEZ1?=
 =?us-ascii?Q?A7S+06AHPojnYCwWvwh+a+Nzx+8q4pUVywK3a3yna45FNd8KmUL5nOzTPrwB?=
 =?us-ascii?Q?UmRTXR/kDcV3xm024OKIF7d3lY4VQzPltygOmx+RSpbd0wcpXa3t+JJ9KEA8?=
 =?us-ascii?Q?xV8iSYvFNW/iirXpLkFQwgDJZR+hQNrM7hY81VJoEHL4mEnj+90LfSCeQSbC?=
 =?us-ascii?Q?Jt1+nmV7Cdv9DE73NQFWwFKqs1YzgmkyVrcD2nhkaz2Ms377YZtyG/Jhv8O+?=
 =?us-ascii?Q?+qGzDuyAjb/s5K+6K7l+Ssyh2flNlT5kp0dIW5GOhU4KHV/GjduAuHn+D//H?=
 =?us-ascii?Q?yF5OKkq3hITO9OC4xPGp+vWmY6Ve234oSq0zMoqPpDZA63jYmnugVcJfoBtW?=
 =?us-ascii?Q?qtEQ/wOeQWcqAITQA3NBIDrVlD2l4Um0OBHQyk9zRhJtf79GAqyipEiv9wXe?=
 =?us-ascii?Q?Pv4U10nH41pR8MomyFpz1F0Xn7ihg/5rKsS6w3Q3iukcCZ2cMAhLbZBCB/7M?=
 =?us-ascii?Q?EzYyBrrEXuRai2lQcwEQAFdMkWCDL/D4PqX9y/zPnbghDzTr7EB2aZNG5kdM?=
 =?us-ascii?Q?KelxzPExZHJl07UUm/YncIVO8Yhd8OefcC5FSYIZKX3yvEd2wcXUu70CvMSj?=
 =?us-ascii?Q?Se5MPw7FnIEyEibGIYx0F06h/oxke3KWCPq0DVSptvkTkAnveEPbQz2b/NxV?=
 =?us-ascii?Q?dUlLDxdvaLoOJqkTCi478j22cSmSVu1mMBFEz/0pm8VM/8DYnIVKYO3QDF4+?=
 =?us-ascii?Q?iLQDBJ6RM7lEBEK14RyRt5zrWRiMRIt4EkMe3ydVZNAHs8GIzWwWwno7z63W?=
 =?us-ascii?Q?4OOzuUrXsfqmrG+AUpDHd+JnfyC1P5JlSpGC7pTNexJ2lcQyt3sLT98q8YDR?=
 =?us-ascii?Q?eYG+Iuta2w2YuPiJelV2hVAHO8Oca0smd88S44C/QoTITWusswy9AhwxWBvi?=
 =?us-ascii?Q?dY/H53elL4BUh4BH5XFPXtdBvYMCmdocn1znZkfmsOOhxeflNBPsp20ngfUS?=
 =?us-ascii?Q?eyJ7uyj0kMapLlLcGYM3CE7RG5UJdGyt4b/ffIX+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb03a302-c1b4-4e71-1a20-08dc6e6f6a25
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2024 08:26:38.0769
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: xaDCPSNtP6Ovmj78VwYqcBU99bt9DgRzJvTRDqGZQOpfDSexmk5M1U9dLUaziuBBTINLfsNyqgOJImeIsSbAjg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6171
X-OriginatorOrg: intel.com

> From: Zhao, Yan Y <yan.y.zhao@intel.com>
> Sent: Tuesday, May 7, 2024 2:19 PM
>=20
> However, lookup_memtype() defaults to returning WB for PFNs within the
> untracked PAT range, regardless of their actual MTRR type. This behavior
> could lead KVM to misclassify the PFN as non-MMIO, permitting cacheable
> guest access. Such access might result in MCE on certain platforms, (e.g.
> clflush on VGA range (0xA0000-0xBFFFF) triggers MCE on some platforms).

the VGA range is not exposed to any guest today. So is it just trying to
fix a theoretical problem?

> @@ -705,7 +705,17 @@ static enum page_cache_mode
> lookup_memtype(u64 paddr)
>   */
>  bool pat_pfn_immune_to_uc_mtrr(unsigned long pfn)
>  {
> -	enum page_cache_mode cm =3D lookup_memtype(PFN_PHYS(pfn));
> +	u64 paddr =3D PFN_PHYS(pfn);
> +	enum page_cache_mode cm;
> +
> +	/*
> +	 * Check MTRR type for untracked pat range since lookup_memtype()
> always
> +	 * returns WB for this range.
> +	 */
> +	if (x86_platform.is_untracked_pat_range(paddr, paddr + PAGE_SIZE))
> +		cm =3D pat_x_mtrr_type(paddr, paddr + PAGE_SIZE,
> _PAGE_CACHE_MODE_WB);

doing so violates the name of this function. The PAT of the untracked
range is still WB and not immune to UC MTRR.

> +	else
> +		cm =3D lookup_memtype(paddr);
>=20
>  	return cm =3D=3D _PAGE_CACHE_MODE_UC ||
>  	       cm =3D=3D _PAGE_CACHE_MODE_UC_MINUS ||