Received-SPF: pass (google.com: domain of linux-kernel+bounces-170878-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 7 May 2024 10:30:55 +0200
From: Nicolas Schier <n.schier@avm.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matt Porter <mporter@kernel.crashing.org>,
	Alexandre Bounine <alex.bou9@gmail.com>
Subject: Re: [PATCH 1/2] rapidio: specify the type for tristate choice
 explicitly
Message-ID: <Zjnmv1os_fM_j7M0@buildd.core.avm.de>
References: <20240427104231.2728905-1-masahiroy@kernel.org>
 <20240427104231.2728905-2-masahiroy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240427104231.2728905-2-masahiroy@kernel.org>

On Sat, Apr 27, 2024 at 07:42:30PM +0900, Masahiro Yamada wrote:
> If the type of choice is not specified, it is implied by the first
> entry within the choice block.
> 
> In this case, the first (and only) entry, RAPIDIO_ENUM_BASIC, is
> tristate, hence this choice behaves as tristate.
> 
> Kconfig will stop this implication because it has a bug, and 99% of
> choice use cases are bool. In fact, this is the only instance of
> tristate choice in the kernel.
> 
> Before transitioning the default choice type to 'bool', specify the
> type explicitly for this case.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---

Reviewed-by: Nicolas Schier <n.schier@avm.de>